mbox series

[BUGFIX,V2,0/7] block, bfq: series of fixes, and not only, for some recently reported issues

Message ID 20200203104100.16965-1-paolo.valente@linaro.org (mailing list archive)
Headers show
Series block, bfq: series of fixes, and not only, for some recently reported issues | expand

Message

Paolo Valente Feb. 3, 2020, 10:40 a.m. UTC
Hi Jens,
this the V2 of the series. The only change is the removal of ifdefs
from around gets and puts of bfq groups. As I wrote in my previous
cover letter, these patches are mostly fixes for the issues reported
in [1, 2]. All patches have been publicly tested in the dev version of
BFQ.

Thanks,
Paolo

[1] https://bugzilla.redhat.com/show_bug.cgi?id=1767539
[2] https://bugzilla.kernel.org/show_bug.cgi?id=205447

Paolo Valente (7):
  block, bfq: do not plug I/O for bfq_queues with no proc refs
  block, bfq: do not insert oom queue into position tree
  block, bfq: get extra ref to prevent a queue from being freed during a
    group move
  block, bfq: extend incomplete name of field on_st
  block, bfq: remove ifdefs from around gets/puts of bfq groups
  block, bfq: get a ref to a group when adding it to a service tree
  block, bfq: clarify the goal of bfq_split_bfqq()

 block/bfq-cgroup.c  | 16 ++++++++++++++--
 block/bfq-iosched.c | 26 ++++++++++++++++++++------
 block/bfq-iosched.h |  4 +++-
 block/bfq-wf2q.c    | 23 +++++++++++++++++------
 4 files changed, 54 insertions(+), 15 deletions(-)

--
2.20.1

Comments

Oleksandr Natalenko Feb. 3, 2020, 12:18 p.m. UTC | #1
On 03.02.2020 11:40, Paolo Valente wrote:
> Hi Jens,
> this the V2 of the series. The only change is the removal of ifdefs
> from around gets and puts of bfq groups. As I wrote in my previous
> cover letter, these patches are mostly fixes for the issues reported
> in [1, 2]. All patches have been publicly tested in the dev version of
> BFQ.
> 
> Thanks,
> Paolo
> 
> [1] https://bugzilla.redhat.com/show_bug.cgi?id=1767539
> [2] https://bugzilla.kernel.org/show_bug.cgi?id=205447
> 
> Paolo Valente (7):
>   block, bfq: do not plug I/O for bfq_queues with no proc refs
>   block, bfq: do not insert oom queue into position tree
>   block, bfq: get extra ref to prevent a queue from being freed during 
> a
>     group move
>   block, bfq: extend incomplete name of field on_st
>   block, bfq: remove ifdefs from around gets/puts of bfq groups
>   block, bfq: get a ref to a group when adding it to a service tree
>   block, bfq: clarify the goal of bfq_split_bfqq()
> 
>  block/bfq-cgroup.c  | 16 ++++++++++++++--
>  block/bfq-iosched.c | 26 ++++++++++++++++++++------
>  block/bfq-iosched.h |  4 +++-
>  block/bfq-wf2q.c    | 23 +++++++++++++++++------
>  4 files changed, 54 insertions(+), 15 deletions(-)
> 
> --
> 2.20.1

Feel free to add:

Tested-by: Oleksandr Natalenko <oleksandr@natalenko.name>

since I'm running v5.5 with this series applied for a couple of days 
already without any visible smoke.
Jens Axboe Feb. 3, 2020, 2:02 p.m. UTC | #2
On 2/3/20 3:40 AM, Paolo Valente wrote:
> Hi Jens,
> this the V2 of the series. The only change is the removal of ifdefs
> from around gets and puts of bfq groups. As I wrote in my previous
> cover letter, these patches are mostly fixes for the issues reported
> in [1, 2]. All patches have been publicly tested in the dev version of
> BFQ.

I'll apply this one, at least the ifdef cleanup is nice and patch
6/7 no longer makes your eyes burn!