[v2,0/2] null_blk cleanup and fix

Message

Damien Le Moal April 1, 2020, 1:07 a.m. UTC

Jens,

The first patch of this series extracts and extends a fix included in
the zone append series to correctly handle writes to null_blk zoned
devices. The fix forces zone type and zone condition checks to be
executed before the generic null_blk bad block and memory backing
options handling. The fix also makes sure that a zone write pointer
position is updated only if these two generic operations are executed
successfully.

The second patch is from Johannes series for REQ_OP_ZONE_APPEND support
to clean up null_blk zoned device initialization. The reviewed tag
from Christoph sent for the patch within Johannes post is included here.

Please consider these patches for inclusion in 5.7.

Changes from v1:
* Reversed patch order
* Addressed Christoph comments on patch 1 (function name, inline, etc)

Damien Le Moal (2):
  block: null_blk: Fix zoned command handling
  null_blk: Cleanup zoned device initialization

 drivers/block/null_blk.h       | 29 ++++++++++------
 drivers/block/null_blk_main.c  | 62 +++++++++++++++++-----------------
 drivers/block/null_blk_zoned.c | 41 ++++++++++++++++------
 3 files changed, 81 insertions(+), 51 deletions(-)

Comments

Damien Le Moal April 21, 2020, 9:10 a.m. UTC | #1

Jens,

On 2020/04/01 10:07, Damien Le Moal wrote:
> Jens,
> 
> The first patch of this series extracts and extends a fix included in
> the zone append series to correctly handle writes to null_blk zoned
> devices. The fix forces zone type and zone condition checks to be
> executed before the generic null_blk bad block and memory backing
> options handling. The fix also makes sure that a zone write pointer
> position is updated only if these two generic operations are executed
> successfully.
> 
> The second patch is from Johannes series for REQ_OP_ZONE_APPEND support
> to clean up null_blk zoned device initialization. The reviewed tag
> from Christoph sent for the patch within Johannes post is included here.
> 
> Please consider these patches for inclusion in 5.7.
> 
> Changes from v1:
> * Reversed patch order
> * Addressed Christoph comments on patch 1 (function name, inline, etc)
> 
> Damien Le Moal (2):
>   block: null_blk: Fix zoned command handling
>   null_blk: Cleanup zoned device initialization
> 
>  drivers/block/null_blk.h       | 29 ++++++++++------
>  drivers/block/null_blk_main.c  | 62 +++++++++++++++++-----------------
>  drivers/block/null_blk_zoned.c | 41 ++++++++++++++++------
>  3 files changed, 81 insertions(+), 51 deletions(-)
> 

Ping ?

Jens Axboe April 21, 2020, 5:38 p.m. UTC | #2

On 4/21/20 3:10 AM, Damien Le Moal wrote:
> Jens,
> 
> On 2020/04/01 10:07, Damien Le Moal wrote:
>> Jens,
>>
>> The first patch of this series extracts and extends a fix included in
>> the zone append series to correctly handle writes to null_blk zoned
>> devices. The fix forces zone type and zone condition checks to be
>> executed before the generic null_blk bad block and memory backing
>> options handling. The fix also makes sure that a zone write pointer
>> position is updated only if these two generic operations are executed
>> successfully.
>>
>> The second patch is from Johannes series for REQ_OP_ZONE_APPEND support
>> to clean up null_blk zoned device initialization. The reviewed tag
>> from Christoph sent for the patch within Johannes post is included here.
>>
>> Please consider these patches for inclusion in 5.7.

Can you respin for block-5.7? The series doesn't apply.