From patchwork Fri Jul 17 11:22:20 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Coly Li X-Patchwork-Id: 11669931 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id CB0B3138C for ; Fri, 17 Jul 2020 11:22:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BCE8020734 for ; Fri, 17 Jul 2020 11:22:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726381AbgGQLWs (ORCPT ); Fri, 17 Jul 2020 07:22:48 -0400 Received: from mx2.suse.de ([195.135.220.15]:60504 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726070AbgGQLWr (ORCPT ); Fri, 17 Jul 2020 07:22:47 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 5EAA1B687; Fri, 17 Jul 2020 11:22:50 +0000 (UTC) From: Coly Li To: linux-bcache@vger.kernel.org Cc: linux-block@vger.kernel.org, hare@suse.de, Coly Li Subject: [PATCH v4 00/16] bcache: extend bucket size to 32bit width Date: Fri, 17 Jul 2020 19:22:20 +0800 Message-Id: <20200717112236.44761-1-colyli@suse.de> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org This patch series is an effort to extent bucket_size from 16bit to 32bit width. This is the code base for next step to use zoned device as cache device. In this series, these changes should be noticed, - Increase the super block version to BCACHE_SB_VERSION_CDEV_WITH_FEATURES 5 BCACHE_SB_VERSION_BDEV_WITH_FEATURES 6 - The new version adds 3 new members, __le64 feature_compat; __le64 feature_incompat; __le64 feature_ro_compat; If new feature added will change the on-disk format, just setting the feature set bits, no need to upstream super block version. - The in-memory struct cache_sb does not exactly map the on-disk struct cache_sb_disk. - Add 32bit bucket_size_hi in struct cache_sb_disk, __le32 bucket_size_hi; In theory bucket_size can be extended to 48bit, but now 32bit width is big enough. - Other changes to follow the large bucket size. The changes are mostly on cache device, except the super block update there is no change about the backing device. Any code review comments or suggestion is welcome. Thanks in advance. Coly Li --- Changelog: v4: Update with Hannes' comments of v3 series code review. v3: Update with Hannes' comments of v2 series code review. v2: several bug fixes, and add sysfs file to display cache set feature sets information. v1: initial RFC version. Coly Li (16): bcache: add read_super_common() to read major part of super block bcache: add more accurate error information in read_super_common() bcache: disassemble the big if() checks in bch_cache_set_alloc() bcache: fix super block seq numbers comparision in register_cache_set() bcache: increase super block version for cache device and backing device bcache: move bucket related code into read_super_common() bcache: struct cache_sb is only for in-memory super block now bcache: introduce meta_bucket_pages() related helper routines bcache: handle c->uuids properly for bucket size > 8MB bcache: handle cache prio_buckets and disk_buckets properly for bucket size > 8MB bcache: handle cache set verify_ondisk properly for bucket size > 8MB bcache: handle btree node memory allocation properly for bucket size > 8MB bcache: add bucket_size_hi into struct cache_sb_disk for large bucket bcache: add sysfs file to display feature sets information of cache set bcache: avoid extra memory allocation from mempool c->fill_iter bcache: avoid extra memory consumption in struct bbio for large bucket size drivers/md/bcache/Makefile | 2 +- drivers/md/bcache/alloc.c | 2 +- drivers/md/bcache/bcache.h | 29 +++- drivers/md/bcache/btree.c | 12 +- drivers/md/bcache/features.c | 75 ++++++++++ drivers/md/bcache/features.h | 86 ++++++++++++ drivers/md/bcache/io.c | 2 +- drivers/md/bcache/movinggc.c | 4 +- drivers/md/bcache/super.c | 261 ++++++++++++++++++++++++----------- drivers/md/bcache/sysfs.c | 14 ++ include/uapi/linux/bcache.h | 38 +++-- 11 files changed, 422 insertions(+), 103 deletions(-) create mode 100644 drivers/md/bcache/features.c create mode 100644 drivers/md/bcache/features.h