mbox series

[v2,0/3] block: improve iostat for md/bcache partitions

Message ID 20200818222645.952219-1-songliubraving@fb.com (mailing list archive)
Headers show
Series block: improve iostat for md/bcache partitions | expand

Message

Song Liu Aug. 18, 2020, 10:26 p.m. UTC
Currently, devices like md, bcache uses disk_[start|end]_io_acct to report
iostat. These functions couldn't get proper iostat for partitions on these
devices.

This set resolves this issue by introducing part_[begin|end]_io_acct, and
using them in md and bcache code.

Changes v1 => v2:
1. Refactor the code, as suggested by Christoph.
2. Include Coly's Reviewed-by tag.

Song Liu (3):
  block: introduce part_[begin|end]_io_acct
  md: use part_[begin|end]_io_acct instead of disk_[begin|end]_io_acct
  bcache: use part_[begin|end]_io_acct instead of
    disk_[begin|end]_io_acct

 block/blk-core.c            | 39 +++++++++++++++++++++++++++++++------
 drivers/md/bcache/request.c | 10 ++++++----
 drivers/md/md.c             |  8 ++++----
 include/linux/blkdev.h      |  5 +++++
 4 files changed, 48 insertions(+), 14 deletions(-)

--
2.24.1

Comments

Song Liu Aug. 28, 2020, 6 p.m. UTC | #1
> On Aug 18, 2020, at 3:26 PM, Song Liu <songliubraving@fb.com> wrote:
> 
> Currently, devices like md, bcache uses disk_[start|end]_io_acct to report
> iostat. These functions couldn't get proper iostat for partitions on these
> devices.
> 
> This set resolves this issue by introducing part_[begin|end]_io_acct, and
> using them in md and bcache code.
> 
> Changes v1 => v2:
> 1. Refactor the code, as suggested by Christoph.
> 2. Include Coly's Reviewed-by tag.
> 
> Song Liu (3):
>  block: introduce part_[begin|end]_io_acct
>  md: use part_[begin|end]_io_acct instead of disk_[begin|end]_io_acct
>  bcache: use part_[begin|end]_io_acct instead of
>    disk_[begin|end]_io_acct
> 
> block/blk-core.c            | 39 +++++++++++++++++++++++++++++++------
> drivers/md/bcache/request.c | 10 ++++++----
> drivers/md/md.c             |  8 ++++----
> include/linux/blkdev.h      |  5 +++++
> 4 files changed, 48 insertions(+), 14 deletions(-)

Hi Christoph, 

Does this version look good to you?

Thanks,
Song