| Message ID | 20200904091341.28756-1-huobean@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | use generic_file_buffered_read() | expand |
On 9/4/20 3:13 AM, Bean Huo wrote: > From: Bean Huo <beanhuo@micron.com> > > > Bean Huo (2): > block: use generic_file_buffered_read() > fs: isofs: use generic_file_buffered_read() The change is fine, but the title/commit message should reflect that this is just a comment change. The way it currently reads, it sounds like a functional change where something is switched over to using generic_file_buffered_read().
On Fri, 2020-09-04 at 10:53 -0600, Jens Axboe wrote: > > Bean Huo (2): > > block: use generic_file_buffered_read() > > fs: isofs: use generic_file_buffered_read() > > The change is fine, but the title/commit message should reflect that > this is just a comment change. The way it currently reads, it sounds > like a functional change where something is switched over to using > generic_file_buffered_read(). > Hi Jens Indeed, it's easy to mistake this for a functional change, but it's actually a comment change. I have corrected them in the new patch, you can check now. thanks, Bean
From: Bean Huo <beanhuo@micron.com> Bean Huo (2): block: use generic_file_buffered_read() fs: isofs: use generic_file_buffered_read() drivers/block/sunvdc.c | 6 +++--- fs/isofs/compress.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-)