mbox series

[0/5] bcache patches for Linux v5.11-rc3

Message ID 20210104074122.19759-1-colyli@suse.de (mailing list archive)
Headers show
Series bcache patches for Linux v5.11-rc3 | expand

Message

Coly Li Jan. 4, 2021, 7:41 a.m. UTC
Hi Jens,

This series is not planned but necessary. The four patches from me fix
a bcache super block layout issue which was introduced in 5.9 when large
bucket (32MB-1TB size for zoned device) feature firstly introduced.

Previous code has problem on space consumption and checksum calculation.
These four patches improve and fix the problems with on-disk format
consistency. Although now almost no one (except me) uses the large
bucket code now, it should be good to have the fix as soon as possible.

This series also has a patch from Yi Li which avoid a redundant value
assignment in a two-level loop. It is cool if we may have it in 5.11.

User space bcache-tools are updated for the above kernel changes too.
Please take them for 5.11-rc3.

Thanks in advance.

Coly Li
---


Coly Li (4):
  bcache: fix typo from SUUP to SUPP in features.h
  bcache: check unsupported feature sets for bcache register
  bcache: introduce BCH_FEATURE_INCOMPAT_LOG_LARGE_BUCKET_SIZE for large
    bucket
  bcache: set bcache device into read-only mode for
    BCH_FEATURE_INCOMPAT_OBSO_LARGE_BUCKET

Yi Li (1):
  bcache: set pdev_set_uuid before scond loop iteration

 drivers/md/bcache/features.c |  2 +-
 drivers/md/bcache/features.h | 30 ++++++++++++++++----
 drivers/md/bcache/super.c    | 53 +++++++++++++++++++++++++++++++++---
 include/uapi/linux/bcache.h  |  2 +-
 4 files changed, 76 insertions(+), 11 deletions(-)

Comments

Coly Li Jan. 9, 2021, 3:02 p.m. UTC | #1
On 1/4/21 3:41 PM, Coly Li wrote:
> Hi Jens,
> 
> This series is not planned but necessary. The four patches from me fix
> a bcache super block layout issue which was introduced in 5.9 when large
> bucket (32MB-1TB size for zoned device) feature firstly introduced.
> 
> Previous code has problem on space consumption and checksum calculation.
> These four patches improve and fix the problems with on-disk format
> consistency. Although now almost no one (except me) uses the large
> bucket code now, it should be good to have the fix as soon as possible.
> 
> This series also has a patch from Yi Li which avoid a redundant value
> assignment in a two-level loop. It is cool if we may have it in 5.11.
> 
> User space bcache-tools are updated for the above kernel changes too.
> Please take them for 5.11-rc3.
> 

Hi Jens,

Could you please to take this series for rc3?

Thanks in advance.


Coly Li



> ---
> 
> 
> Coly Li (4):
>   bcache: fix typo from SUUP to SUPP in features.h
>   bcache: check unsupported feature sets for bcache register
>   bcache: introduce BCH_FEATURE_INCOMPAT_LOG_LARGE_BUCKET_SIZE for large
>     bucket
>   bcache: set bcache device into read-only mode for
>     BCH_FEATURE_INCOMPAT_OBSO_LARGE_BUCKET
> 
> Yi Li (1):
>   bcache: set pdev_set_uuid before scond loop iteration
> 
>  drivers/md/bcache/features.c |  2 +-
>  drivers/md/bcache/features.h | 30 ++++++++++++++++----
>  drivers/md/bcache/super.c    | 53 +++++++++++++++++++++++++++++++++---
>  include/uapi/linux/bcache.h  |  2 +-
>  4 files changed, 76 insertions(+), 11 deletions(-)
>
Jens Axboe Jan. 9, 2021, 4:21 p.m. UTC | #2
On 1/4/21 12:41 AM, Coly Li wrote:
> Hi Jens,
> 
> This series is not planned but necessary. The four patches from me fix
> a bcache super block layout issue which was introduced in 5.9 when large
> bucket (32MB-1TB size for zoned device) feature firstly introduced.
> 
> Previous code has problem on space consumption and checksum calculation.
> These four patches improve and fix the problems with on-disk format
> consistency. Although now almost no one (except me) uses the large
> bucket code now, it should be good to have the fix as soon as possible.
> 
> This series also has a patch from Yi Li which avoid a redundant value
> assignment in a two-level loop. It is cool if we may have it in 5.11.
> 
> User space bcache-tools are updated for the above kernel changes too.
> Please take them for 5.11-rc3.

Applied, thanks.