mbox series

[V3,0/3] block: add two statistic tables

Message ID 20210202031009.11584-1-guoqing.jiang@cloud.ionos.com (mailing list archive)
Headers show
Series block: add two statistic tables | expand

Message

Guoqing Jiang Feb. 2, 2021, 3:10 a.m. UTC
Hi Jens,

I reorganized the patch set based on Johannes's suggestion.

Thanks,
Guoqing

PATCH V2: https://lore.kernel.org/linux-block/20210201012727.28305-1-guoqing.jiang@cloud.ionos.com/T/#t
*. remove BLK_ADDITIONAL_DISKSTAT option per Christoph's comment.
*. move blk_queue_io_extra_stat into blk_additional_{latency,sector}
   per Christoph's comment.
*. simplify blk_additional_latency by pass duration time directly.

PATCH V1: https://marc.info/?l=linux-block&m=161176000024443&w=2
* add Jack's reviewed-by.

RFC V4: https://marc.info/?l=linux-block&m=161027198729158&w=2
* rebase with latest code.

RFC V3: https://marc.info/?l=linux-block&m=159730633416534&w=2
* Move the #ifdef CONFIG_BLK_ADDITIONAL_DISKSTAT into the function body
  per Johannes's comment.
* Tweak the output of two tables to make they are more intuitive

RFC V2: https://marc.info/?l=linux-block&m=159467483514062&w=2
* don't call ktime_get_ns and drop unnecessary patches.
* add io_extra_stats to avoid potential overhead.

RFC V1: https://marc.info/?l=linux-block&m=159419516730386&w=2

Guoqing Jiang (3):
  block: add io_extra_stats node
  block: add a statistic table for io latency
  block: add a statistic table for io sector

 Documentation/ABI/testing/sysfs-block | 26 ++++++++++
 Documentation/block/queue-sysfs.rst   |  5 ++
 block/blk-core.c                      | 43 ++++++++++++++++
 block/blk-sysfs.c                     |  3 ++
 block/genhd.c                         | 74 +++++++++++++++++++++++++++
 include/linux/blkdev.h                |  2 +
 include/linux/part_stat.h             |  6 +++
 7 files changed, 159 insertions(+)

Comments

Johannes Thumshirn Feb. 2, 2021, 10:48 a.m. UTC | #1
Not a huge fan of the function names, but I don't have a better idea either.

For the whole series,
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Guoqing Jiang Feb. 2, 2021, 2:42 p.m. UTC | #2
On 2/2/21 11:48, Johannes Thumshirn wrote:
> Not a huge fan of the function names, but I don't have a better idea either.
> 
> For the whole series,
> Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
> 

Thanks! I will add it if I need to send a new version.

Guoqing