| Message ID | 20220129015924.3958918-1-yukuai3@huawei.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | block, bfq: minor cleanup and fix | expand |
On 1/28/22 6:59 PM, Yu Kuai wrote: > Changes in v3: > - fix a clerical error in patch 2 > > Chagnes in v2: > - add comment in patch 2 > - remove patch 4, since the problem do not exist. > > Yu Kuai (3): > block, bfq: cleanup bfq_bfqq_to_bfqg() > block, bfq: avoid moving bfqq to it's parent bfqg > block, bfq: don't move oom_bfqq > > block/bfq-cgroup.c | 16 +++++++++++++++- > block/bfq-iosched.c | 4 ++-- > block/bfq-iosched.h | 1 - > block/bfq-wf2q.c | 15 --------------- > 4 files changed, 17 insertions(+), 19 deletions(-) I'm not even looking at this until you tell me that: a) you've actually compiled this one. which, btw, I can't believe needs mentioning, particularly when you had enough time to keep pinging about this patchset. b) it's actually be run. last one was clearly not.
在 2022/01/29 9:51, Jens Axboe 写道: > On 1/28/22 6:59 PM, Yu Kuai wrote: >> Changes in v3: >> - fix a clerical error in patch 2 >> >> Chagnes in v2: >> - add comment in patch 2 >> - remove patch 4, since the problem do not exist. >> >> Yu Kuai (3): >> block, bfq: cleanup bfq_bfqq_to_bfqg() >> block, bfq: avoid moving bfqq to it's parent bfqg >> block, bfq: don't move oom_bfqq >> >> block/bfq-cgroup.c | 16 +++++++++++++++- >> block/bfq-iosched.c | 4 ++-- >> block/bfq-iosched.h | 1 - >> block/bfq-wf2q.c | 15 --------------- >> 4 files changed, 17 insertions(+), 19 deletions(-) > > I'm not even looking at this until you tell me that: > > a) you've actually compiled this one. which, btw, I can't believe > needs mentioning, particularly when you had enough time to keep > pinging about this patchset. > > b) it's actually be run. last one was clearly not. > Hi, I compiled and tested the patchset locally in a different version, v4.19 specifically. However, after I decide to send them to mainline, I made such clerical mistake and forgot to check the patches. My sincerely apologize again... Kuai
在 2022/01/29 10:05, yukuai (C) 写道: > 在 2022/01/29 9:51, Jens Axboe 写道: >> On 1/28/22 6:59 PM, Yu Kuai wrote: >>> Changes in v3: >>> - fix a clerical error in patch 2 >>> >>> Chagnes in v2: >>> - add comment in patch 2 >>> - remove patch 4, since the problem do not exist. >>> >>> Yu Kuai (3): >>> block, bfq: cleanup bfq_bfqq_to_bfqg() >>> block, bfq: avoid moving bfqq to it's parent bfqg >>> block, bfq: don't move oom_bfqq >>> >>> block/bfq-cgroup.c | 16 +++++++++++++++- >>> block/bfq-iosched.c | 4 ++-- >>> block/bfq-iosched.h | 1 - >>> block/bfq-wf2q.c | 15 --------------- >>> 4 files changed, 17 insertions(+), 19 deletions(-) >> >> I'm not even looking at this until you tell me that: >> >> a) you've actually compiled this one. which, btw, I can't believe >> needs mentioning, particularly when you had enough time to keep >> pinging about this patchset. >> >> b) it's actually be run. last one was clearly not. >> > Hi, > > I compiled and tested the patchset locally in a different version, > v4.19 specifically. However, after I decide to send them to mainline, > I made such clerical mistake and forgot to check the patches. > > My sincerely apologize again... > Kuai Hi, Jens Can you please apply this patch this time? Thanks, Kuai
friendly ping ... 在 2022/02/10 19:46, yukuai (C) 写道: > 在 2022/01/29 10:05, yukuai (C) 写道: >> 在 2022/01/29 9:51, Jens Axboe 写道: >>> On 1/28/22 6:59 PM, Yu Kuai wrote: >>>> Changes in v3: >>>> - fix a clerical error in patch 2 >>>> >>>> Chagnes in v2: >>>> - add comment in patch 2 >>>> - remove patch 4, since the problem do not exist. >>>> >>>> Yu Kuai (3): >>>> block, bfq: cleanup bfq_bfqq_to_bfqg() >>>> block, bfq: avoid moving bfqq to it's parent bfqg >>>> block, bfq: don't move oom_bfqq >>>> >>>> block/bfq-cgroup.c | 16 +++++++++++++++- >>>> block/bfq-iosched.c | 4 ++-- >>>> block/bfq-iosched.h | 1 - >>>> block/bfq-wf2q.c | 15 --------------- >>>> 4 files changed, 17 insertions(+), 19 deletions(-) >>> >>> I'm not even looking at this until you tell me that: >>> >>> a) you've actually compiled this one. which, btw, I can't believe >>> needs mentioning, particularly when you had enough time to keep >>> pinging about this patchset. >>> >>> b) it's actually be run. last one was clearly not. >>> >> Hi, >> >> I compiled and tested the patchset locally in a different version, >> v4.19 specifically. However, after I decide to send them to mainline, >> I made such clerical mistake and forgot to check the patches. >> >> My sincerely apologize again... >> Kuai > > Hi, Jens > > Can you please apply this patch this time? > > Thanks, > Kuai
On Sat, 29 Jan 2022 09:59:21 +0800, Yu Kuai wrote: > Changes in v3: > - fix a clerical error in patch 2 > > Chagnes in v2: > - add comment in patch 2 > - remove patch 4, since the problem do not exist. > > [...] Applied, thanks! [1/3] block, bfq: cleanup bfq_bfqq_to_bfqg() commit: 43a4b1fee098bd38eed9c334d0e0df221ecdf719 [2/3] block, bfq: avoid moving bfqq to it's parent bfqg commit: c5e4cb0fcbbaa5ad853818c4a2383e9bd147fad6 [3/3] block, bfq: don't move oom_bfqq commit: 8410f70977734f21b8ed45c37e925d311dfda2e7 Best regards,