mbox series

[-next,v3,0/6] multiple cleanup patches for bfq

Message ID 20220528095958.270455-1-yukuai3@huawei.com (mailing list archive)
Headers show
Series multiple cleanup patches for bfq | expand

Message

Yu Kuai May 28, 2022, 9:59 a.m. UTC 
Resend just in case v2 end up in spam (for Paolo).

Changes in v2:
 - add missing blank line in patch 1.
 - remove patch 7,8, since they are wrong.
 - add reviewed-by tag

There are no functional changes in this patchset, just some places
that I think can be improved during code review.

Previous version:
v1: https://lore.kernel.org/all/20220514090522.1669270-1-yukuai3@huawei.com/

Yu Kuai (6):
  block, bfq: cleanup bfq_weights_tree add/remove apis
  block, bfq: cleanup __bfq_weights_tree_remove()
  block, bfq: factor out code to update 'active_entities'
  block, bfq: don't declare 'bfqd' as type 'void *' in bfq_group
  block, bfq: cleanup bfq_activate_requeue_entity()
  block, bfq: remove dead code for updating 'rq_in_driver'

 block/bfq-cgroup.c  |  2 +-
 block/bfq-iosched.c | 38 +++----------------
 block/bfq-iosched.h | 11 ++----
 block/bfq-wf2q.c    | 91 ++++++++++++++++++++-------------------------
 4 files changed, 51 insertions(+), 91 deletions(-)

Comments

Paolo Valente May 30, 2022, 7:34 a.m. UTC | #1 
> Il giorno 28 mag 2022, alle ore 11:59, Yu Kuai <yukuai3@huawei.com> ha scritto:
> 
> Resend just in case v2 end up in spam (for Paolo).
> 
> Changes in v2:
> - add missing blank line in patch 1.
> - remove patch 7,8, since they are wrong.
> - add reviewed-by tag
> 
> There are no functional changes in this patchset, just some places
> that I think can be improved during code review.
> 

Thank you for this cleanup!

Acked-by: Paolo Valente <paolo.valente@unimore.it>

> Previous version:
> v1: https://lore.kernel.org/all/20220514090522.1669270-1-yukuai3@huawei.com/
> 
> Yu Kuai (6):
>  block, bfq: cleanup bfq_weights_tree add/remove apis
>  block, bfq: cleanup __bfq_weights_tree_remove()
>  block, bfq: factor out code to update 'active_entities'
>  block, bfq: don't declare 'bfqd' as type 'void *' in bfq_group
>  block, bfq: cleanup bfq_activate_requeue_entity()
>  block, bfq: remove dead code for updating 'rq_in_driver'
> 
> block/bfq-cgroup.c  |  2 +-
> block/bfq-iosched.c | 38 +++----------------
> block/bfq-iosched.h | 11 ++----
> block/bfq-wf2q.c    | 91 ++++++++++++++++++++-------------------------
> 4 files changed, 51 insertions(+), 91 deletions(-)
> 
> -- 
> 2.31.1
>