mbox series

[V2,blktests,0/3] fix and improvement for xfs log size change from new xfsprogs version

Message ID 20221102025702.1664101-1-yi.zhang@redhat.com (mailing list archive)
Headers show
Series fix and improvement for xfs log size change from new xfsprogs version | expand

Message

Yi Zhang Nov. 2, 2022, 2:56 a.m. UTC 
Hi

The first patch addressed nvme/012 nvme/013 failure which introduced
from xfsprogs v5.19.0, the minimun xfs log size change to 64m

The second patch introduced one new function _require_test_dev_size_mb

The third patch add one new parameter to _run_fio_verify_io, this will
allow fio I/O size definition to the test case


V2:
Update the new function to _require_test_dev_size_mb and nvme/035
to call it for test dev size checking for the second patch
Update the title and description for better reflect the change for the
third patch

V1: https://lore.kernel.org/linux-block/20221024061319.1133470-1-yi.zhang@redhat.com/

Yi Zhang (3):
  common/xfs: set the minimal log size 64m during mkfs.xfs
  common/rc: add one function _require_test_dev_size_mb
  nvme/012,013,035: change fio I/O size and move size definition place

 common/rc      | 10 ++++++++++
 common/xfs     |  5 +++--
 tests/nvme/012 |  2 +-
 tests/nvme/013 |  2 +-
 tests/nvme/035 |  6 +++++-
 5 files changed, 20 insertions(+), 5 deletions(-)

Comments

Chaitanya Kulkarni Nov. 2, 2022, 5:43 a.m. UTC | #1 
On 11/1/22 19:56, Yi Zhang wrote:
> Hi
> 
> The first patch addressed nvme/012 nvme/013 failure which introduced
> from xfsprogs v5.19.0, the minimun xfs log size change to 64m
> 
> The second patch introduced one new function _require_test_dev_size_mb
> 
> The third patch add one new parameter to _run_fio_verify_io, this will
> allow fio I/O size definition to the test case
> 
> 
> V2:
> Update the new function to _require_test_dev_size_mb and nvme/035
> to call it for test dev size checking for the second patch
> Update the title and description for better reflect the change for the
> third patch
> 
> V1: https://lore.kernel.org/linux-block/20221024061319.1133470-1-yi.zhang@redhat.com/


overall this looks good to me, I believe you have tested this
to confirm the stability of the new size for the testcases,

Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>

-ck
Shinichiro Kawasaki Nov. 4, 2022, 11:42 a.m. UTC | #2 
On Nov 02, 2022 / 10:56, Yi Zhang wrote:
> Hi
> 
> The first patch addressed nvme/012 nvme/013 failure which introduced
> from xfsprogs v5.19.0, the minimun xfs log size change to 64m
> 
> The second patch introduced one new function _require_test_dev_size_mb
> 
> The third patch add one new parameter to _run_fio_verify_io, this will
> allow fio I/O size definition to the test case

Have applied the patches. Please note that I took a liberty to do minor edits in
the second patch. Thanks!