| Message ID | 20221205115709.251489-1-shikemeng@huaweicloud.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | A few bugfix and cleanup patches for blk-throttle | expand |
On Mon, 05 Dec 2022 19:57:00 +0800, Kemeng Shi wrote: > hierarchy, corret comment and so on. More details can be found in > respective changelogs. Thanks. > Applied, thanks! [1/9] blk-throttle: correct stale comment in throtl_pd_init commit: f56019aef353576f43f945fdd065858145090582 [2/9] blk-throttle: Fix that bps of child could exceed bps limited in parent commit: 84aca0a7e039c8735abc0f89f3f48e9006c0dfc7 [3/9] blk-throttle: ignore cgroup without io queued in blk_throtl_cancel_bios commit: eb184791821409c37fef4f67638bb56bdaa82900 [4/9] blk-throttle: correct calculation of wait time in tg_may_dispatch commit: 183daeb11de871b073515d14ec1e3bc0da79e038 [5/9] blk-throttle: simpfy low limit reached check in throtl_tg_can_upgrade commit: a4d508e333829a8394e59efa06ce56e51f3e2b29 [6/9] blk-throttle: fix typo in comment of throtl_adjusted_limit commit: 009df341714c6c20a44dd9268681a8bff10bb050 [7/9] blk-throttle: remove incorrect comment for tg_last_low_overflow_time commit: e3031d4c7d2c5bff6b5944d61d4e31319739d216 [8/9] blk-throttle: remove repeat check of elapsed time from last upgrade in throtl_hierarchy_can_downgrade commit: 9c9f209d9d81ea67cd84f53f470a592c252d845d [9/9] blk-throttle: Use more siutable time_after check for update of slice_start commit: eea3e8b74aa1648fc96b739458d067a6e498c302 Best regards,
Hi, this series contain a few patches to fix problem when on the default hierarchy, corret comment and so on. More details can be found in respective changelogs. Thanks. --- V2->V3: -Thanks for the review and advice from Tejun. Now all patches are acked by Tejun. -remove quotes around parent in corrected comment in patch "blk-throttle: correct stale comment in throtl_pd_init" -improve log message and rename throtl_tg_reach_low_limit to throtl_low_limit_reached. -drop patch "blk-throttle: avoid dead code in throtl_hierarchy_can_upgrade" --- V1->V2: -Thanks for the review and advice from Tejun. The corrected comment of "blk-throttle: correct stale comment in throtl_pd_init" and the solution of "blk-throttle: Fix that bps of child could exceed bps limited in parent" are from reply of Tejun. -Collect Ack from Tejun. -Fix the compile problem when CONFIG_BLK_DEV_THROTTLING_LOW is set. -Drop "blk-throttle: Limit whole system if root group is configured when on the default hierarchy", "blk-throttle: remove unnecessary check for validation of limit index" and "blk-throttle: remove unused variable td in tg_update_has_rules" -Add "blk-throttle: correct stale comment in throtl_pd_init" and "blk-throttle: avoid dead code in throtl_hierarchy_can_upgrade" -Use solution that set the BIO_BPS_THROTTLED flag only when the bio traversed the entire tree to fix that bps of child could exceed bps limited in parent in patch 2/10. -Improve the description and comment of most commits. --- Kemeng Shi (9): blk-throttle: correct stale comment in throtl_pd_init blk-throttle: Fix that bps of child could exceed bps limited in parent blk-throttle: ignore cgroup without io queued in blk_throtl_cancel_bios blk-throttle: correct calculation of wait time in tg_may_dispatch blk-throttle: simpfy low limit reached check in throtl_tg_can_upgrade blk-throttle: fix typo in comment of throtl_adjusted_limit blk-throttle: remove incorrect comment for tg_last_low_overflow_time blk-throttle: remove repeat check of elapsed time from last upgrade in throtl_hierarchy_can_downgrade blk-throttle: Use more siutable time_after check for update of slice_start block/blk-throttle.c | 102 +++++++++++++++++++++++-------------------- 1 file changed, 55 insertions(+), 47 deletions(-)