mbox series

[blktests,v3,0/2] blktests: add mini ublk source and blktests/033

Message ID 20230220034649.1522978-1-ming.lei@redhat.com (mailing list archive)
Headers show
Series blktests: add mini ublk source and blktests/033 | expand

Message

Ming Lei Feb. 20, 2023, 3:46 a.m. UTC 
Hello,

The 1st patch adds one mini ublk program, which only supports null &
loop targets.

The 2nd patch add blktests/033 for covering gendisk leak issue.

v3:
	- move minublk.c into src/
	- remove '-i' in top Makefile
	- fix commit log for 1/2
	- add 'udevadm settle' after adding device, so that the following
	test can be done reliably
	- fix _init_ublk()
	- redirect runtime log into $FULL
	- all are suggested by Shinichiro Kawasaki

v2:
	- cleanup & bugfix on miniublk.c
	- avoid ignoring build warning just for addressing missed liburing
	  or ublk kernel header
	- patch style fix
	- make 'make check' happy


Ming Lei (2):
  src: add mini ublk source code
  block/033: add test to cover gendisk leak

 common/ublk         |   35 ++
 src/.gitignore      |    1 +
 src/Makefile        |   18 +
 src/miniublk.c      | 1376 +++++++++++++++++++++++++++++++++++++++++++
 tests/block/033     |   41 ++
 tests/block/033.out |    2 +
 6 files changed, 1473 insertions(+)
 create mode 100644 common/ublk
 create mode 100644 src/miniublk.c
 create mode 100755 tests/block/033
 create mode 100644 tests/block/033.out

Comments

Shinichiro Kawasaki Feb. 20, 2023, 1:03 p.m. UTC | #1 
On Feb 20, 2023 / 11:46, Ming Lei wrote:
> Hello,
> 
> The 1st patch adds one mini ublk program, which only supports null &
> loop targets.
> 
> The 2nd patch add blktests/033 for covering gendisk leak issue.
> 
> v3:
> 	- move minublk.c into src/
> 	- remove '-i' in top Makefile
> 	- fix commit log for 1/2
> 	- add 'udevadm settle' after adding device, so that the following
> 	test can be done reliably
> 	- fix _init_ublk()
> 	- redirect runtime log into $FULL
> 	- all are suggested by Shinichiro Kawasaki

Ming, thanks for v3. The patches look good to me. I'll wait for a few more days
before merge in case someone have more comments.