mbox series

[blktests,v4,0/2] blktests: add mini ublk source and blktests/033

Message ID 20230224124502.1720278-1-ming.lei@redhat.com (mailing list archive)
Headers show
Series blktests: add mini ublk source and blktests/033 | expand

Message

Ming Lei Feb. 24, 2023, 12:45 p.m. UTC 
Hello,

The 1st patch adds one mini ublk program, which only supports null &
loop targets.

The 2nd patch add blktests/033 for covering gendisk leak issue.

v4:
	- fix one error handling bug in src/miniublk.c
	- patch style improvement on src/miniublk.c
	- both are suggested by Chaitanya Kulkarni

v3:
	- move minublk.c into src/
	- remove '-i' in top Makefile
	- fix commit log for 1/2
	- add 'udevadm settle' after adding device, so that the following
	test can be done reliably
	- fix _init_ublk()
	- redirect runtime log into $FULL
	- all are suggested by Shinichiro Kawasaki

v2:
	- cleanup & bugfix on miniublk.c
	- avoid ignoring build warning just for addressing missed liburing
	  or ublk kernel header
	- patch style fix
	- make 'make check' happy

Ming Lei (2):
  src: add mini ublk source code
  block/033: add test to cover gendisk leak

 common/ublk         |   35 ++
 src/.gitignore      |    1 +
 src/Makefile        |   18 +
 src/miniublk.c      | 1367 +++++++++++++++++++++++++++++++++++++++++++
 tests/block/033     |   41 ++
 tests/block/033.out |    2 +
 6 files changed, 1464 insertions(+)
 create mode 100644 common/ublk
 create mode 100644 src/miniublk.c
 create mode 100755 tests/block/033
 create mode 100644 tests/block/033.out

Comments

Shinichiro Kawasaki March 1, 2023, 8:27 a.m. UTC | #1 
On Feb 24, 2023 / 20:45, Ming Lei wrote:
> Hello,
> 
> The 1st patch adds one mini ublk program, which only supports null &
> loop targets.
> 
> The 2nd patch add blktests/033 for covering gendisk leak issue.
> 
> v4:
> 	- fix one error handling bug in src/miniublk.c
> 	- patch style improvement on src/miniublk.c
> 	- both are suggested by Chaitanya Kulkarni

The changes for v4 looks good to me. I also did a trial run together with the
follow-up patch [*] and observed good result.

[*] https://lore.kernel.org/linux-block/20230301080301.2410060-1-shinichiro.kawasaki@wdc.com/

Chaitanya, will you review v4 again?
Chaitanya Kulkarni March 2, 2023, 5 a.m. UTC | #2 
On 2/24/2023 4:45 AM, Ming Lei wrote:
> Hello,
> 
> The 1st patch adds one mini ublk program, which only supports null &
> loop targets.
> 
> The 2nd patch add blktests/033 for covering gendisk leak issue.
>

Looks good to me, feel free to merge it.

Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>

-ck
Shinichiro Kawasaki March 2, 2023, 7:44 a.m. UTC | #3 
On Mar 02, 2023 / 05:00, Chaitanya Kulkarni wrote:
> On 2/24/2023 4:45 AM, Ming Lei wrote:
> > Hello,
> > 
> > The 1st patch adds one mini ublk program, which only supports null &
> > loop targets.
> > 
> > The 2nd patch add blktests/033 for covering gendisk leak issue.
> >
> 
> Looks good to me, feel free to merge it.
> 
> Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>

Thanks Chaitanya.

Ming, I've merged the patches. Thanks!
Ming Lei March 2, 2023, 7:48 a.m. UTC | #4 
On Thu, Mar 02, 2023 at 07:44:46AM +0000, Shinichiro Kawasaki wrote:
> On Mar 02, 2023 / 05:00, Chaitanya Kulkarni wrote:
> > On 2/24/2023 4:45 AM, Ming Lei wrote:
> > > Hello,
> > > 
> > > The 1st patch adds one mini ublk program, which only supports null &
> > > loop targets.
> > > 
> > > The 2nd patch add blktests/033 for covering gendisk leak issue.
> > >
> > 
> > Looks good to me, feel free to merge it.
> > 
> > Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
> 
> Thanks Chaitanya.
> 
> Ming, I've merged the patches. Thanks!

Great! Thanks all of you!

Thanks,
Ming