mbox series

[v3,0/4] block/badblocks: fix badblocks setting error

Message ID 20230621172052.1499919-1-linan666@huaweicloud.com (mailing list archive)
Headers show
Series block/badblocks: fix badblocks setting error | expand

Message

Li Nan June 21, 2023, 5:20 p.m. UTC
From: Li Nan <linan122@huawei.com>

This patch series fixes some simple bugs of setting badblocks and
optimizing struct badblocks. Coly Li has been trying to refactor badblocks
in patch series "badblocks improvement for multiple bad block ranges", but
the workload is significant. Before that, I will fix some easily triggered
issues and optimize some code that does not conflict with Coly's changes.

Changes in v3:
 - delete patchs with significant changes.

Li Nan (4):
  block/badblocks: change some members of badblocks to bool
  block/badblocks: only set bb->changed/unacked_exist when badblocks
    changes
  block/badblocks: fix badblocks loss when badblocks combine
  block/badblocks: fix the bug of reverse order

 block/badblocks.c         | 38 ++++++++++++++++++++++----------------
 include/linux/badblocks.h | 10 +++++-----
 2 files changed, 27 insertions(+), 21 deletions(-)

Comments

Ashok Raj June 21, 2023, 1:32 p.m. UTC | #1
On Thu, Jun 22, 2023 at 01:20:48AM +0800, linan666@huaweicloud.com wrote:
> From: Li Nan <linan122@huawei.com>
> 
> This patch series fixes some simple bugs of setting badblocks and
> optimizing struct badblocks. Coly Li has been trying to refactor badblocks
> in patch series "badblocks improvement for multiple bad block ranges", but
> the workload is significant. Before that, I will fix some easily triggered
  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^

You mean the refactor is going to take longer to complete? 
If so, maybe state it that way...
Li Nan June 25, 2023, 8:13 a.m. UTC | #2
在 2023/6/21 21:32, Ashok Raj 写道:
> On Thu, Jun 22, 2023 at 01:20:48AM +0800, linan666@huaweicloud.com wrote:
>> From: Li Nan <linan122@huawei.com>
>>
>> This patch series fixes some simple bugs of setting badblocks and
>> optimizing struct badblocks. Coly Li has been trying to refactor badblocks
>> in patch series "badblocks improvement for multiple bad block ranges", but
>> the workload is significant. Before that, I will fix some easily triggered
>    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> 
> You mean the refactor is going to take longer to complete?

Yes, refer to the link:
https://lore.kernel.org/all/20220721121152.4180-1-colyli@suse.de

> If so, maybe state it that way...
> 
> .