mbox series

[blktests,0/6] fix failures with bio based device-mapper

Message ID 20230719071510.530623-1-shinichiro.kawasaki@wdc.com (mailing list archive)
Headers show
Series fix failures with bio based device-mapper | expand

Message

Shinichiro Kawasaki July 19, 2023, 7:15 a.m. UTC 
When bio based device-mappers are set to TEST_DEVS, the test cases block/004,
block/005, zbd/005 and zbd/006 fail (or silently skipped) on kernel version
v6.5-rcX. This happens because the kernel no longer provides the sysfs
attribute queue/scheduler for bio based block devices, and the test cases sets
scheduler through the sysfs attribute and fail.

This series address the failures. The first two patches are preparations. Next
two patches introduce new helper functions: one to set scheduler to destination
devices of bio based device-mapper. The other to check queue/scheduler attribute
existence. The last two patches fix the test cases by calling the new helper
functions.

Shin'ichiro Kawasaki (6):
  check, common/rc: save sysfs attribute path
  common/dm: add script file for device-mapper functions
  common/{rc,dm}: introduce functions to set scheduler of dm
    destinations
  common/rc: introduce _require_test_dev_sysfs
  block/004, zbd/{005,006}: call _test_dev_set_scheduler
  block/005: require queue/scheduler sysfs attribute

 check           | 10 +++++-----
 common/dm       | 44 ++++++++++++++++++++++++++++++++++++++++++++
 common/rc       | 29 ++++++++++++++++++++++++-----
 tests/block/004 |  2 +-
 tests/block/005 |  4 ++++
 tests/zbd/005   |  2 +-
 tests/zbd/006   |  2 +-
 tests/zbd/rc    | 19 +------------------
 8 files changed, 81 insertions(+), 31 deletions(-)
 create mode 100644 common/dm

Comments

Shinichiro Kawasaki July 27, 2023, 1:40 a.m. UTC | #1 
On Jul 19, 2023 / 16:15, Shin'ichiro Kawasaki wrote:
> When bio based device-mappers are set to TEST_DEVS, the test cases block/004,
> block/005, zbd/005 and zbd/006 fail (or silently skipped) on kernel version
> v6.5-rcX. This happens because the kernel no longer provides the sysfs
> attribute queue/scheduler for bio based block devices, and the test cases sets
> scheduler through the sysfs attribute and fail.
> 
> This series address the failures. The first two patches are preparations. Next
> two patches introduce new helper functions: one to set scheduler to destination
> devices of bio based device-mapper. The other to check queue/scheduler attribute
> existence. The last two patches fix the test cases by calling the new helper
> functions.

FYI, I've applied the patches.