mbox series

[blktests,0/2] nvme: Allow for pre-defined UUID and subsystem NQN

Message ID 20231108064753.1932632-1-shinichiro.kawasaki@wdc.com (mailing list archive)
Headers show
Series nvme: Allow for pre-defined UUID and subsystem NQN | expand

Message

Shinichiro Kawasaki Nov. 8, 2023, 6:47 a.m. UTC 
In the discussion to run nvme test group with real RDMA hardware, Hannes pointed
out that pre-defined UUID and subsystem NQN will be obstacles. To address them,
he created two patches in a PR [1]. I post the patches here for review by linux-
nvme and linux-block members.

[1] https://github.com/osandov/blktests/pull/127

Hannes Reinecke (2):
  nvme: do not print UUID to log files
  nvme: do not print subsystem NQN to stdout

 tests/nvme/003.out |  1 -
 tests/nvme/004     |  3 +--
 tests/nvme/004.out |  3 ---
 tests/nvme/008     |  3 +--
 tests/nvme/008.out |  3 ---
 tests/nvme/009     |  3 +--
 tests/nvme/009.out |  3 ---
 tests/nvme/010     |  3 +--
 tests/nvme/010.out |  3 ---
 tests/nvme/011     |  3 +--
 tests/nvme/011.out |  3 ---
 tests/nvme/012     |  3 +--
 tests/nvme/012.out |  3 ---
 tests/nvme/013     |  3 +--
 tests/nvme/013.out |  3 ---
 tests/nvme/014     |  3 +--
 tests/nvme/014.out |  3 ---
 tests/nvme/015     |  3 +--
 tests/nvme/015.out |  3 ---
 tests/nvme/018     |  3 +--
 tests/nvme/018.out |  3 ---
 tests/nvme/019     |  3 +--
 tests/nvme/019.out |  3 ---
 tests/nvme/020     |  3 +--
 tests/nvme/020.out |  3 ---
 tests/nvme/021     |  5 ++---
 tests/nvme/021.out |  2 --
 tests/nvme/022     |  5 ++---
 tests/nvme/022.out |  2 --
 tests/nvme/023     |  5 ++---
 tests/nvme/023.out |  2 --
 tests/nvme/024     |  5 ++---
 tests/nvme/024.out |  2 --
 tests/nvme/025     |  5 ++---
 tests/nvme/025.out |  2 --
 tests/nvme/026     |  5 ++---
 tests/nvme/026.out |  2 --
 tests/nvme/027     |  5 ++---
 tests/nvme/027.out |  2 --
 tests/nvme/028     |  5 ++---
 tests/nvme/028.out |  2 --
 tests/nvme/029     |  5 ++---
 tests/nvme/029.out |  2 --
 tests/nvme/031     |  2 +-
 tests/nvme/033.out |  1 -
 tests/nvme/034.out |  1 -
 tests/nvme/035.out |  1 -
 tests/nvme/036.out |  1 -
 tests/nvme/037     |  2 +-
 tests/nvme/041.out |  2 --
 tests/nvme/042.out |  7 -------
 tests/nvme/043.out |  8 --------
 tests/nvme/044.out |  4 ----
 tests/nvme/045.out |  1 -
 tests/nvme/047     |  4 ++--
 tests/nvme/048.out |  1 -
 tests/nvme/rc      | 26 +++++++++++++++++++++++++-
 57 files changed, 59 insertions(+), 138 deletions(-)

Comments

Daniel Wagner Nov. 13, 2023, 4:20 p.m. UTC | #1 
On Wed, Nov 08, 2023 at 03:47:51PM +0900, Shin'ichiro Kawasaki wrote:
> In the discussion to run nvme test group with real RDMA hardware, Hannes pointed
> out that pre-defined UUID and subsystem NQN will be obstacles. To address them,
> he created two patches in a PR [1]. I post the patches here for review by linux-
> nvme and linux-block members.
> 
> [1] https://github.com/osandov/blktests/pull/127
> 
> Hannes Reinecke (2):
>   nvme: do not print UUID to log files
>   nvme: do not print subsystem NQN to stdout

Looks good to me.

Reviewed-by: Daniel Wagner <dwagner@suse.de>