| Message ID | 20240617-md-m68k-drivers-block-v1-0-b200599a315e@quicinc.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | block: m68k: add missing MODULE_DESCRIPTION() macros | expand |
On 6/17/24 18:13, Jeff Johnson wrote: > With ARCH=m68k, make allmodconfig && make W=1 C=1 reports: > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/block/amiflop.o > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/block/ataflop.o > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/block/z2ram.o > > Since these have traditionally had different commit prefixes, I > submitted individual patches. Let me know if you want me to squash > them. > > In addition, drivers/block/swim3.c is also missing a > MODULE_DESCRIPTION(), but I haven't yet actually triggered the > warning. I need to customize a PPC configuration which enables > MAC_FLOPPY in order to trigger the warning and verify the fix. > > I'll get around to that when I finish the remaining m68k issues. > > --- > Jeff Johnson (3): > amiflop: add missing MODULE_DESCRIPTION() macro > ataflop: add missing MODULE_DESCRIPTION() macro > z2ram: add missing MODULE_DESCRIPTION() macro > > drivers/block/amiflop.c | 1 + > drivers/block/ataflop.c | 1 + > drivers/block/z2ram.c | 1 + > 3 files changed, 3 insertions(+) > --- > base-commit: 6ba59ff4227927d3a8530fc2973b80e94b54d58f > change-id: 20240617-md-m68k-drivers-block-46c301b46f49 > > For the series, looks good ... Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com> -ck
On Mon, 17 Jun 2024 18:13:31 -0700, Jeff Johnson wrote: > With ARCH=m68k, make allmodconfig && make W=1 C=1 reports: > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/block/amiflop.o > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/block/ataflop.o > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/block/z2ram.o > > Since these have traditionally had different commit prefixes, I > submitted individual patches. Let me know if you want me to squash > them. > > [...] Applied, thanks! [1/3] amiflop: add missing MODULE_DESCRIPTION() macro commit: 28d8c13830cc530996157e22ecf22def90cb7f35 [2/3] ataflop: add missing MODULE_DESCRIPTION() macro commit: ba8df22e25e7e906254f4f490d7bcfbe637152aa [3/3] z2ram: add missing MODULE_DESCRIPTION() macro commit: 465478bb00168a7620788990b1679c5067d421f2 Best regards,
With ARCH=m68k, make allmodconfig && make W=1 C=1 reports: WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/block/amiflop.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/block/ataflop.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/block/z2ram.o Since these have traditionally had different commit prefixes, I submitted individual patches. Let me know if you want me to squash them. In addition, drivers/block/swim3.c is also missing a MODULE_DESCRIPTION(), but I haven't yet actually triggered the warning. I need to customize a PPC configuration which enables MAC_FLOPPY in order to trigger the warning and verify the fix. I'll get around to that when I finish the remaining m68k issues. --- Jeff Johnson (3): amiflop: add missing MODULE_DESCRIPTION() macro ataflop: add missing MODULE_DESCRIPTION() macro z2ram: add missing MODULE_DESCRIPTION() macro drivers/block/amiflop.c | 1 + drivers/block/ataflop.c | 1 + drivers/block/z2ram.c | 1 + 3 files changed, 3 insertions(+) --- base-commit: 6ba59ff4227927d3a8530fc2973b80e94b54d58f change-id: 20240617-md-m68k-drivers-block-46c301b46f49