From patchwork Wed Oct 16 09:49:03 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Philipp Stanner X-Patchwork-Id: 13838051 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E4469204F94 for ; Wed, 16 Oct 2024 09:49:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729072163; cv=none; b=t7BLo/EFo/kMOD9R0C36tFOhJyTlzoYbtDaotlexfEuIVO5hLKK0PlV/NC2oi17FqqnlSf/nJl0u4A/DvhhCHW8YLVLsyKOjKAcxWYrnyv8f9NwxRe8eIBsuAsuQG5CPS9z/b/w59nDmdswoDJIfiIlhVUpfnVpXjuBmlAdPTns= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729072163; c=relaxed/simple; bh=qU40uDWAXxj3oH037Z58Iia9dcS55Em7zzZb741ZWMg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=QPJi5+wCbGkRI9/8GhQvp/rtADlhPC38U8wavz+CjqevjyrRdfE0c+j94rlmW1Dh4hSw2uPQTwXgyO6kEyWfEkRQBW5pU7D772luMqCaJwCAsnNtm4OBzOQF+3gEiD92kZnZjR+y3tBVdF8LVpE0KWRtJ1lfCuHZxRqDbD2jH1c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Thz9a3qJ; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Thz9a3qJ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1729072160; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=8WNVMc8LDTYNGH+SAKpTHVIymq5YjMjs8ZEPHmIVyE0=; b=Thz9a3qJmmKxZdOFlX2Ro+W/J2m6YiRClxpf4d5u6mMOpswWVJaF4h2yBkHusteRdAqTSm fvzzpwj1ZRn8bj08T2Tu723IlgoGUaGnfGyg8aHP3N6ZgwN6B4Jc74WuwTpnbT89qThROn vpTr8jsjidzUX1401jt5o2Up69WGzMY= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-459-9zI_MgFzNDCOXLQgj8bB5Q-1; Wed, 16 Oct 2024 05:49:19 -0400 X-MC-Unique: 9zI_MgFzNDCOXLQgj8bB5Q-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4311407ae76so34363305e9.3 for ; Wed, 16 Oct 2024 02:49:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729072158; x=1729676958; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8WNVMc8LDTYNGH+SAKpTHVIymq5YjMjs8ZEPHmIVyE0=; b=QuITb8vFWf0DKdal+XJDAyJe29wNF7NNntq3OvLuYvRFacgRWlLZG4Hpa2FMjVMShq i9s4WRkosHuvkBZcQBXhwYfoDmf3eg/aN2E0vbM+aXANLOVQYQDxTesrMwCtUK8F02ka 9uT0IGLZMc0+AxPs0rWJaXLp/1ghvCwaDbKc/5MR6JGdwpqEOBguXIUlq66qkrPpuflZ 9L8e3FWP9Hz4CJtOZFMayr5pa3yUI+Ni3HcGw/jmqrqz+qdXIBIkaY6f1lzsVhe6OPZZ xapfJ7rH2PmxJrzSI1jIQLDH5a1TtattFrXEPrfMaf5fP+ZIXknymDhewe5tmYuP/7Bt QuWw== X-Gm-Message-State: AOJu0YyyEvma56NnoiljNrhHTZziyvkJfchoZVZPhpuuv+d5476i5YUi QSkBYAUvTpLASLroNpkUzX5tiHqnEsMG0d1nCpGAsyLpzsLJMU4TjeLkQ94b+FXbWFaL4hoOMSj Fn0H/Kew+WW2gZGYJYDbh/DDNkG7QjAcDJw6c641kOzdpCht8MlLbexVt2Uc2 X-Received: by 2002:a05:600c:4688:b0:42f:80f4:ab31 with SMTP id 5b1f17b1804b1-4314a2ff46amr26025685e9.18.1729072158273; Wed, 16 Oct 2024 02:49:18 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHKUDE9oBG3DV9ivNP2q5cTc+CFmH4d6PSgSwWQMyk1ILj67QUdUX0ghs5JR6pQgtk/njtCOw== X-Received: by 2002:a05:600c:4688:b0:42f:80f4:ab31 with SMTP id 5b1f17b1804b1-4314a2ff46amr26025305e9.18.1729072157791; Wed, 16 Oct 2024 02:49:17 -0700 (PDT) Received: from eisenberg.muc.redhat.com (nat-pool-muc-t.redhat.com. [149.14.88.26]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4314b32e487sm28190235e9.25.2024.10.16.02.49.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Oct 2024 02:49:17 -0700 (PDT) From: Philipp Stanner To: Jens Axboe , Wu Hao , Tom Rix , Moritz Fischer , Xu Yilun , Andy Shevchenko , Linus Walleij , Bartosz Golaszewski , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Bjorn Helgaas , Richard Cochran , Damien Le Moal , Hannes Reinecke , Philipp Stanner , Chaitanya Kulkarni , Al Viro , Li Zetao Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fpga@vger.kernel.org, linux-gpio@vger.kernel.org, netdev@vger.kernel.org, linux-pci@vger.kernel.org Subject: [PATCH v8 0/6] PCI: Remove most pcim_iounmap_regions() users Date: Wed, 16 Oct 2024 11:49:03 +0200 Message-ID: <20241016094911.24818-2-pstanner@redhat.com> X-Mailer: git-send-email 2.47.0 Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Merge plan for this is the PCI-Tree. After this series, only two users (net/ethernet/stmicro and vdpa/solidrun) will remain to be ported in the subsequent merge window. Doing them right now proved very difficult because of various conflicts as they are currently also being reworked. Changes in v8: - Patch "gpio: ..": Fix a bug: don't print the wrong error code. (Simon) - Split patch 1 into two patches to make adding of the new public API obvious (Bartosz) - Patch "ethernet: cavium: ...": Remove outdated sentences from the commit message. Changes in v7: - Add Paolo's Acked-by. - Rebase on current master; drop patch No.1 which made pcim_request_region() public. Changes in v6: - Remove the patches for "vdpa: solidrun" since the maintainer seems unwilling to review and discuss, not to mention approve, anything that is part of a wider patch series across other subsystems. - Change series's name to highlight that not all callers are removed by it. Changes in v5: - Patch "ethernet: cavium": Re-add accidentally removed pcim_iounmap_region(). (Me) - Add Jens's Reviewed-by to patch "block: mtip32xx". (Jens) Changes in v4: - Drop the "ethernet: stmicro: [...] patch since it doesn't apply to net-next, and making it apply to that prevents it from being applyable to PCI ._. (Serge, me) - Instead, deprecate pcim_iounmap_regions() and keep "ethernet: stimicro" as the last user for now. - ethernet: cavium: Use PTR_ERR_OR_ZERO(). (Andy) - vdpa: solidrun (Bugfix) Correct wrong printf string (was "psnet" instead of "snet"). (Christophe) - vdpa: solidrun (Bugfix): Add missing blank line. (Andy) - vdpa: solidrun (Portation): Use PTR_ERR_OR_ZERO(). (Andy) - Apply Reviewed-by's from Andy and Xu Yilun. Changes in v3: - fpga/dfl-pci.c: remove now surplus wrapper around pcim_iomap_region(). (Andy) - block: mtip32xx: remove now surplus label. (Andy) - vdpa: solidrun: Bugfix: Include forgotten place where stack UB occurs. (Andy, Christophe) - Some minor wording improvements in commit messages. (Me) Changes in v2: - Add a fix for the UB stack usage bug in vdap/solidrun. Separate patch, put stable kernel on CC. (Christophe, Andy). - Drop unnecessary pcim_release_region() in mtip32xx (Andy) - Consequently, drop patch "PCI: Make pcim_release_region() a public function", since there's no user anymore. (obsoletes the squash requested by Damien). - vdap/solidrun: • make 'i' an 'unsigned short' (Andy, me) • Use 'continue' to simplify loop (Andy) • Remove leftover blank line - Apply given Reviewed- / acked-bys (Andy, Damien, Bartosz) Important things first: This series is based on [1] and [2] which Bjorn Helgaas has currently queued for v6.12 in the PCI tree. This series shall remove pcim_iounmap_regions() in order to make way to remove its brother, pcim_iomap_regions(). Regards, P. [1] https://lore.kernel.org/all/20240729093625.17561-4-pstanner@redhat.com/ [2] https://lore.kernel.org/all/20240807083018.8734-2-pstanner@redhat.com/ Philipp Stanner (6): PCI: Make pcim_iounmap_region() a public function PCI: Deprecate pcim_iounmap_regions() fpga/dfl-pci.c: Replace deprecated PCI functions block: mtip32xx: Replace deprecated PCI functions gpio: Replace deprecated PCI functions ethernet: cavium: Replace deprecated PCI functions drivers/block/mtip32xx/mtip32xx.c | 18 ++++++++---------- drivers/fpga/dfl-pci.c | 16 ++++------------ drivers/gpio/gpio-merrifield.c | 15 ++++++++------- .../net/ethernet/cavium/common/cavium_ptp.c | 7 +++---- drivers/pci/devres.c | 8 ++++++-- include/linux/pci.h | 1 + 6 files changed, 30 insertions(+), 35 deletions(-)