[V2,0/4] block: freeze/unfreeze lockdep fixes

Message

Ming Lei Oct. 31, 2024, 1:37 p.m. UTC

Hello,

The 1st patch removes blk_freeze_queue().

The 2nd patch fixes freeze uses in rbd.

The 3rd patches fixes potential unfreeze lock verification on non-owner
context.

The 4th patch doesn't verify io lock in elevator_init_mq() for fixing
false lockdep warning.

V2:
	- drop patch 1 and fix rbd by adding unfreeze (Christoph)
	- add reviewed-by


Ming Lei (4):
  block: remove blk_freeze_queue()
  rbd: unfreeze queue after marking disk as dead
  block: always verify unfreeze lock on the owner task
  block: don't verify IO lock for freeze/unfreeze in elevator_init_mq()

 block/blk-core.c       |  2 +-
 block/blk-mq.c         | 84 +++++++++++++++++++++++++++---------------
 block/blk.h            |  4 +-
 block/elevator.c       | 10 ++++-
 drivers/block/rbd.c    |  1 +
 include/linux/blkdev.h |  4 ++
 6 files changed, 71 insertions(+), 34 deletions(-)

Comments

Ming Lei Nov. 6, 2024, 12:24 a.m. UTC | #1

On Thu, Oct 31, 2024 at 09:37:16PM +0800, Ming Lei wrote:
> Hello,
> 
> The 1st patch removes blk_freeze_queue().
> 
> The 2nd patch fixes freeze uses in rbd.
> 
> The 3rd patches fixes potential unfreeze lock verification on non-owner
> context.
> 
> The 4th patch doesn't verify io lock in elevator_init_mq() for fixing
> false lockdep warning.
> 
> V2:
> 	- drop patch 1 and fix rbd by adding unfreeze (Christoph)
> 	- add reviewed-by

Hi Jens,

This patchset fixes several lockdep false positive warnings, can you
merge them if you are fine?

https://lore.kernel.org/linux-block/Zym_h_EYRVX18dSw@fedora/



thanks,
Ming

Ming Lei Nov. 7, 2024, 11:21 p.m. UTC | #2

On Wed, Nov 6, 2024 at 8:24 AM Ming Lei <[e-mail]> wrote:
>
> On Thu, Oct 31, 2024 at 09:37:16PM +0800, Ming Lei wrote:
> > Hello,
> >
> > The 1st patch removes blk_freeze_queue().
> >
> > The 2nd patch fixes freeze uses in rbd.
> >
> > The 3rd patches fixes potential unfreeze lock verification on non-owner
> > context.
> >
> > The 4th patch doesn't verify io lock in elevator_init_mq() for fixing
> > false lockdep warning.
> >
> > V2:
> >       - drop patch 1 and fix rbd by adding unfreeze (Christoph)
> >       - add reviewed-by
>
> Hi Jens,
>
> This patchset fixes several lockdep false positive warnings, can you
> merge them if you are fine?
>
> https://lore.kernel.org/linux-block/Zym_h_EYRVX18dSw@fedora/

Hi Jens,

There are lots of lockdep reports which need the fixes, so ping...

Thanks,

Jens Axboe Nov. 7, 2024, 11:27 p.m. UTC | #3

On 11/7/24 4:21 PM, Ming Lei wrote:
> On Wed, Nov 6, 2024 at 8:24?AM Ming Lei <[e-mail]> wrote:
>>
>> On Thu, Oct 31, 2024 at 09:37:16PM +0800, Ming Lei wrote:
>>> Hello,
>>>
>>> The 1st patch removes blk_freeze_queue().
>>>
>>> The 2nd patch fixes freeze uses in rbd.
>>>
>>> The 3rd patches fixes potential unfreeze lock verification on non-owner
>>> context.
>>>
>>> The 4th patch doesn't verify io lock in elevator_init_mq() for fixing
>>> false lockdep warning.
>>>
>>> V2:
>>>       - drop patch 1 and fix rbd by adding unfreeze (Christoph)
>>>       - add reviewed-by
>>
>> Hi Jens,
>>
>> This patchset fixes several lockdep false positive warnings, can you
>> merge them if you are fine?
>>
>> https://lore.kernel.org/linux-block/Zym_h_EYRVX18dSw@fedora/
> 
> Hi Jens,
> 
> There are lots of lockdep reports which need the fixes, so ping...

Oops indeed, not sure why I missed this one.

Jens Axboe Nov. 7, 2024, 11:27 p.m. UTC | #4

On Thu, 31 Oct 2024 21:37:16 +0800, Ming Lei wrote:
> The 1st patch removes blk_freeze_queue().
> 
> The 2nd patch fixes freeze uses in rbd.
> 
> The 3rd patches fixes potential unfreeze lock verification on non-owner
> context.
> 
> [...]

Applied, thanks!

[1/4] block: remove blk_freeze_queue()
      commit: 54027869df83aceccd18c4a799b263a2b318b065
[2/4] rbd: unfreeze queue after marking disk as dead
      commit: a471977780cc8ba809f84e3e2289d676063e7547
[3/4] block: always verify unfreeze lock on the owner task
      commit: 6a78699838a0ddeed3620ddf50c1521f1fe1e811
[4/4] block: don't verify IO lock for freeze/unfreeze in elevator_init_mq()
      commit: 357e1b7f730bd85a383e7afa75a3caba329c5707

Best regards,