From patchwork Tue Mar 11 12:36:17 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Michal_Koutn=C3=BD?= X-Patchwork-Id: 14011765 Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE3F05A4D5 for ; Tue, 11 Mar 2025 12:36:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.68 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741696616; cv=none; b=iadW13QUSKdhw7DbQi1im6cxqjE330U1GhAeOc8SsduKLQ2+QTyJsEuoV8w7m6bZPdYCbWPUhyew98pVr4fcywb5wC9wLGYiJN8VxFI3CcufKGxBby6tvatx8ylp3eKMh/uMS5X4/rC/lozDO+tvOIFe7SIttr35nf8yyNGHIYU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741696616; c=relaxed/simple; bh=CePJDN6866RNu5OilP7NSNORan/RA/RBfUihDSOHno8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=lqogzGZIeGlnhojDau13kHmsHndqaUZEDjZt6WJDg4+AAKdYDKuoZ8xOlh+4pnGZvoKY+iZxJQL0TC81jErW7is3M2U+4kTB/La4UOGhOATEyto6xqLXbh1oiyQBG0yPAdADjvflSQGcAe/e5+ZTyuXsWicpyhm5xFopPWkgZMw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=CGF+l0I5; arc=none smtp.client-ip=209.85.221.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="CGF+l0I5" Received: by mail-wr1-f68.google.com with SMTP id ffacd0b85a97d-3914a5def6bso1317293f8f.1 for ; Tue, 11 Mar 2025 05:36:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1741696613; x=1742301413; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=7qYs9YHqi3o8BYflhXgM2/h7DX07No2svICRJmWY6FQ=; b=CGF+l0I5Wsrch1iKaNhFNsc5fv4W/qTGaw/bNGmoseaXUOT+2ET757nQPK4LILnZQe NzPbI/T0cinS74vqEzOL4MjQI5edjxOoHs1Gns4eXwRbrRZnrQZTxpMS/viv6FBf86nT 7yDM7hJFIPQP6hEIZlkEmyC8Qdw9ZylQpbjyWPqHgaPvVorEwplGVoiN2LAyRacz9MRT LQoyOY36HWdHQcCf3d3aSANd16Tr568SPBQndn3TWNr3yMoaAgtABiIIJHQ+itfHox6K hFX4lEOZt7+r+bFRpXkH4f2mx4imRji0yfcNNoTdiw9zoxVzuJX4yoPUzIqTAWs/C2YF cWIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741696613; x=1742301413; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7qYs9YHqi3o8BYflhXgM2/h7DX07No2svICRJmWY6FQ=; b=stHhelJlAoGQr9ugoalhVqMO4eVCMmgSEiniVwB2gd+s2BQixA349dtP5TbmNyOi8C rwv3goczsrPmalG+FYK5/trWZbGub8jPhFO28NsH6pd6GDIJJnci3sKVZwc4pbLIchJi 5V0d+MEq/7qp1wKsyvwAQPWygqnWItaSaUuz+0jH6RguSvMSa53z22KIqtCWW8ScQB64 1t8pQBfeUAjGhnGrWUr4zAg27ZaFcjgx/3uM9Eo8n8boBy5xj7Bas5msdlMAlQE7GZ+C WJnt6qyyRd3EmJ0zKpPrsR1EsZO61RgRYD1zjHzBHSpHWaivi0lsYTgdHd9DZaAjpd+w K3gQ== X-Forwarded-Encrypted: i=1; AJvYcCUoS4Y6VEUTpjvmuuT5zmssMQm0ySc++srk5Ef356L0rddMrVCuu/7eliRvo/Xk6OIG4oJFxJDvSf53JQ==@vger.kernel.org X-Gm-Message-State: AOJu0YySlSOMUJ1PBVjKlrZLBnD0+VWac5Bp4AVMmIog1IoPGCWwFw2M gZZnbGKkFy/ymDoNmzdbbkklU3g2wGYMC4KOGefQM0IW6F2mL7WUFSESbH+Vlko= X-Gm-Gg: ASbGncu/jEg8it58cDK3kD6fKKRplLji2RhXxTd7jcc7s+35z8+QkZ7RiUfxDDVtiDC 96ijEX/0FjkqbfwCQ3n7gSesdzZoxaRv/4hDrNvIsGG0uEPazSSy2ypKx2BDlg5TYRHPvDQ91RP YXWy10/Uh6ySOSQSPU1u0KO/uf9QqBP26zeuzFKYnHu+vIao1RwvXtmPQ3Y2UJmZWwH93GNbdUR SwiX84H6Hp0BLBfvVJMs+/z664tgK9uaBGPQIwGEm1jWUL2YRxQQ5MMSka1Jp2fT1Xc9UXbiMtP 1lNGeXywMLpDPSRSKgICu4+ghjdlYv6OAL5ddCtdunhfDrG64koHJF0rHg== X-Google-Smtp-Source: AGHT+IEBZYqz4EXYjBrQl7MEBAEBtNENBPTwZcu8eE/AXSvpLAC27EkQUSrI1TFPSdtbH6FbRzmNrg== X-Received: by 2002:adf:b312:0:b0:390:f6cd:c89f with SMTP id ffacd0b85a97d-39132db6f86mr10434242f8f.53.1741696613012; Tue, 11 Mar 2025 05:36:53 -0700 (PDT) Received: from blackdock.suse.cz ([193.86.92.181]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43d04004240sm9742265e9.3.2025.03.11.05.36.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Mar 2025 05:36:52 -0700 (PDT) From: =?utf-8?q?Michal_Koutn=C3=BD?= To: cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org Cc: =?utf-8?q?Michal_Koutn=C3=BD?= , Josef Bacik , Waiman Long , Jonathan Corbet , Andrew Morton , Shakeel Butt , Roman Gushchin , Johannes Weiner , Tejun Heo , Muchun Song , Michal Hocko , Jens Axboe Subject: [PATCH v2 00/11] cgroup v1 deprecation messages Date: Tue, 11 Mar 2025 13:36:17 +0100 Message-ID: <20250311123640.530377-1-mkoutny@suse.com> X-Mailer: git-send-email 2.48.1 Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Memory controller had begun to print warning messages when using some attributes that do no have a counterpart in its cgroup v2 implementation. This is informative to users who run (unwittingly) on v1 or to distros that run v1 (they can learn about such users or prepare for disabling v1 configs). I consider the deprecated files in three categories: - RE) replacement exists, - DN) dropped as non-ideal concept (e.g. non-hierarchical resources), - NE) not evaluated (yet). For RE, I added the replacement into the warning message, DN have only a plain deprecation message and I marked the commits with NE as RFC. Also I'd be happy if you would point out some forgotten knobs that'd deserve similar warnings. The level of messages is info to avoid too much noise (may be increased in future when there are fewer users). Some knobs from DN have warn level. The net_cls and net_prio controllers that only exist on v1 hierarchies have no straightforward action for users (replacement would rely on net NS or eBPF), so messages for their usage are omitted, although it'd be good to eventually retire that code in favor of aforementioned. At the end are some cleanup patches I encountered en route. Changes from v1 (https://lore.kernel.org/r/20250304153801.597907-1-mkoutny@suse.com/) - cpuset load_balance/pressure warn wording (Waiman) - comment typo (Waiman) - collect Acks - drop bouncing Cc: and respective RFC (self) - change level warn -> info, except for spread slab (Tejun) - add memory.swappiness (self) - add legacy freezer message (self) - update cover wrt net* controllers (self) Michal Koutný (11): cgroup/cpuset-v1: Add deprecation messages to sched_load_balance and memory_pressure_enabled cgroup/cpuset-v1: Add deprecation messages to memory_spread_page and memory_spread_slab cgroup/blkio: Add deprecation messages to reset_stats cgroup: Print message when /proc/cgroups is read on v2-only system cgroup/cpuset-v1: Add deprecation messages to mem_exclusive and mem_hardwall cgroup/cpuset-v1: Add deprecation messages to memory_migrate RFC cgroup/cpuset-v1: Add deprecation messages to sched_relax_domain_level mm: Add transformation message for per-memcg swappiness cgroup: Add deprecation message to legacy freezer controller cgroup: Update file naming comment blk-cgroup: Simplify policy files registration .../cgroup-v1/freezer-subsystem.rst | 4 ++++ .../admin-guide/cgroup-v1/memory.rst | 1 + block/blk-cgroup.c | 8 +++++-- block/blk-ioprio.c | 23 ++++++------------- include/linux/cgroup-defs.h | 5 ++-- include/linux/cgroup.h | 1 + kernel/cgroup/cgroup-internal.h | 1 + kernel/cgroup/cgroup-v1.c | 7 ++++++ kernel/cgroup/cgroup.c | 4 ++-- kernel/cgroup/cpuset-v1.c | 8 +++++++ kernel/cgroup/legacy_freezer.c | 6 +++-- mm/memcontrol-v1.c | 6 +++-- 12 files changed, 47 insertions(+), 27 deletions(-) base-commit: 80e54e84911a923c40d7bee33a34c1b4be148d7a Acked-by: Jens Axboe