mbox series

[RESEND,v2,0/2] Fix misuse of blk_rq_stats in blk-iolatency

Message ID cover.1567780718.git.asml.silence@gmail.com (mailing list archive)
Headers show
Series Fix misuse of blk_rq_stats in blk-iolatency | expand

Message

Pavel Begunkov Sept. 6, 2019, 2:42 p.m. UTC 
From: Pavel Begunkov <asml.silence@gmail.com>

There are implicit assumptions about struct blk_rq_stats, which make
it's very easy to misuse. The first patch fixes a bug caused by that.
The second employs type-system to prevent recurrences.

v2: rebase + reformulate commit messages (no code changes)

Acked-by: Josef Bacik <josef@toxicpanda.com>

Pavel Begunkov (2):
  blk-iolatency: Fix zero mean in previous stats
  blk-stats: Introduce explicit stat staging buffers

 block/blk-iolatency.c     | 60 ++++++++++++++++++++++++++++++---------
 block/blk-stat.c          | 48 +++++++++++++++++++++++--------
 block/blk-stat.h          |  9 ++++--
 include/linux/blk_types.h |  6 ++++
 4 files changed, 94 insertions(+), 29 deletions(-)

Comments

Pavel Begunkov Sept. 6, 2019, 3 p.m. UTC | #1 
Jens, could you please at last take a look?

The patches have been stalling here for almost 2 months
(see
https://lkml.kernel.org/lkml/ac0700a1-0984-417b-d5d8-35c4ba56f6f6@gmail.com/T/)

Thanks

On 06/09/2019 17:42, Pavel Begunkov (Silence) wrote:
> From: Pavel Begunkov <asml.silence@gmail.com>
> 
> There are implicit assumptions about struct blk_rq_stats, which make
> it's very easy to misuse. The first patch fixes a bug caused by that.
> The second employs type-system to prevent recurrences.
> 
> v2: rebase + reformulate commit messages (no code changes)
> 
> Acked-by: Josef Bacik <josef@toxicpanda.com>
> 
> Pavel Begunkov (2):
>   blk-iolatency: Fix zero mean in previous stats
>   blk-stats: Introduce explicit stat staging buffers
> 
>  block/blk-iolatency.c     | 60 ++++++++++++++++++++++++++++++---------
>  block/blk-stat.c          | 48 +++++++++++++++++++++++--------
>  block/blk-stat.h          |  9 ++++--
>  include/linux/blk_types.h |  6 ++++
>  4 files changed, 94 insertions(+), 29 deletions(-)
>