From patchwork Tue Jan 16 21:10:04 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 10168105 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 62112600CA for ; Tue, 16 Jan 2018 21:10:12 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4938D27FB3 for ; Tue, 16 Jan 2018 21:10:12 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3C4C426E51; Tue, 16 Jan 2018 21:10:12 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4D74E27165 for ; Tue, 16 Jan 2018 21:10:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750823AbeAPVKJ (ORCPT ); Tue, 16 Jan 2018 16:10:09 -0500 Received: from mout.web.de ([212.227.17.12]:64039 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750796AbeAPVKI (ORCPT ); Tue, 16 Jan 2018 16:10:08 -0500 Received: from [192.168.1.3] ([92.228.15.72]) by smtp.web.de (mrweb102 [213.165.67.124]) with ESMTPSA (Nemesis) id 0MIeUW-1eZLZF320O-002GKh; Tue, 16 Jan 2018 22:10:05 +0100 To: linux-block@vger.kernel.org, Matias Bjorling Cc: LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Subject: [PATCH] lightnvm/pblk-gc: Delete an error message for a failed memory allocation in pblk_gc_line_prepare_ws() Message-ID: <0ef6e852-9c76-ce74-6f21-c0398722c9e5@users.sourceforge.net> Date: Tue, 16 Jan 2018 22:10:04 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 Content-Language: en-GB X-Provags-ID: V03:K0:uDPrfWRBlpRs5L6+At2tlpylggWREpf9OGvZEgLVna7j7AqNwaJ vYhcwiw/pSBjBfJtGIKJZNypEsNmBjaC5FXeoYPfZuUCIP7hBT+Q0vvCqAcPW7+BNx02DOJ TA/pB/Of2he3NsLnXxR/ZPndkxR8oirn9l1hbzAZEyp9imv2kt9hrPnoLszLoXUPTPQsLLz YxmrS6sgQ98deiGcn+4Iw== X-UI-Out-Filterresults: notjunk:1; V01:K0:FPiI/blKHv4=:ROs0u5jQOCnCKVXOBK/wqZ msz3/XsdA5GTlI6evIRfbwzEotrRDGSIQAszax3K9hE2x6B+L3TuRKpG5UAyFiRh7jYoq+A0P FWYn05XcIdrW/1RyPy4fjZtZzzhd5Z9NE0znH3BVZx7LIBlhaD1nBMGXCD2x30d6SvA73CYAK tvD4lPMijab+fJ3Dk2jvgSsyoctAKgYJPVSMyXQVfQ/v4OHSYUtSagsSpsJhI3B+W+7AgnPEl jAUfsUKbp93UEP8dUS5r8Nk2gV4SPHz7FDZ58uTBe3qeAWIQ00NI0UwGk4XmlkMJDjeFQBTot wY4Gzy1uJfCGZMwNmVGLdO/B4jRLqdcP+wOIgQqlTqq1MJBuUCMHHDxAOReu9AmRF3qmrNBU2 MLVwM3r0LXehMR55w248rJRqIXwnAVia2xL2Ag2oBKo2eNWX0y7/zJ33bYnyw/lmg0XX2Kj1q y6pWlb7XTUmErwNNQVdExbbvEDubf6tYjtpV6A65thX1smkSTFz4zhj8MXO/uG+T+qlqpK3I6 Yi82hm/thzbr/7qNDDi+udjEiAmLiP1I3NeBUdyAx2yxZtXDm79ooTM9CM6rHvu0z3a1QKMgc jyn3K5Z4mUfywbMC/DI7sVFJK78II0gSJgT2/1BgeQDrFucGbxT7qb5lIfEf41hEUsFXRStyw A3bUCuvrwAhesTTcMno5ShSv0AXin3C0CsmrVnRbUYo4ztadR9HXXXFqD18y3FO8/4Z1T20GU tvGBUKWHP+zpQ8blC+AvK5ziyU4MLm5w4nLdA8EXoCwDl1aOBVrYCPJSD/G9h9ddHN2Mi7s40 0P/S6vZoV3GMfznJNrDwG5ssf+LW3UEN+vUx4ghMld0yv9AfQA= Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Markus Elfring Date: Tue, 16 Jan 2018 22:00:15 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Reviewed-by: Javier González --- drivers/lightnvm/pblk-gc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/lightnvm/pblk-gc.c b/drivers/lightnvm/pblk-gc.c index 9c8e114c8a54..54cdb4360366 100644 --- a/drivers/lightnvm/pblk-gc.c +++ b/drivers/lightnvm/pblk-gc.c @@ -147,10 +147,8 @@ static void pblk_gc_line_prepare_ws(struct work_struct *work) int ret; invalid_bitmap = kmalloc(lm->sec_bitmap_len, GFP_KERNEL); - if (!invalid_bitmap) { - pr_err("pblk: could not allocate GC invalid bitmap\n"); + if (!invalid_bitmap) goto fail_free_ws; - } emeta_buf = pblk_malloc(lm->emeta_len[0], l_mg->emeta_alloc_type, GFP_KERNEL);