| Message ID | 1459861174-9238-1-git-send-email-artur.paszkiewicz@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, 2016-04-05 at 14:59 +0200, Artur Paszkiewicz wrote: > The return value of md_set_badblocks() was inverted when the code was > taken out of md, but the case when badblocks are disabled was left > unchanged. This causes silent ignoring of I/O errors and other > unpredictable behavior on md arrays that do not support badblocks (any > array not using v1.x metadata). > > Fixes: 9e0e252a048b ("badblocks: Add core badblock management code") > Signed-off-by: Artur Paszkiewicz <artur.paszkiewicz@intel.com> > --- > block/badblocks.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Good find, thanks! Acked-by: Vishal Verma <vishal.l.verma@intel.com> Should this also be tagged for stable? -Vishal
On 04/05/2016 07:37 PM, Verma, Vishal L wrote: > On Tue, 2016-04-05 at 14:59 +0200, Artur Paszkiewicz wrote: >> The return value of md_set_badblocks() was inverted when the code was >> taken out of md, but the case when badblocks are disabled was left >> unchanged. This causes silent ignoring of I/O errors and other >> unpredictable behavior on md arrays that do not support badblocks (any >> array not using v1.x metadata). >> >> Fixes: 9e0e252a048b ("badblocks: Add core badblock management code") >> Signed-off-by: Artur Paszkiewicz <artur.paszkiewicz@intel.com> >> --- >> block/badblocks.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) > > Good find, thanks! > > Acked-by: Vishal Verma <vishal.l.verma@intel.com> > > Should this also be tagged for stable? Yes, I think it should be, since it affects 4.5. Artur -- To unsubscribe from this list: send the line "unsubscribe linux-block" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 2016-04-05 14:59, Artur Paszkiewicz wrote: > The return value of md_set_badblocks() was inverted when the code was > taken out of md, but the case when badblocks are disabled was left > unchanged. This causes silent ignoring of I/O errors and other > unpredictable behavior on md arrays that do not support badblocks (any > array not using v1.x metadata). > > Fixes: 9e0e252a048b ("badblocks: Add core badblock management code") > Signed-off-by: Artur Paszkiewicz <artur.paszkiewicz@intel.com> Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de> -- To unsubscribe from this list: send the line "unsubscribe linux-block" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/block/badblocks.c b/block/badblocks.c index 7be53cb..252f24e 100644 --- a/block/badblocks.c +++ b/block/badblocks.c @@ -147,6 +147,7 @@ EXPORT_SYMBOL_GPL(badblocks_check); * Return: * 0: success * 1: failed to set badblocks (out of space) + * -1: failed to set badblocks (badblocks are disabled) */ int badblocks_set(struct badblocks *bb, sector_t s, int sectors, int acknowledged) @@ -158,7 +159,7 @@ int badblocks_set(struct badblocks *bb, sector_t s, int sectors, if (bb->shift < 0) /* badblocks are disabled */ - return 0; + return -1; if (bb->shift) { /* round the start down, and the end up */
The return value of md_set_badblocks() was inverted when the code was taken out of md, but the case when badblocks are disabled was left unchanged. This causes silent ignoring of I/O errors and other unpredictable behavior on md arrays that do not support badblocks (any array not using v1.x metadata). Fixes: 9e0e252a048b ("badblocks: Add core badblock management code") Signed-off-by: Artur Paszkiewicz <artur.paszkiewicz@intel.com> --- block/badblocks.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)