| Message ID | 1460486175-25724-7-git-send-email-axboe@fb.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Apr 12, 2016 at 12:36:01PM -0600, Jens Axboe wrote: > Signed-off-by: Jens Axboe <axboe@fb.com> > --- > drivers/block/mtip32xx/mtip32xx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/block/mtip32xx/mtip32xx.c b/drivers/block/mtip32xx/mtip32xx.c > index 25824c1697c5..6b5c30ff5547 100644 > --- a/drivers/block/mtip32xx/mtip32xx.c > +++ b/drivers/block/mtip32xx/mtip32xx.c > @@ -4027,7 +4027,7 @@ skip_create_disk: > * write back cache is not supported in the device. FUA depends on > * write back cache support, hence setting flush support to zero. > */ > - blk_queue_flush(dd->queue, 0); > + blk_queue_write_cache(dd->queue, false, false); I think this can simply be removed.. -- To unsubscribe from this list: send the line "unsubscribe linux-block" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 04/12/2016 03:22 PM, Christoph Hellwig wrote: > On Tue, Apr 12, 2016 at 12:36:01PM -0600, Jens Axboe wrote: >> Signed-off-by: Jens Axboe <axboe@fb.com> >> --- >> drivers/block/mtip32xx/mtip32xx.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/block/mtip32xx/mtip32xx.c b/drivers/block/mtip32xx/mtip32xx.c >> index 25824c1697c5..6b5c30ff5547 100644 >> --- a/drivers/block/mtip32xx/mtip32xx.c >> +++ b/drivers/block/mtip32xx/mtip32xx.c >> @@ -4027,7 +4027,7 @@ skip_create_disk: >> * write back cache is not supported in the device. FUA depends on >> * write back cache support, hence setting flush support to zero. >> */ >> - blk_queue_flush(dd->queue, 0); >> + blk_queue_write_cache(dd->queue, false, false); > > I think this can simply be removed.. Functionally it can, question is if we want to keep it as documentation, or just kill the call and the comment?
On Tue, Apr 12, 2016 at 03:38:47PM -0600, Jens Axboe wrote: >>> - blk_queue_flush(dd->queue, 0); >>> + blk_queue_write_cache(dd->queue, false, false); >> >> I think this can simply be removed.. > > Functionally it can, question is if we want to keep it as documentation, or > just kill the call and the comment? I'd just kill it all. -- To unsubscribe from this list: send the line "unsubscribe linux-block" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 04/12/2016 03:39 PM, Christoph Hellwig wrote: > On Tue, Apr 12, 2016 at 03:38:47PM -0600, Jens Axboe wrote: >>>> - blk_queue_flush(dd->queue, 0); >>>> + blk_queue_write_cache(dd->queue, false, false); >>> >>> I think this can simply be removed.. >> >> Functionally it can, question is if we want to keep it as documentation, or >> just kill the call and the comment? > > I'd just kill it all. Done
diff --git a/drivers/block/mtip32xx/mtip32xx.c b/drivers/block/mtip32xx/mtip32xx.c index 25824c1697c5..6b5c30ff5547 100644 --- a/drivers/block/mtip32xx/mtip32xx.c +++ b/drivers/block/mtip32xx/mtip32xx.c @@ -4027,7 +4027,7 @@ skip_create_disk: * write back cache is not supported in the device. FUA depends on * write back cache support, hence setting flush support to zero. */ - blk_queue_flush(dd->queue, 0); + blk_queue_write_cache(dd->queue, false, false); /* Signal trim support */ if (dd->trim_supp == true) {
Signed-off-by: Jens Axboe <axboe@fb.com> --- drivers/block/mtip32xx/mtip32xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)