From patchwork Wed Jun 8 12:31:03 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christoph Hellwig X-Patchwork-Id: 9164477 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 86F0460572 for ; Wed, 8 Jun 2016 12:31:36 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 77CE027248 for ; Wed, 8 Jun 2016 12:31:36 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6C72F27BE5; Wed, 8 Jun 2016 12:31:36 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EE07727248 for ; Wed, 8 Jun 2016 12:31:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1425132AbcFHMbf (ORCPT ); Wed, 8 Jun 2016 08:31:35 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:52689 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1423697AbcFHMbf (ORCPT ); Wed, 8 Jun 2016 08:31:35 -0400 Received: from [83.175.99.196] (helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.80.1 #2 (Red Hat Linux)) id 1bAcdx-0000FI-7l; Wed, 08 Jun 2016 12:31:33 +0000 From: Christoph Hellwig To: keith.busch@intel.com, axboe@kernel.dk Cc: linux-block@vger.kernel.org, linux-nvme@lists.infradead.org, sagi@lightbits.io, ming.l@ssi.samsung.com, kbuild test robot , Fengguang Wu Subject: [PATCH 08/11] nvmet: fix eno.cocci warnings Date: Wed, 8 Jun 2016 14:31:03 +0200 Message-Id: <1465389066-19119-9-git-send-email-hch@lst.de> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1465389066-19119-1-git-send-email-hch@lst.de> References: <1465389066-19119-1-git-send-email-hch@lst.de> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: kbuild test robot drivers/nvme/target/configfs.c:796:5-11: ERROR: allocation function on line 795 returns NULL not ERR_PTR on failure drivers/nvme/target/configfs.c:739:5-11: ERROR: allocation function on line 738 returns NULL not ERR_PTR on failure The various basic memory allocation functions don't return ERR_PTR Generated by: scripts/coccinelle/null/eno.cocci CC: Christoph Hellwig Signed-off-by: Fengguang Wu Signed-off-by: Christoph Hellwig Reviewed-by: Ming Lin --- drivers/nvme/target/configfs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/nvme/target/configfs.c b/drivers/nvme/target/configfs.c index aebe646..9bed302 100644 --- a/drivers/nvme/target/configfs.c +++ b/drivers/nvme/target/configfs.c @@ -736,7 +736,7 @@ static struct config_group *nvmet_referral_make( struct nvmet_port *port; port = kzalloc(sizeof(*port), GFP_KERNEL); - if (IS_ERR(port)) + if (!port) return ERR_CAST(port); INIT_LIST_HEAD(&port->entry); @@ -793,7 +793,7 @@ static struct config_group *nvmet_ports_make(struct config_group *group, return ERR_PTR(-EINVAL); port = kzalloc(sizeof(*port), GFP_KERNEL); - if (IS_ERR(port)) + if (!port) return ERR_CAST(port); INIT_LIST_HEAD(&port->entry);