| Message ID | 1465480836-32093-2-git-send-email-hch@lst.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 06/09/2016 09:00 AM, Christoph Hellwig wrote: > Keep the 32-bit CPU and cmd_type flags together to avoid holes on 64-bit > architectures. > > Signed-off-by: Christoph Hellwig <hch@lst.de> > --- > include/linux/blkdev.h | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h > index 0c9f879..9746d22 100644 > --- a/include/linux/blkdev.h > +++ b/include/linux/blkdev.h > @@ -96,12 +96,11 @@ struct request { > struct request_queue *q; > struct blk_mq_ctx *mq_ctx; > > - u64 cmd_flags; > + int cpu; > unsigned cmd_type; > + u64 cmd_flags; > unsigned long atomic_flags; > > - int cpu; > - > /* the following two fields are internal, NEVER access directly */ > unsigned int __data_len; /* total data len */ > sector_t __sector; /* sector cursor */ > Looks ok to me. Reviewed-by: Mike Christie <mchristi@redhat.com> -- To unsubscribe from this list: send the line "unsubscribe linux-block" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h index 0c9f879..9746d22 100644 --- a/include/linux/blkdev.h +++ b/include/linux/blkdev.h @@ -96,12 +96,11 @@ struct request { struct request_queue *q; struct blk_mq_ctx *mq_ctx; - u64 cmd_flags; + int cpu; unsigned cmd_type; + u64 cmd_flags; unsigned long atomic_flags; - int cpu; - /* the following two fields are internal, NEVER access directly */ unsigned int __data_len; /* total data len */ sector_t __sector; /* sector cursor */
Keep the 32-bit CPU and cmd_type flags together to avoid holes on 64-bit architectures. Signed-off-by: Christoph Hellwig <hch@lst.de> --- include/linux/blkdev.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)