From patchwork Mon Nov 21 12:10:32 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?UTF-8?q?Javier=20Gonz=C3=A1lez?= X-Patchwork-Id: 9439351 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id C970B6075D for ; Mon, 21 Nov 2016 12:12:30 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B8B0C28A9F for ; Mon, 21 Nov 2016 12:12:30 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A0C4128A71; Mon, 21 Nov 2016 12:12:30 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 27EEE28A81 for ; Mon, 21 Nov 2016 12:12:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753918AbcKUMMS (ORCPT ); Mon, 21 Nov 2016 07:12:18 -0500 Received: from mail-wm0-f53.google.com ([74.125.82.53]:35168 "EHLO mail-wm0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754073AbcKUMLI (ORCPT ); Mon, 21 Nov 2016 07:11:08 -0500 Received: by mail-wm0-f53.google.com with SMTP id a197so143072766wmd.0 for ; Mon, 21 Nov 2016 04:11:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lightnvm-io.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=MAG2Aq48FwH4SMcaMiwhmVX1Ul6QBe1oRgNRLSNlpn4=; b=ZEoBdQHO9Jmy2bB2HqZsWxyJoDu+iupO2ohSdVlrdejiZPYjbzObL22vNnON9ceTvr CU3h8vL5HVerDdEqvWZX4U0RMi3z0acDKcgR9b3GMoxRzPzmKNuuO1hPIyuYolcMN3IC qOyzQ+kxs+09GKMi+zThMTkHEU/TQkuHh8i0Ow0P2TENbNYMmE2ZA7U4If7bUetxpukA 6+BXl/to3dljoXudGjWUgWKebpuxjoqEJ/mGCdrv9sazLrnHw+lUdBWQznM6kTp0pZjJ AQm/61HNgBDZNNurOxIKMwUU+FWwkpLGvsT+61fo1z+k9euKExAPmE9jO3rKNjU/gS/g vyYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=MAG2Aq48FwH4SMcaMiwhmVX1Ul6QBe1oRgNRLSNlpn4=; b=mUAfja2M7571RHW+Ps/aplD6oJi8GBDJevuP5NTx4EGqjvVG+4dqeTFkdiEyqUeueG /Ow1TXftp3Pty3W94MGtXN0v0ZErd7FzY+e0zaeXlE/0q86DXecwPyi8JLY95dc31dkI nKMt5rf4rq8F4J8r4CUkI4oK3GbJYtAXFsIZcExvU3V3hIPpAwmjyr7IGa5iMGuiwqTI fG2aBxUCfAj3LXQ9vkDJZBKov27k2jYxLOAm6N+IiY0fGWhMn9X5xQTavlBPmUo3J+f3 UkpiZwBtvT+JfA1p6FpdcYWTI68iQ6Gw8o+KXtTOGJA48/eJO5uoWQzq7fdco64p9ncI ZWyQ== X-Gm-Message-State: AKaTC02sv7HaS84jgWMIKXH0BW8x/FNS1/aWbPx2eEPAqcGl7UuTwVKJwTXb3Y0xgOHWHQ== X-Received: by 10.28.172.68 with SMTP id v65mr13269561wme.99.1479730265107; Mon, 21 Nov 2016 04:11:05 -0800 (PST) Received: from uHalley.cnexlabs.com (6164211-cl69.boa.fiberby.dk. [193.106.164.211]) by smtp.gmail.com with ESMTPSA id b3sm8374975wjy.40.2016.11.21.04.11.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 21 Nov 2016 04:11:04 -0800 (PST) From: "=?UTF-8?q?Javier=20Gonz=C3=A1lez?=" X-Google-Original-From: =?UTF-8?q?Javier=20Gonz=C3=A1lez?= To: mb@lightnvm.io Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, =?UTF-8?q?Javier=20Gonz=C3=A1lez?= Subject: [PATCH 3/8] lightnvm: remove debug lun statistics from gennvm Date: Mon, 21 Nov 2016 13:10:32 +0100 Message-Id: <1479730237-20797-4-git-send-email-javier@cnexlabs.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1479730237-20797-1-git-send-email-javier@cnexlabs.com> References: <1479730237-20797-1-git-send-email-javier@cnexlabs.com> MIME-Version: 1.0 Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Since LUNs are managed internally on targets, the media manager has no access to the free LUN lists. Thus, debug functions that show LUN information on the device should not be implemented on the media manager, but rather on the target in itself. Signed-off-by: Javier González --- drivers/lightnvm/gennvm.c | 19 ------------------- include/linux/lightnvm.h | 5 ----- 2 files changed, 24 deletions(-) diff --git a/drivers/lightnvm/gennvm.c b/drivers/lightnvm/gennvm.c index 3cf5d59..dd9afd7 100644 --- a/drivers/lightnvm/gennvm.c +++ b/drivers/lightnvm/gennvm.c @@ -613,23 +613,6 @@ static int gen_erase_blk(struct nvm_dev *dev, struct nvm_block *blk, int flags) return nvm_erase_ppa(dev, &addr, 1, flags); } -static void gen_lun_info_print(struct nvm_dev *dev) -{ - struct gen_dev *gn = dev->mp; - struct nvm_lun *lun; - unsigned int i; - - - gen_for_each_lun(gn, lun, i) { - spin_lock(&lun->lock); - - pr_info("%s: lun%8u\t%u\n", dev->name, i, - lun->nr_free_blocks); - - spin_unlock(&lun->lock); - } -} - static struct nvmm_type gen = { .name = "gennvm", .version = {0, 1, 0}, @@ -645,8 +628,6 @@ static struct nvmm_type gen = { .mark_blk = gen_mark_blk, - .lun_info_print = gen_lun_info_print, - .get_area = gen_get_area, .put_area = gen_put_area, diff --git a/include/linux/lightnvm.h b/include/linux/lightnvm.h index e56c352..ed04fa6 100644 --- a/include/linux/lightnvm.h +++ b/include/linux/lightnvm.h @@ -541,8 +541,6 @@ typedef int (nvmm_remove_tgt_fn)(struct nvm_dev *, struct nvm_ioctl_remove *); typedef int (nvmm_submit_io_fn)(struct nvm_dev *, struct nvm_rq *); typedef int (nvmm_erase_blk_fn)(struct nvm_dev *, struct nvm_block *, int); typedef void (nvmm_mark_blk_fn)(struct nvm_dev *, struct ppa_addr, int); -typedef void (nvmm_lun_info_print_fn)(struct nvm_dev *); - typedef int (nvmm_get_area_fn)(struct nvm_dev *, sector_t *, sector_t); typedef void (nvmm_put_area_fn)(struct nvm_dev *, sector_t); @@ -562,9 +560,6 @@ struct nvmm_type { /* Bad block mgmt */ nvmm_mark_blk_fn *mark_blk; - /* Statistics */ - nvmm_lun_info_print_fn *lun_info_print; - nvmm_get_area_fn *get_area; nvmm_put_area_fn *put_area;