From patchwork Thu Jan 26 15:57:39 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?UTF-8?q?Javier=20Gonz=C3=A1lez?= X-Patchwork-Id: 9539623 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id A6418604A9 for ; Thu, 26 Jan 2017 16:06:32 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 95B0526E4F for ; Thu, 26 Jan 2017 16:06:32 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8A87B26E96; Thu, 26 Jan 2017 16:06:32 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 24B4E26E91 for ; Thu, 26 Jan 2017 16:06:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752183AbdAZQGB (ORCPT ); Thu, 26 Jan 2017 11:06:01 -0500 Received: from mail-wm0-f49.google.com ([74.125.82.49]:35026 "EHLO mail-wm0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752158AbdAZQFm (ORCPT ); Thu, 26 Jan 2017 11:05:42 -0500 Received: by mail-wm0-f49.google.com with SMTP id r126so78479331wmr.0 for ; Thu, 26 Jan 2017 08:04:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lightnvm-io.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=lexr2Sea54vlLX8hToifBWPEp9drg9hgQvP2BybFr9E=; b=yl/8oAR+Dx2Odt6whL0d6WYKgHqtU6O8B5ZqGJ3mxaPuYwwZMomThGuk1sCOKLIjtU +47WukNrjx72OVQpQI9E8uLedrTrEdYxDu2RlPfnlP0xFpSaUzUQaz7fqwKWgl8MoNan wn4IWYPtrouueQ3DjKJmbuveUTwzQy5S4hL5YP2fcuIzSWZzqXJOMzjoJ7K2zArahAHj HZo4RmFUkqz/M2jrhFehvLdgHQO5t5GtP98P3SmkEDMu9ATDtsswFDL9cqy2nCGUGsf7 abKItoUo83ZlmVyo487p3msf+d+Cx7IwHdv/n6lT/MFgQNbc89f3QvSoo1m3M9l4PX3y lAwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=lexr2Sea54vlLX8hToifBWPEp9drg9hgQvP2BybFr9E=; b=HLi6ZiGidQKvDzPqoDUVvJDSrMvaFF5JKALMJvunpT0GH42vfS9C2hNLOBlX+1RixU j1y+l9dkFRBpvNX8al2FV73FOI7PPNe3LCtNRpjJ+97iPALZkIcsgnea4TrNs4TNY1UN Pdk5wWDkALcLYd48Vgg+ASMsE/f8cY8SuldQ/yfD34r9xKvTflWgosqZaqcGI2nzb6hX xzrL9qDD8l+KN0gfvP6fv0edAQtslpb/3uDSrJlcMQPbW/bymqvSDV3sDA+ZDRJ8FP3X yY4MA2mrjMElzgTsqCPrmsKIijTMwr/ONcStPvKSZQT3lO9kVgZDOexaFuKbuetssxBu fgjw== X-Gm-Message-State: AIkVDXJQrqQUFxmauGqKKVzbGudP+hrdQEF6sAx+lyv7m6dMK38RxBvl+XNMVbFz+7rQ8g== X-Received: by 10.223.137.2 with SMTP id s2mr3823485wrs.20.1485446279588; Thu, 26 Jan 2017 07:57:59 -0800 (PST) Received: from uHalley.cnexlabs.com (6164211-cl69.boa.fiberby.dk. [193.106.164.211]) by smtp.gmail.com with ESMTPSA id a13sm37445071wma.0.2017.01.26.07.57.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 26 Jan 2017 07:57:58 -0800 (PST) From: "=?UTF-8?q?Javier=20Gonz=C3=A1lez?=" X-Google-Original-From: =?UTF-8?q?Javier=20Gonz=C3=A1lez?= To: mb@lightnvm.io Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, =?UTF-8?q?Javier=20Gonz=C3=A1lez?= Subject: [PATCH] lightnvm: free properly on target creation error Date: Thu, 26 Jan 2017 16:57:39 +0100 Message-Id: <1485446259-2396-1-git-send-email-javier@cnexlabs.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Fix a memory leak when target creation fails. More specifically, free the entire device structure given to the target (tgt_dev). Signed-off-by: Javier González --- drivers/lightnvm/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/lightnvm/core.c b/drivers/lightnvm/core.c index 8baae61..d5bb5e1 100644 --- a/drivers/lightnvm/core.c +++ b/drivers/lightnvm/core.c @@ -309,7 +309,7 @@ static int nvm_create_tgt(struct nvm_dev *dev, struct nvm_ioctl_create *create) err_queue: blk_cleanup_queue(tqueue); err_dev: - kfree(tgt_dev); + nvm_remove_tgt_dev(tgt_dev); err_t: kfree(t); err_reserve: