From patchwork Thu Feb 9 00:08:18 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: James Bottomley X-Patchwork-Id: 9563817 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 568AC60216 for ; Thu, 9 Feb 2017 00:09:20 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D688D28536 for ; Thu, 9 Feb 2017 00:09:19 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C71892853C; Thu, 9 Feb 2017 00:09:19 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0E5D628536 for ; Thu, 9 Feb 2017 00:09:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752504AbdBIAJR (ORCPT ); Wed, 8 Feb 2017 19:09:17 -0500 Received: from bedivere.hansenpartnership.com ([66.63.167.143]:39462 "EHLO bedivere.hansenpartnership.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752342AbdBIAJP (ORCPT ); Wed, 8 Feb 2017 19:09:15 -0500 Received: from localhost (localhost [127.0.0.1]) by bedivere.hansenpartnership.com (Postfix) with ESMTP id C48FD8EE1AD; Wed, 8 Feb 2017 16:08:19 -0800 (PST) Received: from bedivere.hansenpartnership.com ([127.0.0.1]) by localhost (bedivere.hansenpartnership.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lfh77f8Kdg1U; Wed, 8 Feb 2017 16:08:19 -0800 (PST) Received: from [153.66.254.194] (50-47-107-254.evrt.wa.frontiernet.net [50.47.107.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by bedivere.hansenpartnership.com (Postfix) with ESMTPSA id E4AA48EE0DC; Wed, 8 Feb 2017 16:08:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=hansenpartnership.com; s=20151216; t=1486598899; bh=RFOs5TNfPTyW2hoPtSoXTlcrTW+qQXtohdiawSMzWMo=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=jhx8sEbndguncH8v0VpHGtoqKtONnqjZ2MVDuM0Yn9y6DeCferzzJkoJkJuvNsH+D g4RqRkTuA8A7M8T9NKYpniCygxSGFA0KoNZUiQEWjNMJz/dfcgQb6b8MPTJf24AxKF EVTL/A77LmJK1qqL/W9/VIA9bmKN/Wk4AQv3quyw= Message-ID: <1486598898.2484.46.camel@HansenPartnership.com> Subject: Re: [lkp-robot] [scsi, block] 0dba1314d4: WARNING:at_fs/sysfs/dir.c:#sysfs_warn_dup From: James Bottomley To: Dan Williams , Jens Axboe Cc: Christoph Hellwig , kernel test robot , Bart Van Assche , "Martin K. Petersen" , Jan Kara , Omar Sandoval , Omar Sandoval , LKML , Jens Axboe , LKP , linux-scsi , linux-block@vger.kernel.org Date: Wed, 08 Feb 2017 16:08:18 -0800 In-Reply-To: References: <20170204070936.GE12121@yexl-desktop> <20170205091314.GA3042@lst.de> <1486426467.2474.122.camel@HansenPartnership.com> <01c338e2-2a30-610d-b7fa-00cb3ce2cf86@fb.com> X-Mailer: Evolution 3.16.5 Mime-Version: 1.0 Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Mon, 2017-02-06 at 21:42 -0800, Dan Williams wrote: > On Mon, Feb 6, 2017 at 8:09 PM, Jens Axboe wrote: > > On 02/06/2017 05:14 PM, James Bottomley wrote: > > > On Sun, 2017-02-05 at 21:13 -0800, Dan Williams wrote: > > > > On Sun, Feb 5, 2017 at 1:13 AM, Christoph Hellwig > > > > wrote: > > > > > Dan, > > > > > > > > > > can you please quote your emails? I can't find any content > > > > > inbetween all these quotes. > > > > > > > > Sorry, I'm using gmail, but I'll switch to attaching the logs. > > > > > > > > So with help from Xiaolong I was able to reproduce this, and it > > > > does > > > > not appear to be a regression. We simply change the failure > > > > output of > > > > an existing bug. Attached is a log of the same test on v4.10 > > > > -rc7 > > > > (i.e. without the recent block/scsi fixes), and it shows sda > > > > being > > > > registered twice. > > > > > > > > "[ 6.647077] kobject (d5078ca4): tried to init an > > > > initialized > > > > object, something is seriously wrong." > > > > > > > > The change that "scsi, block: fix duplicate bdi name > > > > registration > > > > crashes" makes is to properly try to register sdb since the sda > > > > devt > > > > is still alive. However that's not a fix because we've managed > > > > to > > > > call blk_register_queue() twice on the same queue. > > > > > > OK, time to involve others: linux-scsi and linux-block cc'd and > > > I've > > > inserted the log below. > > > > > > James > > > > > > --- > > > > > > [ 5.969672] scsi host0: scsi_debug: version 1.86 [20160430] > > > [ 5.969672] dev_size_mb=8, opts=0x0, submit_queues=1, > > > statistics=0 > > > [ 5.971895] scsi 0:0:0:0: Direct-Access Linux > > > scsi_debug 0186 PQ: 0 ANSI: 7 > > > [ 6.006983] sd 0:0:0:0: [sda] 16384 512-byte logical blocks: > > > (8.39 MB/8.00 MiB) > > > [ 6.026965] sd 0:0:0:0: [sda] Write Protect is off > > > [ 6.027870] sd 0:0:0:0: [sda] Mode Sense: 73 00 10 08 > > > [ 6.066962] sd 0:0:0:0: [sda] Write cache: enabled, read > > > cache: enabled, supports DPO and FUA > > > [ 6.486962] sd 0:0:0:0: [sda] Attached SCSI disk > > > [ 6.488377] sd 0:0:0:0: [sda] Synchronizing SCSI cache > > > [ 6.489455] sd 0:0:0:0: Attached scsi generic sg0 type 0 > > > [ 6.526982] sd 0:0:0:0: [sda] 16384 512-byte logical blocks: > > > (8.39 MB/8.00 MiB) > > > [ 6.546964] sd 0:0:0:0: [sda] Write Protect is off > > > [ 6.547873] sd 0:0:0:0: [sda] Mode Sense: 73 00 10 08 > > > [ 6.586963] sd 0:0:0:0: [sda] Write cache: enabled, read > > > cache: enabled, supports DPO and FUA > > > [ 6.647077] kobject (d5078ca4): tried to init an initialized > > > object, something is seriously wrong. > > > > So sda is probed twice, and hilarity ensues when we try to register > > it > > twice. I can't reproduce this, using scsi_debug and with > > scsi_async > > enabled. > > > > This is running linux-next? What's your .config? > > > > The original failure report is here: > > http://marc.info/?l=linux-kernel&m=148619222300774&w=2 > > ...but it reproduces on current mainline with the same config. I > haven't spotted what makes scsi_debug behave like this. Looking at the config, it's a static debug with report luns enabled. Is it as simple as the fact that we probe lun 0 manually to see if the target exists, but then we don't account for the fact that we already did this, so if it turns up again in the report lun scan, we'll probe it again leading to a double add. If that theory is correct, this may be the fix (compile tested only). James diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c index 6f7128f..ba4be08 100644 --- a/drivers/scsi/scsi_scan.c +++ b/drivers/scsi/scsi_scan.c @@ -1441,6 +1441,10 @@ static int scsi_report_lun_scan(struct scsi_target *starget, int bflags, for (lunp = &lun_data[1]; lunp <= &lun_data[num_luns]; lunp++) { lun = scsilun_to_int(lunp); + if (lun == 0) + /* already scanned LUN 0 */ + continue; + if (lun > sdev->host->max_lun) { sdev_printk(KERN_WARNING, sdev, "lun%llu has a LUN larger than"