From patchwork Mon Mar 13 20:07:56 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bart Van Assche X-Patchwork-Id: 9622031 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 14C0E60244 for ; Mon, 13 Mar 2017 20:08:08 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0781728138 for ; Mon, 13 Mar 2017 20:08:08 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id ED1F3283A6; Mon, 13 Mar 2017 20:08:07 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3E1C628138 for ; Mon, 13 Mar 2017 20:08:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751874AbdCMUIH (ORCPT ); Mon, 13 Mar 2017 16:08:07 -0400 Received: from esa4.hgst.iphmx.com ([216.71.154.42]:62932 "EHLO esa4.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751119AbdCMUIF (ORCPT ); Mon, 13 Mar 2017 16:08:05 -0400 X-IronPort-AV: E=Sophos;i="5.36,160,1486396800"; d="scan'208";a="2995529" Received: from mail-co1nam03lp0017.outbound.protection.outlook.com (HELO NAM03-CO1-obe.outbound.protection.outlook.com) ([216.32.181.17]) by ob1.hgst.iphmx.com with ESMTP; 14 Mar 2017 04:08:04 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector1-sharedspace-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=2/USrqf7ciknaDjbJHnxpLiwu3BKYifeU5Q90rBscwM=; b=L8hG5yf6699Y5qlQEXDdJrIAJUV2pFpTvDjTZzrEb6deIknH+VaybWpT9s4FEemRWKwauA3Wtb2sCsqusJD0BfmpkCGWl9CuIPnQsUoWOOFDgbo19+BAcGGTr+gs5nvAqTn4he7/OSxIJdyesZiF2jY+0Uz2ctquMN+DixWNiPQ= Received: from BN6PR04CA0023.namprd04.prod.outlook.com (10.172.194.33) by BLUPR0401MB1489.namprd04.prod.outlook.com (10.163.83.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.947.12; Mon, 13 Mar 2017 20:08:01 +0000 Received: from BN3NAM04FT029.eop-NAM04.prod.protection.outlook.com (2a01:111:f400:7e4e::202) by BN6PR04CA0023.outlook.office365.com (2603:10b6:404:cb::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.961.17 via Frontend Transport; Mon, 13 Mar 2017 20:08:01 +0000 Authentication-Results: spf=pass (sender IP is 74.221.232.54) smtp.mailfrom=sandisk.com; huawei.com; dkim=none (message not signed) header.d=none;huawei.com; dmarc=bestguesspass action=none header.from=sandisk.com; Received-SPF: Pass (protection.outlook.com: domain of sandisk.com designates 74.221.232.54 as permitted sender) receiver=protection.outlook.com; client-ip=74.221.232.54; helo=sacsmgep14.sandisk.com; Received: from sacsmgep14.sandisk.com (74.221.232.54) by BN3NAM04FT029.mail.protection.outlook.com (10.152.92.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.961.10 via Frontend Transport; Mon, 13 Mar 2017 20:08:00 +0000 X-AuditID: ac1c2133-9afff7000000c960-23-58c6fc1dbce5 Received: from SACCASIP04.sdcorp.global.sandisk.com (Unknown_Domain [172.28.1.254]) (using TLS with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by (Symantec Messaging Gateway) with SMTP id 4A.00.51552.D1CF6C85; Mon, 13 Mar 2017 13:07:59 -0700 (PDT) Received: from ULS-OP-MBXIP03.sdcorp.global.sandisk.com ([fe80::f9ec:1e1b:1439:62d8]) by SACCASIP04.sdcorp.global.sandisk.com ([::1]) with mapi id 14.03.0319.002; Mon, 13 Mar 2017 13:07:57 -0700 From: Bart Van Assche To: "linux-block@vger.kernel.org" , "yanaijie@huawei.com" , "axboe@kernel.dk" CC: "zhaohongjiang@huawei.com" , "miaoxie@huawei.com" Subject: Re: [PATCH] brd: make rd_size static Thread-Topic: [PATCH] brd: make rd_size static Thread-Index: AQHSnDWBdxdsAvgNZ0mIpWMTKK8VkQ== Date: Mon, 13 Mar 2017 20:07:56 +0000 Message-ID: <1489435663.2658.12.camel@sandisk.com> References: <1489131159-840-1-git-send-email-yanaijie@huawei.com> <4dd2367b-61b9-d390-5bb1-955e90fef0b0@kernel.dk> In-Reply-To: <4dd2367b-61b9-d390-5bb1-955e90fef0b0@kernel.dk> Accept-Language: nl-NL, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.28.1.254] Content-ID: <0BAB680B75B040469D166E40D34E7AE8@sandisk.com> MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrGIsWRmVeSWpSXmKPExsWyRobxn678n2MRBlOW6lisvtvPZrH3lrZF x8p7rBaL9nQyW3xtWs3uwOrRcuQtq8fls6UenzfJBTBHcdmkpOZklqUW6dslcGXcefOLqeCj YEX/1u9sDYwv+boYOTkkBEwk1j5tZuti5OIQEljCJPHl9DFmCOcYo8SCP11MIFVsAkYSsyfs YQFJiAhMZZS4vP4uG0iCWSBN4lLjQ7AiYQFdiYlX3gAVcQAV6Uls3h4DEgYx/+7ewQJiswio Shyb8o8ZxOYFmvl8zx6wMUICpRLddx+wg9icArYSV970gY1hFJCVaHnNDbFJXOLWk/lMEEcL SCzZc54ZwhaVePn4HyuErSDxecU/qMv0JG5MnQJlW0k8fLadCcLWlli28DXUCYISJ2c+YZnA KDYLyYpZSNpnIWmfhaR9FpL2BYysqxjFihOTi3PTUwsMTfSKE/NSMouz9ZLzczcxgmNP0XgH 478N7ocYBTgYlXh4b8w7FiHEmlhWXJl7iFGCg1lJhHfvd6AQb0piZVVqUX58UWlOavEhRmkO FiVx3pjZUyOEBNITS1KzU1MLUotgskwcnFINjNo3fUXja+e+cFZ9fLlhgxiL3H+Fn1dsUl79 1mN2lymQbWRPZOPrlA4u7dAQ3C/i+3hB4f3ODbUPbj7L4rHkjLzZ0n/pJvffNZ8X/rxivlz+ 1g3L5alnahMyVliWtrBPk6yI3rOM40TT39lLNx3exyTq2rR9geHVZP4deeWX/i1tW8E7Rd5f RomlOCPRUIu5qDgRALBfj4i5AgAA X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:74.221.232.54; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10019020)(6009001)(39850400002)(39840400002)(39410400002)(39860400002)(39450400003)(2980300002)(438002)(189002)(377424004)(24454002)(377454003)(199003)(9170700003)(38730400002)(6246003)(3846002)(102836003)(189998001)(47776003)(53936002)(23756003)(2201001)(6116002)(229853002)(575784001)(86362001)(103116003)(54906002)(305945005)(53546007)(8746002)(8676002)(7736002)(81166006)(2906002)(8936002)(4326008)(356003)(2900100001)(33646002)(2950100002)(50466002)(36756003)(2270400002)(2501003)(106466001)(5250100002)(5660300001)(54356999)(106116001)(76176999)(50986999); DIR:OUT; SFP:1102; SCL:1; SRVR:BLUPR0401MB1489; H:sacsmgep14.sandisk.com; FPR:; SPF:Pass; MLV:sfv; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN3NAM04FT029; 1:vYAkw1Ov5wCYIT25y5K+Un4FsTaJEx7Edvh27RbG3IOBb5LNTI8TMvA7QiMMxvpnYidWNJC/hd+UwuqKIDhJP8ug+x0qt+/vKkYIewdwxf2MNtE5fpJL6/YhdNpkhMExbPDhSyCBC4Po6ymYt8La01nOXmDu2hpaOCKgjWErRyuUqm7OsVRnjTwqtLd1LFAmDqtZxMNLcUtjuONYkPrbTOW/rDrk0CL2Vq+cvMSgWHMl8P0Wq2t6ZoVfI2AN8Ej7cKWsXkM7sf75NBCqW9x/rEzz9pr/WH/TKS+CRH+KRlGzrbKDNUngoiNGw2uNqHoAjROynJaqVOG+677O2BybAy6udaRyNkALecFT3auuiXD5d9L4+b6oSFkvePQesZ8NAvqLP5Nx/W7/jfGJiM4ghDn+4lL/Hnz9M3UlzB4cOmnilsXDzB2bHTFZmt7qL6J1yMB9+gT0i560kcz5U3mPqKOHO/q2Np5mzt1kI12NOwlO9tLifytJbc7oSqUZhtWHEFGPDzdDAKggjUHTZ4XBHnI6n7CEBKi0psC6+f5Put3ZxoSNG3ldB6O8vycni0OsU7CXWcCU7Oo+e5ZsLqKqUg== X-MS-Office365-Filtering-Correlation-Id: 8b1e1337-bf71-49e7-498b-08d46a4ca6a2 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(8251501002); SRVR:BLUPR0401MB1489; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0401MB1489; 3:/DUvNaOVmSCFuS9s+ou4corI7+DFFIbPJAIBmkZ0s2y19TpFAPDr1PNTuQp1luSI1DlE3+Ik9j+nU+eLq3L7btBj+zFpleUQhrGmk3sWApE0gk+EhTZjD6ZZtffhNooC6JBGMNqb5o3cPeFGNZSl2nO6xKxlEHK4PM4fAMY2HPNr4P1HwPdg4XEgisoMs34tk07cOQedBK5ve3JMdF6wJAIdvPXVfJHBuhRjnrt9EtsZ6PgS8uVD11KHNc1oCMcwtVrCmpISOCcTyHyoggW491VAVwBjBU6291q6llbw/bogEBINxI/iSR5FMwGoFCRuwFgMI7y2huh6R81k4fAeup9ce/pp87vCini+1HZISEQamhvRn74U3Qif33N74b4pvihMJfHhkIRZstVsJs+C4g==; 25:TIxldEzf/JtBQIu6ap5mS9CkQH/4t7KXMU45mSBszcwNzVPU7bCElJyuK2zPH8u7nbu/MTa0EOPYCeoeD1tKnJ5o7du3n9koJC9sFPtp7mqfTaQ3MePL1+hQQvypAFvaUa6A+TviTqZ9lRVAqrScDLdMihJMOs28PAyu3HyMPLCuPMsk4a81xTwIB/DE0BDE/0ZHCv72Zjw5zRWUjvlCASI/w1JjSkBX1zDkM+BqrLJcqrXkHb9hTHhF5EW70SedyXmaIqs3js3gpGH2++NN4CIx8Ay6BHEGkr3u0v5qIHQxmoszL9fB6xY+nlnSNBf/G3Vu1jdDlHfb5hjkZ64cDWNQuB7B7JH0zpBdgrlzV0FWFc/roMPgGNxHyJQJSWsPEiJnT8ykXqgZJc7ZH7xAP4vKwd7SndMhsYTn4PN+Zh/XB8/lKMqZhwK/8v6SRjkh7sZ65jcpIVFNKpuv6vvChQ== X-Microsoft-Exchange-Diagnostics: 1; BLUPR0401MB1489; 31:emu0zA3f7R+xFuwbhlM9Ep3ORLSzag9CYaaczyEHaNvvIUDdHBmIElJvD+JAdvCaWGYywJe74QPO3FLtQHu+sFu5cnaPYBwLYFUurrr8yKUSYnlwXDx6fFDVC7/s/3v8m6+J6gq8emEoVslE3TPAdVBgdbk4XGnFMCBdr+mnZtC1ev6N7JgCOBnvOqvktTwFViRf5oc/wW2wOKY+wRpGccUWt3bIQQR/390jfhXSaADYutDvVogUj+XHwlmqB778AdbzCGPLFfsxrC5mHbci9Q==; 20:95HmLG87soS+5r5LLOyoddsNJqbAaCENIGN5D66ZMpmqR3p+vEvPsNucGG9CgL4XvQtagXxUNaAJjJ2DQW98QjRfWL6G/EShk+wbFKNz9Ow4FYosc/RYIKnmAOgBc/uGfozR4DtQa+I43f45jJtLGyN0M5FFVvnr1n+GHyD9KeogBkYM4HCtornGbOZpFBU6TcdiqdtgXsdLRkCWmU5yHzEORsvO0hh83I8gBf8wHjZrsNs9QD6NkdWxgRTMS7aqlzDUFMoXL7vdYLX9aSzjeXe2TCuMTBZmSaNHJ3M8SXPYTojBOgIhsN4/CYvX3GKSAQ5/YnXwyRgkAs+KRpbVU+Ye5LXGNfbAXL2to/djzMAVmj4gHxCNTvFkkETiXQuIH95fif3wdOQ7KaSWsKyNhjvyHcVX1Wk1boLHRUacxMeaIWTBEEM+mljvSrNw6u2s0IZHPw/aZB8+6+glAUSZnnacVUjrt1mwB7wqElGLmlTmDfZrMLb5RM8ze3erL8b1 WDCIPOUTBOUND: EOP-TRUE X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(8121501046)(13023025)(13016025)(5005006)(13018025)(13024025)(3002001)(10201501046)(6055026)(6041248)(20161123558025)(20161123562025)(20161123555025)(20161123564025)(20161123560025)(6072148); SRVR:BLUPR0401MB1489; BCL:0; PCL:0; RULEID:; SRVR:BLUPR0401MB1489; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0401MB1489; 4:6JQLcd5aQhep6GLSQ91D8FUcm7+j0h4wuwxylKUh39klVD2Rtbdxuxay8zpyUhEq0C2HxdWCuG6CcYe5JoC1smYpxDwrDX6tw0x9MLU6rv5IpshMQ6mGxfjN4yBOgq767RM5o6rQq1N20KsMOzigk+9x+j65mJl37iMg05w+p7IAL2E2mlHqDWzCUsIK+tXVBlZ1A2+NsMChnuRh0vhI0I0SJwL6Oaf46Q1y6uqOBKJzmTgGVI3ULf/yTRUQg9w/J8I37o2ow6fN8ljM/Vfg4z7/OmuBhEho3vw4zcNkNxaRYOzK99VR8w+qjoAR+yKmumGuQyU/xZMe63RuZ2oUOowvK4LItUB35hUy0CAP2bU9A3UN5gVDvyy560lwZC/naAgbWfLd/2eugd44CwBmimEC0uDh0awQnkGnZskhCGk9EJcLZXdaKIGYF0QpOiWDPe05OKOazdzAUKIqyCoOheXJ6zGnPulxIrYwqzPQRlVtmVGJgxytxTgUN9MbnY0UyPdfu/mEmS6rWt6Ozb8yL9Dk8Cpz16T4JWVMzJwghPQmw6bNRW3Gb5Jjb17BNlDTNWe37ZFn72Zk4h6cB2qxq4n1pucuFYFwdCxb0O0RBcg4YRpYOAJXNMSBVMUGyFSRbk1RCcX7qc5iLcUAYCRs5DMwcqLu1nLQW6klbTOh6Fl7yEkivpf3PLY4dx12V3ZIfm+6oI3AH9KjUB3EmJjvAQ== X-Forefront-PRVS: 0245702D7B X-Microsoft-Exchange-Diagnostics: =?iso-8859-1?Q?1; BLUPR0401MB1489; 23:YDN1OWl584sGEIDYpySlXUKZHNYnLBlZxGHsu?= =?iso-8859-1?Q?NXxngMJwRVpucqjNmen7ztXwq+VwvTjZ5qQEuKD/QiiAsdA87Bii3lCL12?= =?iso-8859-1?Q?Xck4W84dFjA35v7701+XVHjyC2mRC+PysO1HdvFidq+K+BRJIkCap5KnEI?= =?iso-8859-1?Q?FI4Dzd0D8+J0ibvW5/ZvGlLeY+fzPsBu4tANaA3G+SRLIby7DVaNfTEf35?= =?iso-8859-1?Q?ZWxuW7VuQDXRvV245motn51uk0i6SPUEoh/foDkPpnNCGqPMP8SpnnIsx1?= =?iso-8859-1?Q?7gLExYMlGNBfMOTNI/qMZ5lpU12zBdRJL2VlWbBLlqEAvXiQ3kiBigF3Wi?= =?iso-8859-1?Q?Id5U6HTa7EVG65IxFywFb0dKxwZG67ffELlzDgcetWTSQ2x1bikSAqZZ5D?= =?iso-8859-1?Q?eXzly2YDBUY6FevxG2mexRKeoLbbpAol46SDsdRZrqNr2suFs/a7FCQxgj?= =?iso-8859-1?Q?gIJbBuDU0SJYWVbA7bzLZdoBEmGYHe58KvcZ+qzQy9JSSpeneKyRrjTPU+?= =?iso-8859-1?Q?lGPnzAOu62YURKCe5U/tGFWO3Z9cq8o16epdsxQhCsXkMJLB/RfEIF3vtf?= =?iso-8859-1?Q?XhMfGtixRlcxMtdX8PyYui+Tj1v1cYA6sr9BsJidl4r03BRpldxUuL5/RU?= =?iso-8859-1?Q?9z3r9K0bdGMAnioOvUbl44JeFBbykPGO5u/JDAI0FOFxPHoU5YuGkR7ahB?= =?iso-8859-1?Q?OPVROs0D96FQH0o6t0y0nZS6KxlNjrEyfgS+R6MiR8se1cHD4swqadVqP+?= =?iso-8859-1?Q?yrJtcvUiwqPXoeD6C93F6pnGo7UThIDK5rSJJxUthysxVv7twPS1v5L3dO?= =?iso-8859-1?Q?WCzS0TdZfAAWVQTwcMaDl94KTPbr4r0EDZ9r7w31QZ4P/pInGLqgRGE/v4?= =?iso-8859-1?Q?KVag7DhS7vr7B4uGa8z1PhDqFMorzmU52s6/SEgF9ye2bc77gDTTxo3Wty?= =?iso-8859-1?Q?IziRmxkrX7ZZxg2cJWTQXcReyxxKOw76PfXpz6XKpaiBlrJnfo18vg6Qf0?= =?iso-8859-1?Q?FKQ/91xD5fWpt2ezzS3DVA8EW4CU5QGOyXR4EIPIegjuzoX1IVW6xLL/K/?= =?iso-8859-1?Q?D+FPTRdk3EJvRLVI1G3N0hEQ1lL1VocQeLI0PcLDhHVvmY46HRVAXe3j+D?= =?iso-8859-1?Q?cLoY/XsjbsncnNcA0OEPjlf3RWE9gvcnSO9ubikqajdojHExvv6zkPyYzp?= =?iso-8859-1?Q?9nvAl3oQ+q3QN/k+d1rhlDbt6Hc8ROWpm10dsHPIJvOsUcqRwhOBLT9f50?= =?iso-8859-1?Q?xvpWMQJJ00HJO12hC1zO7+7ShZnaRGt17nlPubOpUZmQIExRPpToAwtcVK?= =?iso-8859-1?Q?JuRN0IfXL4kvvanem+3ODd4u0Ws6N1/H6adutYlw9cBxlVg=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; BLUPR0401MB1489; 6:93yTQDiXtlUuT47s1CkxGy6fPmdkhr7uBkTNwRDj/5fLrRAg7HUnHdmrRv8lxZ8r9mTlgWMgCdE5K2e9bmk0PZ+UzHva1Bz2i90K/8A4LRWxj+qXgGxCKwZ2MVmh7oLuNd0sZrsbcA/9Z436muv+KIeL6YyXdhB6xCcYnP7jF60AEyqUDsVgZsdBV1xQpFfxBR1enSWN3iaXCioN9ZyIOJrh21399wrpZTbknbMsQhfxQX4DmSvSYuVjvjfvdfKFkMKUOolVBko/yZKQ8e/lfe/Ca0Iw1ubmctUM7UG5HfsSh8fvQfat3koYjeb/SEe7R/Z2Tz7y4zz5B81AJRlied4lj8VjABHq0zDCXTCMQd9UF5vk2iucr4tolJrup/2JD0oCNYazzueijBIviBHjZTTB5/BsxFVFbatqpn15k28=; 5:SnW2SHvW7xsz5aVnJI0xlSpr3tNQ+fHytLS4SOqRFWtDfTe5s6NOs+0MeXeNh9AwwSvav1GEuMmBbCnTabcQl5DZwSidZKaKhFLINt+ujfQezTI85BVVON4BNtCyAwq08VeKVgHuclzdqpj6WVNd5GQ8aZeYDGxB12B9TM+zVq8=; 24:D+uUxB59dYAMnULVRZdO0YRlDFVzYDmzvpq2pQn2gHMbQky8jBQB9X+9eTnzgFmJx/B3b3T9a7bvKH8CbjtnIIIJDO1c9eSJca3QhlknLKs= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BLUPR0401MB1489; 7:pBuH2kuitqUhDJOYtgbKlQxwDSAY+kFJb2K6gBN8zhnCRKwk6cUuY+cas76cDTc9exEmdql2ayC2davri+Ynr15Wt6QFv13WTi5CXxejVBFa5xEIXlIor4d8WvLGGPLUNFHmwvj3NYlF3B0AQH+RE4xkS1I3GywVLrxhbHL6327I9iTkmYxbAdjhGg+71QcBC8HDTA+Cnzfgj/3i9HEeti3coRD3+hpnwquNvdglQYjobujxCubj4ROf3zrnINRuqlECcxa4GGZ+ly4VX8KLwDJENGBljcla/vy5+OQyEJh21aQz8cXNAV/KP4ZYzT5WNdLVoKeto0CFN5PeqKFYOQ==; 20:FPUxCCJ9Ms3hZoGNLgP+mHdy1WpboX5PVXp4fTFUCy1LjPSDLFaw/TBlcQfJ7SYLzFxfaeSdIoIxl4VQdCSjewanvpGHBY/KRzCRcNDgg2q1MqY+9B2q/cixcr04RDtGZqWoBnna9VayaOpC+llL75qyfGm9pEoyFZUhXyXIOA8= X-OriginatorOrg: sandisk.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Mar 2017 20:08:00.6169 (UTC) X-MS-Exchange-CrossTenant-Id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=b61c8803-16f3-4c35-9b17-6f65f441df86; Ip=[74.221.232.54]; Helo=[sacsmgep14.sandisk.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0401MB1489 Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Sat, 2017-03-11 at 15:29 -0700, Jens Axboe wrote: > On 03/10/2017 12:32 AM, Jason Yan wrote: > > Fixes the following sparse warning: > > > > drivers/block/brd.c:411:15: warning: symbol 'rd_size' was not declared. > > Should it be static? > > If you do a search on this topic, you'll find others that attempted > to do the same. Arm uses it for tag parsing, for some reason, your > patch below would break it. > > It'd be great if this was fixed up for real, though. How about something like the (untested) patch below? Subject: [PATCH] arch/arm/kernel/atags_parse.c: Fix rd_size declaration Ensure that the ARM setup code treats "rd_size" as unsigned long instead of int. --- arch/arm/kernel/atags_parse.c | 3 ++- drivers/block/brd.c | 2 ++ drivers/block/brd.h | 1 + 3 files changed, 5 insertions(+), 1 deletion(-) create mode 100644 drivers/block/brd.h diff --git a/arch/arm/kernel/atags_parse.c b/arch/arm/kernel/atags_parse.c index 68c6ae0b9e4c..f18b6deaf050 100644 --- a/arch/arm/kernel/atags_parse.c +++ b/arch/arm/kernel/atags_parse.c @@ -30,6 +30,7 @@ #include #include "atags.h" +#include "../../../drivers/block/brd.h" static char default_command_line[COMMAND_LINE_SIZE] __initdata = CONFIG_CMDLINE; @@ -91,7 +92,7 @@ __tagtable(ATAG_VIDEOTEXT, parse_tag_videotext); #ifdef CONFIG_BLK_DEV_RAM static int __init parse_tag_ramdisk(const struct tag *tag) { - extern int rd_size, rd_image_start, rd_prompt, rd_doload; + extern int rd_image_start, rd_prompt, rd_doload; rd_image_start = tag->u.ramdisk.start; rd_doload = (tag->u.ramdisk.flags & 1) == 0; diff --git a/drivers/block/brd.c b/drivers/block/brd.c index 3adc32a3153b..f1f9f0338fbd 100644 --- a/drivers/block/brd.c +++ b/drivers/block/brd.c @@ -25,6 +25,8 @@ #include +#include "brd.h" + #define SECTOR_SHIFT 9 #define PAGE_SECTORS_SHIFT (PAGE_SHIFT - SECTOR_SHIFT) #define PAGE_SECTORS (1 << PAGE_SECTORS_SHIFT) diff --git a/drivers/block/brd.h b/drivers/block/brd.h new file mode 100644 index 000000000000..dbb0f92fefc8 --- /dev/null +++ b/drivers/block/brd.h @@ -0,0 +1 @@ +extern unsigned long rd_size;