| Message ID | 1491474816-15422-1-git-send-email-sagi@grimberg.me (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Stephen added the first two includes after a linux-next build failure. Did this go through a long buildbot cycle to verify it's really not needed anymore? On Thu, Apr 06, 2017 at 01:33:36PM +0300, Sagi Grimberg wrote: > Signed-off-by: Sagi Grimberg <sagi@grimberg.me> > --- > block/blk-mq-pci.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/block/blk-mq-pci.c b/block/blk-mq-pci.c > index 0c3354cf3552..70b8a6765cc7 100644 > --- a/block/blk-mq-pci.c > +++ b/block/blk-mq-pci.c > @@ -10,12 +10,9 @@ > * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for > * more details. > */ > -#include <linux/kobject.h> > -#include <linux/blkdev.h> > #include <linux/blk-mq.h> > #include <linux/blk-mq-pci.h> > #include <linux/pci.h> > -#include <linux/module.h> > > /** > * blk_mq_pci_map_queues - provide a default queue mapping for PCI device > -- > 2.7.4 ---end quoted text---
> Stephen added the first two includes after a linux-next build > failure. Did this go through a long buildbot cycle to verify > it's really not needed anymore? Umm no. I just compiled it and ran and it worked... If these are actually needed then we can safely discard this patch.
diff --git a/block/blk-mq-pci.c b/block/blk-mq-pci.c index 0c3354cf3552..70b8a6765cc7 100644 --- a/block/blk-mq-pci.c +++ b/block/blk-mq-pci.c @@ -10,12 +10,9 @@ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for * more details. */ -#include <linux/kobject.h> -#include <linux/blkdev.h> #include <linux/blk-mq.h> #include <linux/blk-mq-pci.h> #include <linux/pci.h> -#include <linux/module.h> /** * blk_mq_pci_map_queues - provide a default queue mapping for PCI device
Signed-off-by: Sagi Grimberg <sagi@grimberg.me> --- block/blk-mq-pci.c | 3 --- 1 file changed, 3 deletions(-)