From patchwork Mon Apr 10 18:51:36 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?UTF-8?q?Javier=20Gonz=C3=A1lez?= X-Patchwork-Id: 9674001 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 4F93E60244 for ; Mon, 10 Apr 2017 18:52:02 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4510E23201 for ; Mon, 10 Apr 2017 18:52:02 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 39BBF27B13; Mon, 10 Apr 2017 18:52:02 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B89D723201 for ; Mon, 10 Apr 2017 18:52:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752505AbdDJSwB (ORCPT ); Mon, 10 Apr 2017 14:52:01 -0400 Received: from mail-wm0-f51.google.com ([74.125.82.51]:36620 "EHLO mail-wm0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752114AbdDJSwA (ORCPT ); Mon, 10 Apr 2017 14:52:00 -0400 Received: by mail-wm0-f51.google.com with SMTP id o81so46299218wmb.1 for ; Mon, 10 Apr 2017 11:51:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lightnvm-io.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=AJuFQ19xNEE9WnPf8lggbMNv9uHowwEn1D40OhYEKAQ=; b=dLS8Z0yG5JIabozQbEgF5VEbZ/o/yncKh+6jmrLleRmk4dksDai8X/l+WieWHxF1MZ M2lXmL+3qPch2VhuhrLMftvh8SVj3Pkbee831K+IdDQS+4prIQrvYpgOAKSZA3ChIqlJ QXTMFhCF6DIHTEYqRDiQGKe95ltFB1BgAn5VLO/7SeM5JJcVbWRT/8uPIw+w0ErE4B1a CZJhbfZN3g0bvOr8hW/9T9b4cayMMjJlQdI6IvQmLHIAE4UU8pQHBLhC47PlK7is0Dr8 ELXsylhH2JLHhWnZOIRDrsuZWqV3tqrNz0kR83kCuqb4PhlScoZmfkVkdPHTrXSLXnLz 8MMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=AJuFQ19xNEE9WnPf8lggbMNv9uHowwEn1D40OhYEKAQ=; b=OSTPQPB7x8EkMSPgB3Hy49SR1c7iGfbJqtnyCsSE9wG1D3Vbwi1qX4J80asJaH/Fi8 /907Na+gtZzbwBURN/JUtVs9E2lfXk1sNgGbtez1WVBn5uMhk1j8DtpJq/w+mjrT8PR+ jLeFc2a6n4Q+BN2KCd/fAjfOSKcA+gBO7OtDD3Pn+klGnNym7ZO14ewHSen2OBXl2pyl 01Vrg02hNMP7XPIWjpu+Y+ViFNnn/Mk5VSSHIR6YVHHQewe6ZppMsHjFIn79V8f2I3rH gbiX7Tt37LSI1MiDB2mX1QZdrRiJtlH2VWFcaMhX8yoFGfqu21yQyW/sjQCYCajM+Nwq NV4w== X-Gm-Message-State: AN3rC/5g+oqpeSFGMdAPNpr2PL+gknFX9jsPDoyPyWNi9eXd9m6vtEfjavIHMtrZFbltrQ== X-Received: by 10.28.111.134 with SMTP id c6mr10845444wmi.128.1491850319021; Mon, 10 Apr 2017 11:51:59 -0700 (PDT) Received: from uHalley.cnexlabs.com (6164211-cl69.boa.fiberby.dk. [193.106.164.211]) by smtp.gmail.com with ESMTPSA id p38sm18495902wrb.31.2017.04.10.11.51.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 10 Apr 2017 11:51:58 -0700 (PDT) From: "=?UTF-8?q?Javier=20Gonz=C3=A1lez?=" X-Google-Original-From: =?UTF-8?q?Javier=20Gonz=C3=A1lez?= To: mb@lightnvm.io Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, =?UTF-8?q?Javier=20Gonz=C3=A1lez?= Subject: [PATCH 1/3] lightnvm: convert sprintf into snprintf Date: Mon, 10 Apr 2017 20:51:36 +0200 Message-Id: <1491850297-18235-1-git-send-email-javier@cnexlabs.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Convert sprintf calls to snprintf in order to make possible buffer overflow more obvious. Signed-off-by: Javier González --- drivers/lightnvm/core.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/lightnvm/core.c b/drivers/lightnvm/core.c index c3340ef..bdbb333 100644 --- a/drivers/lightnvm/core.c +++ b/drivers/lightnvm/core.c @@ -272,7 +272,8 @@ static int nvm_create_tgt(struct nvm_dev *dev, struct nvm_ioctl_create *create) goto err_disk; blk_queue_make_request(tqueue, tt->make_rq); - sprintf(tdisk->disk_name, "%s", create->tgtname); + snprintf(tdisk->disk_name, sizeof(tdisk->disk_name), "%s", + create->tgtname); tdisk->flags = GENHD_FL_EXT_DEVT; tdisk->major = 0; tdisk->first_minor = 0; @@ -1195,13 +1196,13 @@ static long nvm_ioctl_get_devices(struct file *file, void __user *arg) list_for_each_entry(dev, &nvm_devices, devices) { struct nvm_ioctl_device_info *info = &devices->info[i]; - sprintf(info->devname, "%s", dev->name); + snprintf(info->devname, sizeof(info->devname), "%s", dev->name); /* kept for compatibility */ info->bmversion[0] = 1; info->bmversion[1] = 0; info->bmversion[2] = 0; - sprintf(info->bmname, "%s", "gennvm"); + snprintf(info->bmname, sizeof(info->bmname), "%s", "gennvm"); i++; if (i > 31) {