From patchwork Tue Apr 11 14:18:56 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?UTF-8?q?Javier=20Gonz=C3=A1lez?= X-Patchwork-Id: 9675459 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 4F9A8600CB for ; Tue, 11 Apr 2017 14:19:38 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4574028578 for ; Tue, 11 Apr 2017 14:19:38 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3A7E528595; Tue, 11 Apr 2017 14:19:38 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E77E028578 for ; Tue, 11 Apr 2017 14:19:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753590AbdDKOTM (ORCPT ); Tue, 11 Apr 2017 10:19:12 -0400 Received: from mail-wm0-f41.google.com ([74.125.82.41]:38836 "EHLO mail-wm0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753456AbdDKOTG (ORCPT ); Tue, 11 Apr 2017 10:19:06 -0400 Received: by mail-wm0-f41.google.com with SMTP id t189so2201134wmt.1 for ; Tue, 11 Apr 2017 07:19:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lightnvm-io.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=M6FGvzyHjuzxYllCmTX2I4fOGX7HTcc/z8oePN2k5r0=; b=DlM6rhjU/tIeGrl0eQVBqBP3rXQPARvIs330ZLpYsPGhGJ97Cee0kfr0XArdc3uLsv skVJi5V532RgePAlnzk7xiotcIIjb7QC+qpV6KSPht1/6OW1i5FpL1F53JKYsYYGoHTu xCuMxzRW22lTrFMi4nVbVHk5/KL3D3cdKR5QDwXR0yfYqbcS5FCmQt/0evoj/dtDgFQk AZRLsZzfebN3cfkT4VVMvEWZ7HNrl6gLLcRnguw3BavHf6djF8yk8MSbD68EPDsE4EmM jZUfqDK0ra3y5+WWh0I0fxnQaSJT2WqSiTVHPSSyEJcgl8knpMYWZ4778JJ4xgYji9fe tAPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=M6FGvzyHjuzxYllCmTX2I4fOGX7HTcc/z8oePN2k5r0=; b=rKIgduNHoSC3EMp74JPiDKGTQGmgdeVAZ+kzn/u2mX7QOETKKHpXuSbN4VbVL4GxRy zNlRwxDygUkhLHIfvTuD7W5HOLJksZR7Z0JxQSxMetS0gjIiaIXLOYU0HLRJ+NBWda/4 wtP/3zWutKzxRrCmUMJX7FiCt3yye5GgfTzKkuim9a4lLk+d55zMLtgV9hxSFnzCgzl+ NoXHze/W/LmUVU1KiTMhN4WN3rZoGP9cHj/As8fuPIDQ/MbNq7RgusmupO0YNvGITymb X3Hq/7572a9VY2kQsAD+ost/qYHE/wSkMJAcvhQtXj6sD0m08icSi+mHVBj9sUQ2QqVX Vj1Q== X-Gm-Message-State: AN3rC/7g+6TW6S0FA4S4CocR2pO2q5OKl9E4N5BSx3/m/ZmLE5rSgui7K2Y2hv1uDDG0Bg== X-Received: by 10.28.215.147 with SMTP id o141mr13604335wmg.50.1491920345445; Tue, 11 Apr 2017 07:19:05 -0700 (PDT) Received: from uHalley.cnexlabs.com (6164211-cl69.boa.fiberby.dk. [193.106.164.211]) by smtp.gmail.com with ESMTPSA id 24sm21740288wrw.46.2017.04.11.07.19.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 11 Apr 2017 07:19:04 -0700 (PDT) From: "=?UTF-8?q?Javier=20Gonz=C3=A1lez?=" X-Google-Original-From: =?UTF-8?q?Javier=20Gonz=C3=A1lez?= To: mb@lightnvm.io Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, =?UTF-8?q?Javier=20Gonz=C3=A1lez?= Subject: [PATCH] lightnvm: convert sprintf into strlcpy Date: Tue, 11 Apr 2017 16:18:56 +0200 Message-Id: <1491920338-2348-3-git-send-email-javier@cnexlabs.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1491920338-2348-1-git-send-email-javier@cnexlabs.com> References: <1491920338-2348-1-git-send-email-javier@cnexlabs.com> MIME-Version: 1.0 Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Convert sprintf calls to strlcpy in order to make possible buffer overflow more obvious. Signed-off-by: Javier González --- drivers/lightnvm/core.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/lightnvm/core.c b/drivers/lightnvm/core.c index 258007a..2c26af3 100644 --- a/drivers/lightnvm/core.c +++ b/drivers/lightnvm/core.c @@ -273,7 +273,7 @@ static int nvm_create_tgt(struct nvm_dev *dev, struct nvm_ioctl_create *create) goto err_disk; blk_queue_make_request(tqueue, tt->make_rq); - sprintf(tdisk->disk_name, "%s", create->tgtname); + strlcpy(tdisk->disk_name, create->tgtname, sizeof(tdisk->disk_name)); tdisk->flags = GENHD_FL_EXT_DEVT; tdisk->major = 0; tdisk->first_minor = 0; @@ -1198,13 +1198,13 @@ static long nvm_ioctl_get_devices(struct file *file, void __user *arg) list_for_each_entry(dev, &nvm_devices, devices) { struct nvm_ioctl_device_info *info = &devices->info[i]; - sprintf(info->devname, "%s", dev->name); + strlcpy(info->devname, dev->name, sizeof(info->devname)); /* kept for compatibility */ info->bmversion[0] = 1; info->bmversion[1] = 0; info->bmversion[2] = 0; - sprintf(info->bmname, "%s", "gennvm"); + strlcpy(info->bmname, "gennvm", sizeof(info->bmname)); i++; if (i > 31) {