From patchwork Tue Apr 11 14:18:57 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?UTF-8?q?Javier=20Gonz=C3=A1lez?= X-Patchwork-Id: 9675461 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 339CB600CB for ; Tue, 11 Apr 2017 14:20:04 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1A97B28601 for ; Tue, 11 Apr 2017 14:20:04 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1910B285ED; Tue, 11 Apr 2017 14:20:04 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5EFED285D9 for ; Tue, 11 Apr 2017 14:20:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753537AbdDKOTK (ORCPT ); Tue, 11 Apr 2017 10:19:10 -0400 Received: from mail-wm0-f42.google.com ([74.125.82.42]:35451 "EHLO mail-wm0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751816AbdDKOTH (ORCPT ); Tue, 11 Apr 2017 10:19:07 -0400 Received: by mail-wm0-f42.google.com with SMTP id w64so65050439wma.0 for ; Tue, 11 Apr 2017 07:19:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lightnvm-io.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=LsAO2DUBto12mKptfH5SvQXpcpuXdWtJKuxkFNYw0dQ=; b=PpTFIFfMqrcaR14AoNlvl5XppUtLMaGyz9vrqLQvQ2ubqUEa3tSGhHTwIAzim1sv6S WWewAEV22LNqUYXF7+6n/l0cGyA+VtSFA291V6It3yE7W4yZq/VazDV3euoFM3//MNne 1kpAqa7l4WseAWy4+/78ZQu6ubED3mrrYaHuNBB5Ci17bJT4vwcPFCyD8MgQt9rMrIu5 5r8mSA//Z2HDRoSj3Ga7xbDxFpmQc4883Viaa0qsM4c2ONIjPCT9zjuptQ1ubZPxZE13 wOZquZ8Yo20QB9HRuUDx1dbEieyrZ/M0Lm/YT2E2CtQABnefhX273Q+2w/MpzBmxsNDZ vbVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=LsAO2DUBto12mKptfH5SvQXpcpuXdWtJKuxkFNYw0dQ=; b=dKJ3RTCycYMD3w9/ZIdRoxMyYXBOmy5Cct0o7iXhQSzPzLQcQ7/c7pNS0/J/stcoQl SjexACwYzaC0xMYsxrHMOS1+gdFBx73UuyzF8WdlVLmg8IOpdWCPhKcOBhO2OdyT4mEK jzo9fBj6EcRu7K6LEfASPGKba1iNrzBV3D6oPAA3+Bx07hk8ZhydrPNyfYvMONjZx0Qd Y7DTUdFcjkqek5VOX1wdKPHbQIBv/9VWZCSZrCjcDahC4FcExvb5ufZ6AsS5R+cFWWtY tc+F0sezR7i2IUGi+TyZbeY/0Bg6B3HEGHBlTY88yGFRf8hAodedXr64F/LQjdlqSCdv +ZSA== X-Gm-Message-State: AN3rC/7Lw/jsnmpLuziLUYuZVnXpVLGX+DqRw+Y98R4nHC/xRizopwdNEltZPCeefJEQfw== X-Received: by 10.28.182.134 with SMTP id g128mr3050170wmf.22.1491920346298; Tue, 11 Apr 2017 07:19:06 -0700 (PDT) Received: from uHalley.cnexlabs.com (6164211-cl69.boa.fiberby.dk. [193.106.164.211]) by smtp.gmail.com with ESMTPSA id 24sm21740288wrw.46.2017.04.11.07.19.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 11 Apr 2017 07:19:05 -0700 (PDT) From: "=?UTF-8?q?Javier=20Gonz=C3=A1lez?=" X-Google-Original-From: =?UTF-8?q?Javier=20Gonz=C3=A1lez?= To: mb@lightnvm.io Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, =?UTF-8?q?Javier=20Gonz=C3=A1lez?= Subject: [PATCH 2/3] lightnvm: fix type checks on rrpc Date: Tue, 11 Apr 2017 16:18:57 +0200 Message-Id: <1491920338-2348-4-git-send-email-javier@cnexlabs.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1491920338-2348-1-git-send-email-javier@cnexlabs.com> References: <1491920338-2348-1-git-send-email-javier@cnexlabs.com> MIME-Version: 1.0 Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP sector_t is always unsigned, therefore avoid < 0 checks on it. Signed-off-by: Javier González --- drivers/lightnvm/rrpc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/lightnvm/rrpc.c b/drivers/lightnvm/rrpc.c index 5dba544..cf0e28a 100644 --- a/drivers/lightnvm/rrpc.c +++ b/drivers/lightnvm/rrpc.c @@ -817,7 +817,7 @@ static int rrpc_read_ppalist_rq(struct rrpc *rrpc, struct bio *bio, for (i = 0; i < npages; i++) { /* We assume that mapping occurs at 4KB granularity */ - BUG_ON(!(laddr + i >= 0 && laddr + i < rrpc->nr_sects)); + BUG_ON(!(laddr + i < rrpc->nr_sects)); gp = &rrpc->trans_map[laddr + i]; if (gp->rblk) { @@ -846,7 +846,7 @@ static int rrpc_read_rq(struct rrpc *rrpc, struct bio *bio, struct nvm_rq *rqd, if (!is_gc && rrpc_lock_rq(rrpc, bio, rqd)) return NVM_IO_REQUEUE; - BUG_ON(!(laddr >= 0 && laddr < rrpc->nr_sects)); + BUG_ON(!(laddr < rrpc->nr_sects)); gp = &rrpc->trans_map[laddr]; if (gp->rblk) {