From patchwork Tue Apr 11 14:18:58 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?UTF-8?q?Javier=20Gonz=C3=A1lez?= X-Patchwork-Id: 9675469 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 0AA88600CB for ; Tue, 11 Apr 2017 14:21:15 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 003312856B for ; Tue, 11 Apr 2017 14:21:15 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E953B285A5; Tue, 11 Apr 2017 14:21:14 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.4 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 86539285AA for ; Tue, 11 Apr 2017 14:21:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753213AbdDKOUE (ORCPT ); Tue, 11 Apr 2017 10:20:04 -0400 Received: from mail-wm0-f47.google.com ([74.125.82.47]:37232 "EHLO mail-wm0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753484AbdDKOTI (ORCPT ); Tue, 11 Apr 2017 10:19:08 -0400 Received: by mail-wm0-f47.google.com with SMTP id u2so2022547wmu.0 for ; Tue, 11 Apr 2017 07:19:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lightnvm-io.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=M6FGvzyHjuzxYllCmTX2I4fOGX7HTcc/z8oePN2k5r0=; b=SxepjnBj8R8eHgG8w2brMF6X6mIOKLAuegscAySHn0pQd84ETt4mFCVds8tGFLrXZ5 hWMB1yf8ETevLbzh6OD5kn9i5+C8+fMCKkeeOjJ0zNEnj76OUDRyg1M140q9q6ryBfsD oIfuFLYJgXDJe0HXbGECPz+PepA0tQJILaR/14NjAkqxKp0KnsYtcl1FtaocMbyOAXUo pf8HkA98LF+nfj8+wF2+ZV3evk5mau5yfjlCX8D7LZeAnOTt/8HCdE+ZG9l9Dt1JCbUi T84Bjb5+AQLMNYzU9+eoQxIpC4cvcKqYyH4l8DN0ipttOrkFUgUuL8VMehRopIHDgdvG Rf5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=M6FGvzyHjuzxYllCmTX2I4fOGX7HTcc/z8oePN2k5r0=; b=igeceNOcQ9AIjKWHiuoDfvv5DQZbdxo/WrP0+X/Zjwst4dIhyn5D06BHndJRDS1XPp RgasvVTxuM/RP81/THv+ke0hBsvLuOtaXvBG1cIIg3+/q4Jvj40+D4kaSxFWnRK3Ga2g j1nQJzz0kxf5aQ+BzFQir1Z4IUOh5dlcqquZHI/k35l6aZFobHMM3S3/gPGMNZUbjG/v lGwnYJzo7QfwbhEMUoCmKbJEuvZXYjEuZ0YMZfrB1ZP0YsSmJVeEmdyPCn5+PIj29+hW sJ/Tnl2RIH4kMWWm7dxnVITu9SCgJkhZ42ZeDmun7av8Px7PpUdFMjYWAeBhfsX9zeZn mIZA== X-Gm-Message-State: AN3rC/7UxUSmkFIIfu8h/rcjinkcMjw3LNvX/NxnvCOStj6fEPP6v26SILVcmaqv8/S37A== X-Received: by 10.28.74.70 with SMTP id x67mr2763419wma.137.1491920347190; Tue, 11 Apr 2017 07:19:07 -0700 (PDT) Received: from uHalley.cnexlabs.com (6164211-cl69.boa.fiberby.dk. [193.106.164.211]) by smtp.gmail.com with ESMTPSA id 24sm21740288wrw.46.2017.04.11.07.19.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 11 Apr 2017 07:19:06 -0700 (PDT) From: "=?UTF-8?q?Javier=20Gonz=C3=A1lez?=" X-Google-Original-From: =?UTF-8?q?Javier=20Gonz=C3=A1lez?= To: mb@lightnvm.io Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, =?UTF-8?q?Javier=20Gonz=C3=A1lez?= Subject: [PATCH 3/3] lightnvm: convert sprintf into strlcpy Date: Tue, 11 Apr 2017 16:18:58 +0200 Message-Id: <1491920338-2348-5-git-send-email-javier@cnexlabs.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1491920338-2348-1-git-send-email-javier@cnexlabs.com> References: <1491920338-2348-1-git-send-email-javier@cnexlabs.com> MIME-Version: 1.0 Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Convert sprintf calls to strlcpy in order to make possible buffer overflow more obvious. Signed-off-by: Javier González --- drivers/lightnvm/core.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/lightnvm/core.c b/drivers/lightnvm/core.c index 258007a..2c26af3 100644 --- a/drivers/lightnvm/core.c +++ b/drivers/lightnvm/core.c @@ -273,7 +273,7 @@ static int nvm_create_tgt(struct nvm_dev *dev, struct nvm_ioctl_create *create) goto err_disk; blk_queue_make_request(tqueue, tt->make_rq); - sprintf(tdisk->disk_name, "%s", create->tgtname); + strlcpy(tdisk->disk_name, create->tgtname, sizeof(tdisk->disk_name)); tdisk->flags = GENHD_FL_EXT_DEVT; tdisk->major = 0; tdisk->first_minor = 0; @@ -1198,13 +1198,13 @@ static long nvm_ioctl_get_devices(struct file *file, void __user *arg) list_for_each_entry(dev, &nvm_devices, devices) { struct nvm_ioctl_device_info *info = &devices->info[i]; - sprintf(info->devname, "%s", dev->name); + strlcpy(info->devname, dev->name, sizeof(info->devname)); /* kept for compatibility */ info->bmversion[0] = 1; info->bmversion[1] = 0; info->bmversion[2] = 0; - sprintf(info->bmname, "%s", "gennvm"); + strlcpy(info->bmname, "gennvm", sizeof(info->bmname)); i++; if (i > 31) {