From patchwork Fri Apr 21 23:32:46 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?UTF-8?q?Javier=20Gonz=C3=A1lez?= X-Patchwork-Id: 9693963 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 80FE76038E for ; Fri, 21 Apr 2017 23:34:13 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7357D28680 for ; Fri, 21 Apr 2017 23:34:13 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 67E4628685; Fri, 21 Apr 2017 23:34:13 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.4 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 886B828689 for ; Fri, 21 Apr 2017 23:34:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1426709AbdDUXeA (ORCPT ); Fri, 21 Apr 2017 19:34:00 -0400 Received: from mail-wm0-f45.google.com ([74.125.82.45]:35324 "EHLO mail-wm0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1426668AbdDUXdD (ORCPT ); Fri, 21 Apr 2017 19:33:03 -0400 Received: by mail-wm0-f45.google.com with SMTP id w64so25874584wma.0 for ; Fri, 21 Apr 2017 16:33:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lightnvm-io.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=exLqjhrQzdWhT25H2Xn7oW6ve4+U+LHmV67OIXdZ+Is=; b=TRWrWq7rQ2AiZ3P92rCBFFlRl5l7oZvJ4mZbsT/rKqDW9L4+IryRoW4lohRymVcNW9 XGLOeN14J11f4qbIituDbkQU0FgH2nFLeOKc4dYCD+zbuVTYLReCotJpCv4TznPhQ+hG JbYt6qk7kJPEOhlfPyBhx/9XgIlSGXuj02XW7yBYjQgVgN3cTCGi5Xh7JgZF90ZSjL9e jY6GbgGq1Rc3Cj9ZFZ7TjtTgFOsCDExIoDnZgVAz1QhxSyhSJB/obUCRTV81rfrFMLyE MKoXYi3ddNa6xKah4R47EX/j77txODYF13qnKb06BQFUIHkPYXKlLqEToDPDE+CYrhPm 4vkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=exLqjhrQzdWhT25H2Xn7oW6ve4+U+LHmV67OIXdZ+Is=; b=nAu/RQg6NsIwRhTOl66quRGkwEICjFXySiIIrS6lZrSUB9SlOonT2cfcRaK16tuFBG Ylf6pbwvYw3oR17UXPmHr55HCuTI9tThpY97DeaPstfem7yIZvI5QDI1XS/Y4w7WfS6T RVgn5gfaPj/D5O3SS7nWznJ4GCiyIMkwapXqJKqapTSrkUPZT/2Jqc4ieG3aWxgbZVLd 2Tn7hEK0fynpElzMpH4jYIFbZjX0U5/fRRtlUF5QYEEBMuc/2gOcB1hUUlKv3bWkwlyQ gKQNdSPxGuKFVn1RL/Cyhznn7b2gRBPXCfqAxtu9Yt0SZLMZ92LdsC4DYfoaWl+/KrKd RY+g== X-Gm-Message-State: AN3rC/7LFPbsHYZ9Rv2iJ2XR/wk5ASNcUYJ0PZ34xgoIOhABp+iwEUvq P9tgFpZz/Rc7ig== X-Received: by 10.80.148.186 with SMTP id s55mr76820eda.65.1492817581795; Fri, 21 Apr 2017 16:33:01 -0700 (PDT) Received: from uHalley.cnexlabs.com (6164211-cl69.boa.fiberby.dk. [193.106.164.211]) by smtp.gmail.com with ESMTPSA id x2sm816935edb.49.2017.04.21.16.33.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 21 Apr 2017 16:33:01 -0700 (PDT) From: "=?UTF-8?q?Javier=20Gonz=C3=A1lez?=" X-Google-Original-From: =?UTF-8?q?Javier=20Gonz=C3=A1lez?= To: mb@lightnvm.io Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, =?UTF-8?q?Javier=20Gonz=C3=A1lez?= Subject: [PATCH 2/5] lightnvm: pblk: fix bad error check Date: Sat, 22 Apr 2017 01:32:46 +0200 Message-Id: <1492817569-13532-3-git-send-email-javier@cnexlabs.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1492817569-13532-1-git-send-email-javier@cnexlabs.com> References: <1492817569-13532-1-git-send-email-javier@cnexlabs.com> MIME-Version: 1.0 Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Fix bad error check Fixes: a4bd217b4326 "lightnvm: physical block device (pblk) target" Signed-off-by: Javier González Reviewed-by: Matias Bjørling --- drivers/lightnvm/pblk-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/lightnvm/pblk-core.c b/drivers/lightnvm/pblk-core.c index 7065658..7eb62ec 100644 --- a/drivers/lightnvm/pblk-core.c +++ b/drivers/lightnvm/pblk-core.c @@ -1273,7 +1273,7 @@ struct pblk_line *pblk_line_replace_data(struct pblk *pblk) retry_setup: if (!pblk_line_set_metadata(pblk, new, cur)) { new = pblk_line_retry(pblk, new); - if (new) + if (!new) return NULL; goto retry_setup;