From patchwork Wed Jun 14 04:01:50 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jens Axboe X-Patchwork-Id: 9785273 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 1C5DF60325 for ; Wed, 14 Jun 2017 04:02:10 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2506B283BD for ; Wed, 14 Jun 2017 04:02:10 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 19C4D28589; Wed, 14 Jun 2017 04:02:10 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AC97D283BD for ; Wed, 14 Jun 2017 04:02:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750737AbdFNECI (ORCPT ); Wed, 14 Jun 2017 00:02:08 -0400 Received: from mail-pf0-f181.google.com ([209.85.192.181]:36274 "EHLO mail-pf0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750714AbdFNECG (ORCPT ); Wed, 14 Jun 2017 00:02:06 -0400 Received: by mail-pf0-f181.google.com with SMTP id x63so77508085pff.3 for ; Tue, 13 Jun 2017 21:02:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=xtPUIwpZhtvy/hbwZsfEjFvz9wUJQv0NT3Qcea1Gv6c=; b=uynxykCJFMPtIP7d6I/L6oGU/M75p4VyoDI0zlQ0qCRO9E1yJL5WFpmsR7w+tHGsmo BNraivK5Ec/OXL7Db+VbhJ4w/WxX2LYQ5OPOpGfqHQD/EjUGRCGbTF8VfQbSBPx9Qh7V hxQCWmDkxHxPoQOuzmFhxlXrJ6nC2m2DBvIcyVfWRpjzMIOpQalqhQXCwS6qB6i9XY9p +DNyG5dpK635stswpbXe5iXyXnn684VVVz5UWRRRmC1wpw9famACf0YanGv3WhnPiZzw LtzYCweBZOU6EPiTchp0dDPNZdESVVsgExUVEc+jsI9p/aXtP7hHFOpCGRGfMaIx1d4z WTDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=xtPUIwpZhtvy/hbwZsfEjFvz9wUJQv0NT3Qcea1Gv6c=; b=a3SUJXrtbXfQTtfDkDzg0PDPrBcrE6S1W49L4bEEXOM7vfhkuo1ksysthH3WG23Wu3 9Vt29BJvKtj27SwiDprIbNN2DwxwH8ptANSNfMBRMeYYCpPnfKZxNwnA8BbgPfP8gaq7 nxLfzvp++yLNhOSM69D1pNR4/HnSj18aALIYNxk9P/TOlpgVvSCjTuN7KwGo6gvKSox7 iL7x5cPwSK5+BgVKwcyU9Umqlps9Z1NOkaBB6e2DAVw0IcnGsjJ/TQWetKxllDEVDTIR HlB7OpCUIGIPA/wY0Zq26MrgDHNkeVH+QtaBoXEQsshhMhPaqP3gbytLWwSW3UcqeXZs anQA== X-Gm-Message-State: AKS2vOwcRnOi4EX02MaeUcrcp3XPxCYvV5gzScBnZnmshkEwq/6j8XDe LaKx8fiekLjfgezp X-Received: by 10.99.138.199 with SMTP id y190mr2437186pgd.187.1497412925357; Tue, 13 Jun 2017 21:02:05 -0700 (PDT) Received: from localhost.localdomain (66.29.164.166.static.utbb.net. [66.29.164.166]) by smtp.gmail.com with ESMTPSA id f8sm30914083pfc.14.2017.06.13.21.02.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 13 Jun 2017 21:02:04 -0700 (PDT) From: Jens Axboe To: linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org Cc: adilger@dilger.ca, Jens Axboe Subject: [PATCH 01/10] block: add support for carrying stream information in a bio Date: Tue, 13 Jun 2017 22:01:50 -0600 Message-Id: <1497412919-19400-2-git-send-email-axboe@kernel.dk> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1497412919-19400-1-git-send-email-axboe@kernel.dk> References: <1497412919-19400-1-git-send-email-axboe@kernel.dk> Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP No functional changes in this patch, but it allows each bio to carry a stream ID and disallows merging of bio's with different stream IDs. Signed-off-by: Jens Axboe --- block/bio.c | 2 ++ block/blk-merge.c | 14 ++++++++++++++ include/linux/blk_types.h | 17 +++++++++++++++++ 3 files changed, 33 insertions(+) diff --git a/block/bio.c b/block/bio.c index 888e7801c638..77f4be1f7428 100644 --- a/block/bio.c +++ b/block/bio.c @@ -595,6 +595,7 @@ void __bio_clone_fast(struct bio *bio, struct bio *bio_src) bio->bi_opf = bio_src->bi_opf; bio->bi_iter = bio_src->bi_iter; bio->bi_io_vec = bio_src->bi_io_vec; + bio->bi_stream = bio_src->bi_stream; bio_clone_blkcg_association(bio, bio_src); } @@ -678,6 +679,7 @@ struct bio *bio_clone_bioset(struct bio *bio_src, gfp_t gfp_mask, bio->bi_opf = bio_src->bi_opf; bio->bi_iter.bi_sector = bio_src->bi_iter.bi_sector; bio->bi_iter.bi_size = bio_src->bi_iter.bi_size; + bio->bi_stream = bio_src->bi_stream; switch (bio_op(bio)) { case REQ_OP_DISCARD: diff --git a/block/blk-merge.c b/block/blk-merge.c index 3990ae406341..28998acdd675 100644 --- a/block/blk-merge.c +++ b/block/blk-merge.c @@ -693,6 +693,13 @@ static struct request *attempt_merge(struct request_queue *q, return NULL; /* + * Don't allow merge of different streams, or for a stream with + * non-stream IO. + */ + if (req->bio->bi_stream != next->bio->bi_stream) + return NULL; + + /* * If we are allowed to merge, then append bio list * from next to rq and release next. merge_requests_fn * will have updated segment counts, update sector @@ -811,6 +818,13 @@ bool blk_rq_merge_ok(struct request *rq, struct bio *bio) !blk_write_same_mergeable(rq->bio, bio)) return false; + /* + * Don't allow merge of different streams, or for a stream with + * non-stream IO. + */ + if (rq->bio->bi_stream != bio->bi_stream) + return false; + return true; } diff --git a/include/linux/blk_types.h b/include/linux/blk_types.h index 61339bc44400..1940876a7fa7 100644 --- a/include/linux/blk_types.h +++ b/include/linux/blk_types.h @@ -36,6 +36,8 @@ struct bio { unsigned short bi_flags; /* status, etc and bvec pool number */ unsigned short bi_ioprio; + unsigned int bi_stream; /* write life time hint */ + struct bvec_iter bi_iter; /* Number of segments in this BIO after @@ -312,4 +314,19 @@ struct blk_rq_stat { u64 batch; }; +static inline void bio_set_streamid(struct bio *bio, unsigned int stream) +{ + bio->bi_stream = stream; +} + +static inline bool bio_stream_valid(struct bio *bio) +{ + return bio->bi_stream != 0; +} + +static inline unsigned int bio_stream(struct bio *bio) +{ + return bio->bi_stream; +} + #endif /* __LINUX_BLK_TYPES_H */