From patchwork Mon Jun 26 09:57:18 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?UTF-8?q?Javier=20Gonz=C3=A1lez?= X-Patchwork-Id: 9809007 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 58F1D60329 for ; Mon, 26 Jun 2017 09:58:46 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5FD762847B for ; Mon, 26 Jun 2017 09:58:46 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 54B5D2847D; Mon, 26 Jun 2017 09:58:46 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C6CA52847B for ; Mon, 26 Jun 2017 09:58:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752037AbdFZJ6o (ORCPT ); Mon, 26 Jun 2017 05:58:44 -0400 Received: from mail-wm0-f53.google.com ([74.125.82.53]:35692 "EHLO mail-wm0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751704AbdFZJ6U (ORCPT ); Mon, 26 Jun 2017 05:58:20 -0400 Received: by mail-wm0-f53.google.com with SMTP id w126so2845662wme.0 for ; Mon, 26 Jun 2017 02:58:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lightnvm-io.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=VKqAKz+OdamxdCcis2CuFmlqmEW13hW7SnxhEtAUEjA=; b=d6iQ4UE8K379Ln5NdP9flhtGp7UrZ29NJsakUbtSwRJtzA0yv+xLqK8rwE4HNMkqjC 1T0gtb1z9NfcqXNGm0RGdRV5Y26l8eZdv72qqXtx5MyOaUfxKTzC8E/vymRze6qIk6IZ VPlThpxjfgZZK5aU6mKCdiRSX8pMvhEbkClqlygCWZXf3zi5PrQJoUsDCiaz6bxkHKkS iWCCDGhbTXzL74pfEDT16KGLpCl33BTkGi7mFjy6GJhU0H2tE3fZpuTfERUvt499dmPL aC7Oe6f+Fsd3La5ujJotKFiSJ6z0nR39ThmESaToQebWVPZ68/kCqRLmSk2JSgtSvnRz /+Dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=VKqAKz+OdamxdCcis2CuFmlqmEW13hW7SnxhEtAUEjA=; b=QNKD40b5shZhag5nAEBAPHq+dM5Lrn+G0fLRI4yW8uphGrL2Ppt+Aqt6eybc8olxkE txBVSucWLlh+GtdFpRE9fOGQomZ4RmBCxZL6aNPi9YngoB7mIEQg3yYLo6Yzqq9qDPJI Lazr6+VqfWcx45GIVJ6i5qPPFucmp/YEIGMLAxUUbg6SUCqAopdXnJzqvdi/NWkYghPF d5beEvQz2a/ZzI33pLd3XhDDAkEayfpSpmJzLJU/R79OfiE6ZTHjMUEM/fziaCrYt6ty Dl//C9SJUJ6oG2WEFyq0R7N+5Jz6dFVKeJT+LioU7lR+qWu5KeRBf8ZlMaS8size2ZJD vzqQ== X-Gm-Message-State: AKS2vOzL4IDFQLFZJ1Svvle4bUAHnmGFGUiQ4hcQYMuSKw8GfboUZCxo 6IzpLjrAoS1SIVwu X-Received: by 10.80.171.28 with SMTP id s28mr15739041edc.146.1498471098139; Mon, 26 Jun 2017 02:58:18 -0700 (PDT) Received: from uHalley.cnexlabs.com (6164211-cl69.boa.fiberby.dk. [193.106.164.211]) by smtp.gmail.com with ESMTPSA id n26sm5212537edd.51.2017.06.26.02.58.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 26 Jun 2017 02:58:17 -0700 (PDT) From: "=?UTF-8?q?Javier=20Gonz=C3=A1lez?=" X-Google-Original-From: =?UTF-8?q?Javier=20Gonz=C3=A1lez?= To: mb@lightnvm.io, axboe@fb.com Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, =?UTF-8?q?Javier=20Gonz=C3=A1lez?= , =?UTF-8?q?Matias=20Bj=C3=B8rling?= Subject: [PATCH 09/20] lightnvm: pblk: delete redundant debug line stat Date: Mon, 26 Jun 2017 11:57:18 +0200 Message-Id: <1498471049-25505-10-git-send-email-javier@cnexlabs.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1498471049-25505-1-git-send-email-javier@cnexlabs.com> References: <1498471049-25505-1-git-send-email-javier@cnexlabs.com> MIME-Version: 1.0 Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Remove a legacy variable that helped verifying the consistency of the run-time metadata for the free line list. With the new metadata layout, this check is no longer necessary. Signed-off-by: Javier González Signed-off-by: Matias Bjørling --- drivers/lightnvm/pblk-sysfs.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/lightnvm/pblk-sysfs.c b/drivers/lightnvm/pblk-sysfs.c index 707d1b91bde6..3d9a77646a3d 100644 --- a/drivers/lightnvm/pblk-sysfs.c +++ b/drivers/lightnvm/pblk-sysfs.c @@ -153,7 +153,7 @@ static ssize_t pblk_sysfs_lines(struct pblk *pblk, char *page) int free_line_cnt = 0, closed_line_cnt = 0, emeta_line_cnt = 0; int d_line_cnt = 0, l_line_cnt = 0; int gc_full = 0, gc_high = 0, gc_mid = 0, gc_low = 0, gc_empty = 0; - int free = 0, bad = 0, cor = 0; + int bad = 0, cor = 0; int msecs = 0, ssecs = 0, cur_sec = 0, vsc = 0, sec_in_line = 0; int map_weight = 0, meta_weight = 0; @@ -217,8 +217,6 @@ static ssize_t pblk_sysfs_lines(struct pblk *pblk, char *page) gc_empty++; } - list_for_each_entry(line, &l_mg->free_list, list) - free++; list_for_each_entry(line, &l_mg->bad_list, list) bad++; list_for_each_entry(line, &l_mg->corrupt_list, list) @@ -247,9 +245,9 @@ static ssize_t pblk_sysfs_lines(struct pblk *pblk, char *page) geo->nr_luns, lm->blk_per_line, lm->sec_per_line); sz += snprintf(page + sz, PAGE_SIZE - sz, - "lines:d:%d,l:%d-f:%d(%d),m:%d,c:%d,b:%d,co:%d(d:%d,l:%d)t:%d\n", + "lines:d:%d,l:%d-f:%d,m:%d,c:%d,b:%d,co:%d(d:%d,l:%d)t:%d\n", cur_data, cur_log, - free, nr_free_lines, emeta_line_cnt, + nr_free_lines, emeta_line_cnt, closed_line_cnt, bad, cor, d_line_cnt, l_line_cnt,