From patchwork Fri Jun 30 15:56:43 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?UTF-8?q?Javier=20Gonz=C3=A1lez?= X-Patchwork-Id: 9819917 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 24CDA602B1 for ; Fri, 30 Jun 2017 15:57:19 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 42CDE28526 for ; Fri, 30 Jun 2017 15:57:16 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 379FF286AC; Fri, 30 Jun 2017 15:57:16 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.4 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DE86028526 for ; Fri, 30 Jun 2017 15:57:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752134AbdF3P5N (ORCPT ); Fri, 30 Jun 2017 11:57:13 -0400 Received: from mail-wm0-f50.google.com ([74.125.82.50]:35909 "EHLO mail-wm0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752055AbdF3P5H (ORCPT ); Fri, 30 Jun 2017 11:57:07 -0400 Received: by mail-wm0-f50.google.com with SMTP id 62so114237531wmw.1 for ; Fri, 30 Jun 2017 08:57:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lightnvm-io.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=XeDJRpFkccEqs7Mtg4+GMFSVoed6WCjmPLLFVgF44AU=; b=UJpLmjYEDgson2m17SaH/Dhy3qTNXAaRZ8YZWGhrgaqHpH+JuxL3HfmS7revHA/yGd Qvnj3/nN3y7dZj1Yws4kP6Zmk9bn2k7AMGjdmZPeo4xFmcnEPIliXeALyviUUTZUhaTe ILmN0s8o6bLrAL9XyYGqCzXMygeEIC+SP9xoqnC99hxjCw+YjVJrI7nmUWa1rWxZ/dVi AyTD/E8/Z9LvrR/ezu+6j5Vs7MUBPr8GKzNJqSm34oCJkvVq4oWUzbiAJM9vPexocRgB 0QSLdYvtbzT0W6d/nzp+SH0SvSvGrsvEGmUqX+dnRESm8v9Ns6rjrwOLUGlVtfMmgRq/ gSTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=XeDJRpFkccEqs7Mtg4+GMFSVoed6WCjmPLLFVgF44AU=; b=ZcikxkzaMKRjaORniOmuAYCY6ls9W5nQ8GhFZqspI9xgFeI5rBNAw2qYAaWPdrkX0+ 4CxZ+jjhgQW8vx0JO8pW7U0a2yPQX4zU2Qqd9xSdrVIeHe67nGrXsu9krkP1+0aydYv/ r7hygH8GdM3+lJqPthLg6cqTq5IkadEfuj5I5fuR28xJz6RYdGbLTuEpUfhRLtuURYWA KU1/azjjsu123Brb7uU9Gim6TdRgwwWA6y4Pw3knlAOZAvCB0Cpt/FqkV4D6fvkPZOlZ vpa8EhAxuGLZ7+dvpmK+guNmkXb49/JRyVuZ8u8xSx1upWsuW6iBN5zWrz8VIt8K5zMT nw4g== X-Gm-Message-State: AKS2vOxKnQc8fjJpvlhMT0kq52EwXEKq+pcH35Fa/dlcBkOTGnXECBtR ILMAnLCLADmXWogcdz0= X-Received: by 10.80.132.225 with SMTP id 88mr5784878edq.80.1498838221189; Fri, 30 Jun 2017 08:57:01 -0700 (PDT) Received: from uHalley.cnexlabs.com (6164211-cl69.boa.fiberby.dk. [193.106.164.211]) by smtp.gmail.com with ESMTPSA id d36sm2705988edb.63.2017.06.30.08.57.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 30 Jun 2017 08:57:00 -0700 (PDT) From: "=?UTF-8?q?Javier=20Gonz=C3=A1lez?=" X-Google-Original-From: =?UTF-8?q?Javier=20Gonz=C3=A1lez?= To: mb@lightnvm.io, axboe@fb.com Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, =?UTF-8?q?Javier=20Gonz=C3=A1lez?= , =?UTF-8?q?Matias=20Bj=C3=B8rling?= Subject: [PATCH 10/10] lightnvm: pblk: set line bitmap check under debug Date: Fri, 30 Jun 2017 17:56:43 +0200 Message-Id: <1498838203-21539-11-git-send-email-javier@cnexlabs.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1498838203-21539-1-git-send-email-javier@cnexlabs.com> References: <1498838203-21539-1-git-send-email-javier@cnexlabs.com> MIME-Version: 1.0 Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Do bitmap checks only when debug mode is enable. The line bitmap used for mapping to physical addresses is fairly large (~512KB) and it is expensive to do this checks on the fast path. Signed-off-by: Javier González Signed-off-by: Matias Bjørling --- drivers/lightnvm/pblk-core.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/lightnvm/pblk-core.c b/drivers/lightnvm/pblk-core.c index e6f42cddc8ec..11fe0c5b2a9c 100644 --- a/drivers/lightnvm/pblk-core.c +++ b/drivers/lightnvm/pblk-core.c @@ -1561,11 +1561,14 @@ static void pblk_line_should_sync_meta(struct pblk *pblk) void pblk_line_close(struct pblk *pblk, struct pblk_line *line) { struct pblk_line_mgmt *l_mg = &pblk->l_mg; - struct pblk_line_meta *lm = &pblk->lm; struct list_head *move_list; +#ifdef CONFIG_NVM_DEBUG + struct pblk_line_meta *lm = &pblk->lm; + WARN(!bitmap_full(line->map_bitmap, lm->sec_per_line), "pblk: corrupt closed line %d\n", line->id); +#endif spin_lock(&l_mg->free_lock); WARN_ON(!test_and_clear_bit(line->meta_line, &l_mg->meta_bitmap));