From patchwork Fri Jun 30 15:56:37 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?UTF-8?q?Javier=20Gonz=C3=A1lez?= X-Patchwork-Id: 9819899 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 56B17602B1 for ; Fri, 30 Jun 2017 15:57:03 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CC36928526 for ; Fri, 30 Jun 2017 15:57:01 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C0E06286AC; Fri, 30 Jun 2017 15:57:01 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.4 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 54590285C8 for ; Fri, 30 Jun 2017 15:57:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752458AbdF3P45 (ORCPT ); Fri, 30 Jun 2017 11:56:57 -0400 Received: from mail-wm0-f48.google.com ([74.125.82.48]:38514 "EHLO mail-wm0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752454AbdF3P44 (ORCPT ); Fri, 30 Jun 2017 11:56:56 -0400 Received: by mail-wm0-f48.google.com with SMTP id b184so50445547wme.1 for ; Fri, 30 Jun 2017 08:56:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lightnvm-io.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=kjNHNnwgUITt6jgNEbjkpSHkXX3K2XR8ypW6WPwBAt8=; b=GcDtbk38pF42SMzZti840R+zHTTt4CGutAzO9oXkyPkHBXGLLtUkZb9QQqmw9VVySs d1yZi2gkF/oReIhm8mLK5px6nl+nelEQZKlnrel6uKGjBdV3SXZRHKcSvLB41XuXUFeN hzgzj0MU+92+tuGATOzSUQrkHjRn9Am+goiyKqZIgNOUzeH/2nlZflFB7C+Q+RbQLp4G 2xtobreRQFePYz4usLmL/gHysWIls8wCYWvNWmzxjvr6p4hnnSZM8PMTeDthPnuL4VaP 4xEJP1UI/IWT1POlGHp3FdMAUShV085Sch+AAKD71FcSZMvL8QYRYFnx039lEfFMaIFF vzpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=kjNHNnwgUITt6jgNEbjkpSHkXX3K2XR8ypW6WPwBAt8=; b=JaYoP5h7wYbO0eyW60OpOTgMsueJQ4p4QcfDS3knnP6U5BDpRQYmJLTpLei/M9eyuK 0kcoJ/w5Rj5sFfVXFhtLw7Vs3HR/ZBqjn9fv+nUpLdnHfhG4tychPQEf7oI/kC0XHXEt 2Ip2zz8tk0N7PRadqL78NbM6g7K+kf4nbx5Ow8lg6MOFbhu/2aNybX7qKlCCD/ZjsMNB F5rVC78Uio3uCYC1leI/mAqBrf6fug+qormgtVkXE4jIkjsBUBzMRJykuT8eC7gAv1ET W4KL9YTznS8v/1JfouwQirCRnXjUt0wWz+g50UPQmSVVZbxMojLvHVwEsgAwVu7ILPEO lNug== X-Gm-Message-State: AKS2vOywk6iFwaPjsxsYG3d2eZkLBFgEEWPujFNE0xnFV1tYLCPGFt7h I4YzuB8QzFPolgND X-Received: by 10.80.170.218 with SMTP id r26mr5896809edc.113.1498838214778; Fri, 30 Jun 2017 08:56:54 -0700 (PDT) Received: from uHalley.cnexlabs.com (6164211-cl69.boa.fiberby.dk. [193.106.164.211]) by smtp.gmail.com with ESMTPSA id d36sm2705988edb.63.2017.06.30.08.56.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 30 Jun 2017 08:56:54 -0700 (PDT) From: "=?UTF-8?q?Javier=20Gonz=C3=A1lez?=" X-Google-Original-From: =?UTF-8?q?Javier=20Gonz=C3=A1lez?= To: mb@lightnvm.io, axboe@fb.com Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, =?UTF-8?q?Javier=20Gonz=C3=A1lez?= , =?UTF-8?q?Matias=20Bj=C3=B8rling?= Subject: [PATCH 04/10] lightnvm: pblk: schedule if data is not ready Date: Fri, 30 Jun 2017 17:56:37 +0200 Message-Id: <1498838203-21539-5-git-send-email-javier@cnexlabs.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1498838203-21539-1-git-send-email-javier@cnexlabs.com> References: <1498838203-21539-1-git-send-email-javier@cnexlabs.com> MIME-Version: 1.0 Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP When user threads place data into the write buffer, they reserve space and do the memory copy out of the lock. As a consequence, when the write thread starts persisting data, there is a chance that it is not copied yet. In this case, avoid polling, and schedule before retrying. Signed-off-by: Javier González Signed-off-by: Matias Bjørling --- drivers/lightnvm/pblk-rb.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/lightnvm/pblk-rb.c b/drivers/lightnvm/pblk-rb.c index 665a4ccfe7f5..2dda874af890 100644 --- a/drivers/lightnvm/pblk-rb.c +++ b/drivers/lightnvm/pblk-rb.c @@ -578,8 +578,10 @@ unsigned int pblk_rb_read_to_bio(struct pblk_rb *rb, struct nvm_rq *rqd, */ try: flags = READ_ONCE(entry->w_ctx.flags); - if (!(flags & PBLK_WRITTEN_DATA)) + if (!(flags & PBLK_WRITTEN_DATA)) { + io_schedule(); goto try; + } page = virt_to_page(entry->data); if (!page) {