From patchwork Wed Sep 6 10:51:00 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?UTF-8?q?Javier=20Gonz=C3=A1lez?= X-Patchwork-Id: 9940379 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 2E99C602CC for ; Wed, 6 Sep 2017 10:54:26 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 26AF4283DA for ; Wed, 6 Sep 2017 10:54:26 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1BCCD2856B; Wed, 6 Sep 2017 10:54:26 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B98D028650 for ; Wed, 6 Sep 2017 10:54:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753638AbdIFKyX (ORCPT ); Wed, 6 Sep 2017 06:54:23 -0400 Received: from mail-wm0-f43.google.com ([74.125.82.43]:37007 "EHLO mail-wm0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753317AbdIFKwo (ORCPT ); Wed, 6 Sep 2017 06:52:44 -0400 Received: by mail-wm0-f43.google.com with SMTP id u26so29535744wma.0 for ; Wed, 06 Sep 2017 03:52:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lightnvm-io.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=I87tFwddLGmM4h4Pt7Czt54nkaWRWTgYpwrT6PtqiZQ=; b=HFbm++43LKTvFvqM7cisg2R5YLzwsdWf1jcHMoPJP5SgcUqnrxYOm6q9KNXLkCvHbQ yL9vpS2C8G1ALSzxa+A+irQ+w/AV3PnKo89Pk90H5t6zWoavPKT4u7Tgef09griQ3eMc GJ+CCoq0O29s/TedZgRyGmxYNc4QJW4pfmyRNCZzQjZ2fDBU3cTTnqmqr885vXaUrzX9 4V0ScG/EO8HWrkhM9FSjiDw7jWRuT/o7Dzj3zkcI9/6B52ZVBtjdGC/nLySEgos/idPF 3wgO5zMZNK0fasfT5v/ftuUCXFiiP/QSgyl7ZmuFr393OVmQ56HM7WJSjRN6AtbgV+6O En2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=I87tFwddLGmM4h4Pt7Czt54nkaWRWTgYpwrT6PtqiZQ=; b=i+aPofCEdvQVI9UYXjzhJMmLe0UbsAHuENfUwT7X92lxUkxXBfbMjewuOS2upE6190 Z8EdsOGpTIzmrjeSmFbnGDtBy6QzMjXrr742mtpI3hMooroHuySN1JP7ivrwd+Snt3uj Iv3XClRlIWjaBGVGQRAd73e1NKBeJk3o5NK75b/Dg4oqiZ4RrcPp0pqMY/nx1rG12gol jZnnIu6k+S17DX63TlIvTT1UfUxfVZUw9YL/dQIT6hwd1Skf0KiJ3WCz+nXs7gc9qc55 49eMuHrKl4HL3EenQRV9wMCtXnG2dX7xWpdfbWcgjnggzhm2AlC3DZAFqQaThnVGYZfE 4cMQ== X-Gm-Message-State: AHPjjUjw2co80Qp4wuil72/L9RPS/qJ2vmWiiSFwa2zNAVtvwDwX+Euw josBpIJkl/RR0BkS X-Google-Smtp-Source: ADKCNb44w5K1zcAIVD1n61q2u0DHamsHn8BBMchtmzWVj4NKdjcNXHMgZSNHG8WdzXGPOU57Kfoupg== X-Received: by 10.80.163.69 with SMTP id 63mr1668646edn.253.1504695162925; Wed, 06 Sep 2017 03:52:42 -0700 (PDT) Received: from uHalley.cnexlabs.com (6164211-cl69.boa.fiberby.dk. [193.106.164.211]) by smtp.gmail.com with ESMTPSA id b8sm1044007edi.46.2017.09.06.03.52.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 06 Sep 2017 03:52:42 -0700 (PDT) From: "=?UTF-8?q?Javier=20Gonz=C3=A1lez?=" X-Google-Original-From: =?UTF-8?q?Javier=20Gonz=C3=A1lez?= To: mb@lightnvm.io, axboe@fb.com Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, =?UTF-8?q?Javier=20Gonz=C3=A1lez?= , =?UTF-8?q?Matias=20Bj=C3=B8rling?= Subject: [PATCH 07/18] lightnvm: pblk: use constant for GC parameter Date: Wed, 6 Sep 2017 12:51:00 +0200 Message-Id: <1504695071-25928-8-git-send-email-javier@cnexlabs.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1504695071-25928-1-git-send-email-javier@cnexlabs.com> References: <1504695071-25928-1-git-send-email-javier@cnexlabs.com> MIME-Version: 1.0 Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Use a constant instead of using meaningless tuning parameters on the garbage collector algorithms. Signed-off-by: Javier González Signed-off-by: Matias Bjørling --- drivers/lightnvm/pblk-gc.c | 4 ++-- drivers/lightnvm/pblk.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/lightnvm/pblk-gc.c b/drivers/lightnvm/pblk-gc.c index 6090d28f7995..92694e35afde 100644 --- a/drivers/lightnvm/pblk-gc.c +++ b/drivers/lightnvm/pblk-gc.c @@ -93,7 +93,7 @@ static int pblk_gc_move_valid_secs(struct pblk *pblk, struct pblk_gc_rq *gc_rq) retry: spin_lock(&gc->w_lock); - if (gc->w_entries >= PBLK_GC_W_QD) { + if (gc->w_entries >= PBLK_GC_RQ_QD) { spin_unlock(&gc->w_lock); pblk_gc_writer_kick(&pblk->gc); usleep_range(128, 256); @@ -602,7 +602,7 @@ int pblk_gc_init(struct pblk *pblk) spin_lock_init(&gc->w_lock); spin_lock_init(&gc->r_lock); - sema_init(&gc->gc_sem, 128); + sema_init(&gc->gc_sem, PBLK_GC_RQ_QD); INIT_LIST_HEAD(&gc->w_list); INIT_LIST_HEAD(&gc->r_list); diff --git a/drivers/lightnvm/pblk.h b/drivers/lightnvm/pblk.h index 08a463fe855f..b7f5fa8b49d0 100644 --- a/drivers/lightnvm/pblk.h +++ b/drivers/lightnvm/pblk.h @@ -818,7 +818,7 @@ int pblk_recov_setup_rq(struct pblk *pblk, struct pblk_c_ctx *c_ctx, * pblk gc */ #define PBLK_GC_MAX_READERS 8 /* Max number of outstanding GC reader jobs */ -#define PBLK_GC_W_QD 128 /* Queue depth for inflight GC write I/Os */ +#define PBLK_GC_RQ_QD 128 /* Queue depth for inflight GC requests */ #define PBLK_GC_L_QD 4 /* Queue depth for inflight GC lines */ #define PBLK_GC_RSV_LINE 1 /* Reserved lines for GC */