From patchwork Wed Feb 28 15:49:30 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?UTF-8?q?Javier=20Gonz=C3=A1lez?= X-Patchwork-Id: 10248171 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id B67D760211 for ; Wed, 28 Feb 2018 15:50:11 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A69C028D75 for ; Wed, 28 Feb 2018 15:50:11 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A52DB28D96; Wed, 28 Feb 2018 15:50:11 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EF1C328D96 for ; Wed, 28 Feb 2018 15:50:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933637AbeB1PuJ (ORCPT ); Wed, 28 Feb 2018 10:50:09 -0500 Received: from mail-wm0-f65.google.com ([74.125.82.65]:53219 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933622AbeB1PuA (ORCPT ); Wed, 28 Feb 2018 10:50:00 -0500 Received: by mail-wm0-f65.google.com with SMTP id t3so5887701wmc.2 for ; Wed, 28 Feb 2018 07:49:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lightnvm-io.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=eWbYRfjiLmB92VlMnPYAeyvU55QGOTkw/KgsWQ9RiSY=; b=ZjrtDiMpjIB8GqMA+MRGOxF0nn2I1O3lGyST2MignJi2RmiYP6V6nb37k64jRYQsgm 5NZN6kqwIxeROaWSCHT4NTp7COgWR3HTINERZPGnp0v8tZ1PGxhJ+bz0Kch9rxKLlVeY J5pCBDBY21WqkAJ38bzc81CdbGxXtJzTcXegIQDweniGyqZq/fYzHsIyMbvh6LawWxTd SNfWF/xF3cAxALkyh3eHU60OJGW64dERVxuGgFG+UcNK6cuqYbeOCk5C7x3l9cFdvswT 2q0n+DRcZXbzWaM3fKXGPH6S9JbDlE6MU1uPGlXdZTUdeCYu6qgsWPAmc4KIHusKI4nw yj9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=eWbYRfjiLmB92VlMnPYAeyvU55QGOTkw/KgsWQ9RiSY=; b=fXZZjN4Zwu4UlV+vtyk5dzdr0i4JdhxJB08S0cZI9x+xkAJZbSxISPS4VopmTsAanZ U5kg0aMCWRhLVzRHb9eNl0ZtJaX0EDbA7KoHGte/AtzJNYFNGJizTKb8p3fYsRKpaQmV mr5Y9WNqSgopufqMq7jDG+w5cBpogB7loFcMGwo4tz3nqknNP7K5uCgDZIM0BFVM6Ts0 pPtplWuw+0oxfky/tRvivX0lAvgLKUsedMimGjf8fzIKq5WqxOXtLrNpjhL1lhriBpOH RRpjBN3zBMTtEPuaIwEJz6TlZ4eiUqNdVuSAgL6bkM6bIILgDMuNEREAPtf9ZgaUhOp1 nHkQ== X-Gm-Message-State: APf1xPA8Eh+7VPKkpsLNJtCUHhAV5svr5lOZ45zQVnmfA8Bzebsz6myW ih/HdSTKtKd2oGWJoOWfEecuZcW/ X-Google-Smtp-Source: AG47ELtcBqFi3ce2kT2xf3Ci6o2gyoDCKLGv+wmnnxmAam0+9gwz7J7PT5l5d2HrO+oZrMJoSFYpow== X-Received: by 10.80.180.186 with SMTP id w55mr11440108edd.184.1519832998803; Wed, 28 Feb 2018 07:49:58 -0800 (PST) Received: from uHalley.cnexlabs.com (6164211-cl69.boa.fiberby.dk. [193.106.164.211]) by smtp.gmail.com with ESMTPSA id n2sm1953056edb.62.2018.02.28.07.49.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 28 Feb 2018 07:49:58 -0800 (PST) From: "=?UTF-8?q?Javier=20Gonz=C3=A1lez?=" X-Google-Original-From: =?UTF-8?q?Javier=20Gonz=C3=A1lez?= To: mb@lightnvm.io Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, =?UTF-8?q?Javier=20Gonz=C3=A1lez?= Subject: [PATCH 10/15] lightnvm: pblk: check for supported version Date: Wed, 28 Feb 2018 16:49:30 +0100 Message-Id: <1519832975-25432-11-git-send-email-javier@cnexlabs.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1519832975-25432-1-git-send-email-javier@cnexlabs.com> References: <1519832975-25432-1-git-send-email-javier@cnexlabs.com> MIME-Version: 1.0 Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP At this point, only 1.2 spec is supported, thus check for it. Also, since device-side L2P is only supported in the 1.2 spec, make sure to only check its value under 1.2. Signed-off-by: Javier González --- drivers/lightnvm/pblk-init.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/lightnvm/pblk-init.c b/drivers/lightnvm/pblk-init.c index 11424beb214c..b67b5b11ae16 100644 --- a/drivers/lightnvm/pblk-init.c +++ b/drivers/lightnvm/pblk-init.c @@ -991,9 +991,15 @@ static void *pblk_init(struct nvm_tgt_dev *dev, struct gendisk *tdisk, struct pblk *pblk; int ret; - if (dev->geo.dom & NVM_RSP_L2P) { + if (geo->version != NVM_OCSSD_SPEC_12) { + pr_err("pblk: OCSSD version not supported (%u)\n", + geo->version); + return ERR_PTR(-EINVAL); + } + + if (geo->version == NVM_OCSSD_SPEC_12 && geo->dom & NVM_RSP_L2P) { pr_err("pblk: host-side L2P table not supported. (%x)\n", - dev->geo.dom); + geo->dom); return ERR_PTR(-EINVAL); }