| Message ID | 1523452889-16331-1-git-send-email-jinpu.wangl@profitbricks.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
> -----Original Message----- > From: linux-kernel-owner@vger.kernel.org [mailto:linux-kernel- > owner@vger.kernel.org] On Behalf Of Jack Wang > Sent: Wednesday, April 11, 2018 8:21 AM > Subject: [PATCH] block: ratelimite pr_err on IO path > > From: Jack Wang <jinpu.wang@profitbricks.com> ... > - pr_err("%s: ref tag error at location %llu " \ > - "(rcvd %u)\n", iter->disk_name, > - (unsigned long long) > - iter->seed, be32_to_cpu(pi->ref_tag)); > + pr_err_ratelimited("%s: ref tag error at " > + "location %llu (rcvd %u)\n", Per process/coding-style.rst, you should keep a string like that on one line even if that exceeds 80 columns: Statements longer than 80 columns will be broken into sensible chunks, unless exceeding 80 columns significantly increases readability and does not hide information. ... However, never break user-visible strings such as printk messages, because that breaks the ability to grep for them.
On Wed, Apr 11, 2018 at 7:07 PM, Elliott, Robert (Persistent Memory) <elliott@hpe.com> wrote: >> -----Original Message----- >> From: linux-kernel-owner@vger.kernel.org [mailto:linux-kernel- >> owner@vger.kernel.org] On Behalf Of Jack Wang >> Sent: Wednesday, April 11, 2018 8:21 AM >> Subject: [PATCH] block: ratelimite pr_err on IO path >> >> From: Jack Wang <jinpu.wang@profitbricks.com> > ... >> - pr_err("%s: ref tag error at location %llu " \ >> - "(rcvd %u)\n", iter->disk_name, >> - (unsigned long long) >> - iter->seed, be32_to_cpu(pi->ref_tag)); >> + pr_err_ratelimited("%s: ref tag error at " >> + "location %llu (rcvd %u)\n", > > Per process/coding-style.rst, you should keep a string like that on > one line even if that exceeds 80 columns: > > Statements longer than 80 columns will be broken into sensible chunks, unless > exceeding 80 columns significantly increases readability and does not hide > information. ... However, never break user-visible strings such as > printk messages, because that breaks the ability to grep for them. > > Thanks Robert, as the original code keep the 80 columns, I just followed, I will fix it in v2.
diff --git a/block/t10-pi.c b/block/t10-pi.c index a98db38..35967d5 100644 --- a/block/t10-pi.c +++ b/block/t10-pi.c @@ -84,10 +84,12 @@ static blk_status_t t10_pi_verify(struct blk_integrity_iter *iter, if (be32_to_cpu(pi->ref_tag) != lower_32_bits(iter->seed)) { - pr_err("%s: ref tag error at location %llu " \ - "(rcvd %u)\n", iter->disk_name, - (unsigned long long) - iter->seed, be32_to_cpu(pi->ref_tag)); + pr_err_ratelimited("%s: ref tag error at " + "location %llu (rcvd %u)\n", + iter->disk_name, + (unsigned long long) + iter->seed, + be32_to_cpu(pi->ref_tag)); return BLK_STS_PROTECTION; } break; @@ -101,10 +103,12 @@ static blk_status_t t10_pi_verify(struct blk_integrity_iter *iter, csum = fn(iter->data_buf, iter->interval); if (pi->guard_tag != csum) { - pr_err("%s: guard tag error at sector %llu " \ - "(rcvd %04x, want %04x)\n", iter->disk_name, - (unsigned long long)iter->seed, - be16_to_cpu(pi->guard_tag), be16_to_cpu(csum)); + pr_err_ratelimited("%s: guard tag error at sector %llu " + "(rcvd %04x, want %04x)\n", + iter->disk_name, + (unsigned long long)iter->seed, + be16_to_cpu(pi->guard_tag), + be16_to_cpu(csum)); return BLK_STS_PROTECTION; }