diff mbox series

null_blk: fix checking for REQ_FUA

Message ID 154589c8c1b22879dfc03aec4555793329d5ce83.1550861849.git.heinzm@redhat.com (mailing list archive)
State New, archived
Headers show
Series null_blk: fix checking for REQ_FUA | expand

Commit Message

Heinz Mauelshagen Feb. 22, 2019, 7 p.m. UTC 
null_handle_bio() erroneously uses the bio_op macro
which masks respective request flag bits including REQ_FUA
out thus failing the check.

Fix by checking bio->bi_opf directly.

Signed-off-by: Heinz Mauelshagen <heinzm@redhat.com>
---
 drivers/block/null_blk_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jens Axboe Feb. 28, 2019, 9:03 p.m. UTC | #1 
On 2/22/19 12:00 PM, Heinz Mauelshagen wrote:
> null_handle_bio() erroneously uses the bio_op macro
> which masks respective request flag bits including REQ_FUA
> out thus failing the check.
> 
> Fix by checking bio->bi_opf directly.

Thanks, applied.
diff mbox series

Patch

diff --git a/drivers/block/null_blk_main.c b/drivers/block/null_blk_main.c
index 62c9654b9ce8..04b9d415511b 100644
--- a/drivers/block/null_blk_main.c
+++ b/drivers/block/null_blk_main.c
@@ -1104,7 +1104,7 @@  static int null_handle_bio(struct nullb_cmd *cmd)
 		len = bvec.bv_len;
 		err = null_transfer(nullb, bvec.bv_page, len, bvec.bv_offset,
 				     op_is_write(bio_op(bio)), sector,
-				     bio_op(bio) & REQ_FUA);
+				     bio->bi_opf & REQ_FUA);
 		if (err) {
 			spin_unlock_irq(&nullb->lock);
 			return err;