diff mbox series

[4/4] block: stop exporting bio_map_kern

Message ID 1564566096-28756-5-git-send-email-hans@owltronix.com (mailing list archive)
State New, archived
Headers show
Series lnvm/pblk mapping cleanups | expand

Commit Message

Hans Holmberg July 31, 2019, 9:41 a.m. UTC 
Now that there no module users left of bio_map_kern, stop
exporting the symbol.

Signed-off-by: Hans Holmberg <hans@owltronix.com>
---
 block/bio.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Javier González July 31, 2019, 5:13 p.m. UTC | #1 
> On 31 Jul 2019, at 11.41, Hans Holmberg <hans@owltronix.com> wrote:
> 
> Now that there no module users left of bio_map_kern, stop
> exporting the symbol.
> 
> Signed-off-by: Hans Holmberg <hans@owltronix.com>
> ---
> block/bio.c | 1 -
> 1 file changed, 1 deletion(-)
> 
> diff --git a/block/bio.c b/block/bio.c
> index 299a0e7651ec..96ca0b4e73bb 100644
> --- a/block/bio.c
> +++ b/block/bio.c
> @@ -1521,7 +1521,6 @@ struct bio *bio_map_kern(struct request_queue *q, void *data, unsigned int len,
> 	bio->bi_end_io = bio_map_kern_endio;
> 	return bio;
> }
> -EXPORT_SYMBOL(bio_map_kern);
> 
> static void bio_copy_kern_endio(struct bio *bio)
> {
> --
> 2.7.4

Haven’t realized we were the only users at this point. Nice cleanup.

Reviewed-by: Javier González <javier@javigon.com>
Christoph Hellwig Aug. 6, 2019, 7:07 a.m. UTC | #2 
On Wed, Jul 31, 2019 at 11:41:36AM +0200, Hans Holmberg wrote:
> Now that there no module users left of bio_map_kern, stop
> exporting the symbol.
> 
> Signed-off-by: Hans Holmberg <hans@owltronix.com>

Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>
diff mbox series

Patch

diff --git a/block/bio.c b/block/bio.c
index 299a0e7651ec..96ca0b4e73bb 100644
--- a/block/bio.c
+++ b/block/bio.c
@@ -1521,7 +1521,6 @@  struct bio *bio_map_kern(struct request_queue *q, void *data, unsigned int len,
 	bio->bi_end_io = bio_map_kern_endio;
 	return bio;
 }
-EXPORT_SYMBOL(bio_map_kern);
 
 static void bio_copy_kern_endio(struct bio *bio)
 {