From patchwork Thu Feb 9 15:33:55 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 9564923 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 190C660216 for ; Thu, 9 Feb 2017 15:36:21 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0846128535 for ; Thu, 9 Feb 2017 15:36:21 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id F14872853C; Thu, 9 Feb 2017 15:36:20 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 960D728535 for ; Thu, 9 Feb 2017 15:36:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752976AbdBIPgS (ORCPT ); Thu, 9 Feb 2017 10:36:18 -0500 Received: from mail-lf0-f51.google.com ([209.85.215.51]:34979 "EHLO mail-lf0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753919AbdBIPgI (ORCPT ); Thu, 9 Feb 2017 10:36:08 -0500 Received: by mail-lf0-f51.google.com with SMTP id n124so4530232lfd.2 for ; Thu, 09 Feb 2017 07:35:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=iz4KMC/d9NZUEsp3w+X1dhR5CGyVn8pJb3DutyhS2T4=; b=j9/M747JmBKsu1htjr61Jtmda/bOMPnyLt10ksv8tuZlguqqJex4VqHHGgkAret1jA Ge9Hlw9TAnkbaX3SoMQQiBEChjPWFmdHXfWJJw9ceQR9SCDIVpJGGZG8G3P2rZophMIF PYjD2/sZDxi4bRkBcM/5gdzobjO8BG95xzZD0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=iz4KMC/d9NZUEsp3w+X1dhR5CGyVn8pJb3DutyhS2T4=; b=Xdl9V/x+jC3eGJ5BwfeRMxOxCHxggmfbZn3Xo4jNa9SeJEPEoYk9ipp0eKM0qJzy7m zx0F4GqpYSlbyXmP5thNxnCbPdeiNuvinHcDq6lBpLY9AWNXn3GmQeSh3xaArNKAW+es I77r27Y726zCkcvu3v7gtONI+LqYAxk4iCRP+Zm83wUrB97+Ywarrmk9fjF0VgdPZgd1 43jKESYr+RhkD72WiWonQoej2OLBSYBIGjCbx8jY+zew/5AuJ51LgXGg3Wv04d2+MAHH jJqJOT3KdT4th93mMYS819YiEaxceNlVH3U0Gvx/yEJ+xdGmWWsYvHsbuV3xmkvVdGAq CmPQ== X-Gm-Message-State: AMke39koNsbMhNfhM51StnwfGz+/oecCUShSsS2jkrQ/Y7VO02Af4gZtNpU8pYio/8rcfDyE X-Received: by 10.25.200.14 with SMTP id y14mr1328251lff.98.1486654507119; Thu, 09 Feb 2017 07:35:07 -0800 (PST) Received: from gnarp.ideon.se ([85.235.10.227]) by smtp.gmail.com with ESMTPSA id e86sm3670614lji.32.2017.02.09.07.35.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 09 Feb 2017 07:35:05 -0800 (PST) From: Linus Walleij To: linux-mmc@vger.kernel.org, Ulf Hansson , Adrian Hunter , Paolo Valente Cc: Chunyan Zhang , Baolin Wang , linux-block@vger.kernel.org, Jens Axboe , Christoph Hellwig , Arnd Bergmann , Linus Walleij Subject: [PATCH 08/16] mmc: core: do away with is_new_req Date: Thu, 9 Feb 2017 16:33:55 +0100 Message-Id: <20170209153403.9730-9-linus.walleij@linaro.org> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20170209153403.9730-1-linus.walleij@linaro.org> References: <20170209153403.9730-1-linus.walleij@linaro.org> Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The host context member "is_new_req" is only assigned values, never checked. Delete it. Signed-off-by: Linus Walleij Reviewed-by: Bartlomiej Zolnierkiewicz --- drivers/mmc/core/core.c | 1 - drivers/mmc/core/queue.c | 5 ----- include/linux/mmc/host.h | 2 -- 3 files changed, 8 deletions(-) diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c index fcb40ade9b82..933a4d1f20d5 100644 --- a/drivers/mmc/core/core.c +++ b/drivers/mmc/core/core.c @@ -2985,7 +2985,6 @@ void mmc_unregister_pm_notifier(struct mmc_host *host) */ void mmc_init_context_info(struct mmc_host *host) { - host->context_info.is_new_req = false; host->context_info.is_waiting_last_req = false; } diff --git a/drivers/mmc/core/queue.c b/drivers/mmc/core/queue.c index 73250ed8f093..63927ffd6825 100644 --- a/drivers/mmc/core/queue.c +++ b/drivers/mmc/core/queue.c @@ -66,7 +66,6 @@ static int mmc_queue_thread(void *d) req = blk_fetch_request(q); mq->asleep = false; cntx->is_waiting_last_req = false; - cntx->is_new_req = false; if (!req) { /* * Dispatch queue is empty so set flags for @@ -136,10 +135,6 @@ static void mmc_request_fn(struct request_queue *q) cntx = &mq->card->host->context_info; - if (cntx->is_waiting_last_req) { - cntx->is_new_req = true; - } - if (mq->asleep) wake_up_process(mq->thread); } diff --git a/include/linux/mmc/host.h b/include/linux/mmc/host.h index cbb40682024a..970d7f9b1eba 100644 --- a/include/linux/mmc/host.h +++ b/include/linux/mmc/host.h @@ -194,11 +194,9 @@ struct mmc_slot { /** * mmc_context_info - synchronization details for mmc context - * @is_new_req wake up reason was new request * @is_waiting_last_req mmc context waiting for single running request */ struct mmc_context_info { - bool is_new_req; bool is_waiting_last_req; };