From patchwork Tue Feb 21 17:09:53 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Kara X-Patchwork-Id: 9585175 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id D8B1560578 for ; Tue, 21 Feb 2017 17:10:27 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C5E3E2851A for ; Tue, 21 Feb 2017 17:10:27 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id BA92B2861F; Tue, 21 Feb 2017 17:10:27 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 66AA42861E for ; Tue, 21 Feb 2017 17:10:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753789AbdBURK0 (ORCPT ); Tue, 21 Feb 2017 12:10:26 -0500 Received: from mx2.suse.de ([195.135.220.15]:56270 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753981AbdBURKW (ORCPT ); Tue, 21 Feb 2017 12:10:22 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 58A01ADC1; Tue, 21 Feb 2017 17:10:19 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id 60F451E10D8; Tue, 21 Feb 2017 18:10:16 +0100 (CET) From: Jan Kara To: Jens Axboe Cc: linux-block@vger.kernel.org, Christoph Hellwig , Dan Williams , Thiago Jung Bauermann , Lekshmi Pillai , Tejun Heo , NeilBrown , Omar Sandoval , Jan Kara Subject: [PATCH 08/13] bdi: Shutdown writeback on all cgwbs in cgwb_bdi_destroy() Date: Tue, 21 Feb 2017 18:09:53 +0100 Message-Id: <20170221170958.21845-9-jack@suse.cz> X-Mailer: git-send-email 2.10.2 In-Reply-To: <20170221170958.21845-1-jack@suse.cz> References: <20170221170958.21845-1-jack@suse.cz> Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Currently we waited for all cgwbs to get freed in cgwb_bdi_destroy() which also means that writeback has been shutdown on them. Since this wait is going away, directly shutdown writeback on cgwbs from cgwb_bdi_destroy() to avoid live writeback structures after bdi_unregister() has finished. Signed-off-by: Jan Kara Acked-by: Tejun Heo --- mm/backing-dev.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/mm/backing-dev.c b/mm/backing-dev.c index 54b9e934eef4..c9623b410170 100644 --- a/mm/backing-dev.c +++ b/mm/backing-dev.c @@ -700,6 +700,7 @@ static void cgwb_bdi_destroy(struct backing_dev_info *bdi) struct radix_tree_iter iter; struct rb_node *rbn; void **slot; + struct wb_writeback *wb; WARN_ON(test_bit(WB_registered, &bdi->wb.state)); @@ -716,6 +717,14 @@ static void cgwb_bdi_destroy(struct backing_dev_info *bdi) congested->__bdi = NULL; /* mark @congested unlinked */ } + while (!list_empty(&bdi->wb_list)) { + wb = list_first_entry(&bdi->wb_list, struct bdi_writeback, + bdi_node); + spin_unlock_irq(&cgwb_lock); + wb_shutdown(wb); + spin_lock_irq(&cgwb_lock); + } + spin_unlock_irq(&cgwb_lock); /*