From patchwork Sat Apr 15 18:55:51 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Matias_Bj=C3=B8rling?= X-Patchwork-Id: 9682385 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 8FE9360138 for ; Sat, 15 Apr 2017 18:58:38 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8256225223 for ; Sat, 15 Apr 2017 18:58:38 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 75B6F28305; Sat, 15 Apr 2017 18:58:38 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2CA7C25223 for ; Sat, 15 Apr 2017 18:58:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754252AbdDOS6Y (ORCPT ); Sat, 15 Apr 2017 14:58:24 -0400 Received: from mail-dm3nam03on0041.outbound.protection.outlook.com ([104.47.41.41]:38016 "EHLO NAM03-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755982AbdDOS5O (ORCPT ); Sat, 15 Apr 2017 14:57:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cnexlabs.onmicrosoft.com; s=selector1-cnexlabs-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Htga/AjURF9ye9Ytq0IDyiJqUZ/T2tYIKfB1YqyQGiE=; b=iZCjgkktWc+qJ9ISLVzV0Jo48fTvKVrCIGpjqcwNa+U5hwogl1PHYIhODmMQ0879TSly/21s16c/6j9LT2bSW4x/Vm0Chf481MO9QNrMlbQ8KmKwaKYYnqZSIbLPaQHaKhSAj2U0kffCtRUC+s9jU0fVKVvsS6+m8xTl1CbWK5w= Authentication-Results: fb.com; dkim=none (message not signed) header.d=none; fb.com; dmarc=none action=none header.from=cnexlabs.com; Received: from skyninja.cnexlabs.com (193.106.164.211) by CY4PR06MB2774.namprd06.prod.outlook.com (10.175.117.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1034.10; Sat, 15 Apr 2017 18:56:37 +0000 From: =?UTF-8?q?Matias=20Bj=C3=B8rling?= To: CC: , , Dan Carpenter , =?UTF-8?q?Matias=20Bj=C3=B8rling?= Subject: [GIT PULL 17/19] lightnvm: pblk-gc: fix an error pointer dereference in init Date: Sat, 15 Apr 2017 20:55:51 +0200 Message-ID: <20170415185553.16098-18-matias@cnexlabs.com> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20170415185553.16098-1-matias@cnexlabs.com> References: <20170415185553.16098-1-matias@cnexlabs.com> MIME-Version: 1.0 X-Originating-IP: [193.106.164.211] X-ClientProxiedBy: AM5PR0701CA0069.eurprd07.prod.outlook.com (10.169.145.159) To CY4PR06MB2774.namprd06.prod.outlook.com (10.175.117.142) X-MS-Office365-Filtering-Correlation-Id: c8d638cf-9056-4ce0-edd8-08d4843125df X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(201703131423075)(201703031133081); SRVR:CY4PR06MB2774; X-Microsoft-Exchange-Diagnostics: 1; CY4PR06MB2774; 3:XXTYEJMckUuZyy17KMy855ydW1enUWtxJigDW08ArS/TicDW15TzLlHEHMwGD2mOc/CZgEAtd3ZNFPn0MPDlnUCzzcNw8X0BJ1uR1nhw76tvlBCANLso1kUytyEJilZ3Sorrgq5quAQa+QZWmWXSkq+gp1eZneXF3gas0UwdiZRWR+AQ6YnQzu1LykBZMs5y+E2PI6fV90DcNRYX3Ruw2t/N1pvBfR3wGkjLDMYibjm1UcvLukCV0PMbgAYmTkriJMG7Yxc9L5rImnBV75mBnV/r7sJNqgpMAIEi8SOB+KmUm7rNVBO79oLGPM39q/JcdnL5Unh4usHUL1K8lmy1HQ==; 25:tKBbgFHz+HMF7T3n5kqNFk/SxBKue5vUCElbujM8qXQDAmgTCHAVRfg/UrKWbpxU+3xCa+5yZzz1Ssuq0PVVPUiRqKpM1cxjnr1fWYXUE9mj8rlr+KnNcj4SEtjebVOnZt34WQ8oSJdMBRWSfYrvnL80KD/bXIjLTEHmDIM87m/tJPAKHs8oVD72ua4xfZFrHp3AKPWml2L6C953SBxR3HCaLoKpO0BEA99lvJMo6VYxUlF6v6s1CJHie2dBVchcffWsx79RFYUKa60WNrTKAmRoR1gvvxiwHGjMpvrOk45LbbDxd4CSoCAWqbyO5KIrl499oPcELcwajGboIs94anhV1p5F/P6lVkkz7S5mdn/ThVJRVWFOJGh4eHJKULtZ+sd/2hXiXx4WKIA3/yUizH3fMWSowMH733r9wVgjNigyhzS/APKB+UzXU5H9+f/pv8Kjox2GXEIV2DTZE/JHuQ== X-Microsoft-Exchange-Diagnostics: 1; CY4PR06MB2774; 31:15oYpkLSYTpToZQz2bHSWxhXe9SldyAEqQQuIqkyIlDCiOp0E4K1fztu4LZliQ53hxJ3MzmnuqmZI1d3aENBQsYoRRm4nH9C3QB1AMf1fS9p03cpOrD/w+ZuNAvsy+Gxub+88Qnv4ahfdfjtZFLlbOgdpiouIgJ61UcAuDou8lHw8MyuFdp6s72Gaz5sQfGhEE0kgW5Mnd3KHt04hFUTmwCz0WLZsHiE2ejrl6bDXfRMZD7w8oJeQQeKF2OE5Udr; 20:HMl0yzkOHEwZfbcxud0rzE3hK/58Qp8vDuj88WFKcb1FCELvGjoI4ncTsBV746JutfRZCFuPyyRDjhmlGlALradsnkbtrNKaskr6g4UXpq6OagHY5D8g2Qdku1ODUzuZomt2rV0reic55FOTf2/U/mIwtN1qplShKR2BYMwZTZ8= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(146099531331640); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(601004)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(10201501046)(6041248)(20161123564025)(20161123562025)(20161123560025)(201703131423075)(201703061421075)(20161123555025)(6072148); SRVR:CY4PR06MB2774; BCL:0; PCL:0; RULEID:; SRVR:CY4PR06MB2774; X-Microsoft-Exchange-Diagnostics: 1; CY4PR06MB2774; 4:gYFeMVPcC4qt3Bf0kPMlTtX+q8tApfalB3Zw7K+FQvk+oiEKpbeFHf9Y7TJElMMyqxAMABps+rqTmFAW3nIALFrhmVpBPCo/xxsi4gTD7y1DNK6amATKeEVCTM7YmTqt/tZXKNTIiFHxj1VKpK9JHqVQ/N//dvcQ88ZFoCV7wk4UAyt/vrRxKBBT9nwFmhL+BJHZEr2V8QQSHu6Iyc2kIhaKJWRcNA9dJ8ALnI2h6mSTlaQDg79sJKuXbuti0oBs6VRlSNXs5XN5VoHebN/num+pL1nMym3QclsJ1/CZvyhQ136E1x4pONF0wpi5gLNv64knZC1MuyHzRbVHKVjpLOgUTkjEd75w7irn/ktiwTis6OWIQyJcYXwrpNiz4z8lWxzv4OWAuhWZIVBKO2orMqc8LTqzwL17Ol3JnA4bwCZXeZfYBa0mtNLjRLRk+glEO8QFHwz7+KgoTOn1asCSEEV3LLevRvEC08XZlvmkD6oypALYqSuqg64tEKGEDX6Pq5IkbcVrX6UTobJK6KnsTWvfY6frusuyTlCuV+Y34sNLVe8kyWtviSKEKTnUfKTqPCBVVnafEoIDf3RybzB1wEjp7wt7QqADir7I4cqIoXaxijXicKM6Fs2PVAChJwUaAhhsnXFWOp180CbfJQIjnGc7SvhaOoiJCiS4w1rLfacDWfbTxnpU/T2JBTqc6Di+VHXrINT1ajT3/10NlxEC8Y6a9sut0KdgoheeG5dgHJU= X-Forefront-PRVS: 02788FF38E X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(39400400002)(39450400003)(86362001)(305945005)(1076002)(6916009)(6666003)(25786009)(2950100002)(6486002)(2906002)(3846002)(6116002)(2870700001)(54906002)(189998001)(53936002)(53416004)(107886003)(110136004)(5660300001)(38730400002)(50986999)(76176999)(2351001)(4326008)(66066001)(5820100001)(23676002)(81166006)(47776003)(42186005)(36756003)(33646002)(50226002)(8676002)(217873001); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR06MB2774; H:skyninja.cnexlabs.com; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTRQUjA2TUIyNzc0OzIzOnNTUnJvNmNTdVZwTmtURHRFT0krRlpkYWE1?= =?utf-8?B?aWJXbTJJVlkwMXFMZzlHUnhIVFNQNTFxNzJ1cVoyZDlBR25RWFR5Y2k0M1Bz?= =?utf-8?B?ZWxBK3U1WFIwalpXRkVXMFdvcUJaaFowLzdhWW5oT2lQdWhrU0V5cHNVbHpM?= =?utf-8?B?WSthWlVRWUFickhRZzlDa3NVZUQzMkJ0MjNFWTdzU2d5V3lEREFsc1RTODI3?= =?utf-8?B?RUJsZ0xrRWdEWjJnY2ZOWTFKZHNwbi9Ld3hxMnRraXg0dTF1cVpLQnBYcjZ2?= =?utf-8?B?Rm85Y05sYUNGSWU3Z3J6SEViaTV3RWVheDU4RExRb0t5SVBwdkJCdmN4K2Nm?= =?utf-8?B?QjZGa0ExTzR1QVI3NVZJalRKb1NZdGtXWTlHUGRHVENTOGRPNi8wODZOWEVY?= =?utf-8?B?c0tBZHA5eld3M3pnODdDWUFuZGFyRllpNHZaSFhzTWdNaUZFSEJOOXJuclBK?= =?utf-8?B?cXlCWGdKb2tiZnU2UjN4aU9FU2J4NnJlN3djTFhSaGVaN21TWDMzbVBNdW5m?= =?utf-8?B?MGlZYWdiR3pUMklxTUNPL2NTd3lvNENValpoQWJnRmlGcmRoVmtqSXBiMFEx?= =?utf-8?B?RWJrWXErc1h4YTdNZUhndUJNY25QWGh3ZnRRT2VSWGNhRU9RK3lKUk55M1B2?= =?utf-8?B?T0UwVjBRY3YrbDZoMitUQzZZYjVoZWlpQllCQVFhNzh2Y2J1Z1RuOWlzdTZp?= =?utf-8?B?MWNUdjRhaWl4Z2RXcnkvSmdOOVRxWDg2Y0dRUW5VOVdzY0RvS2RpVjNoY3kr?= =?utf-8?B?bFhJWHhPbW83WUdBSElwWkl2VU1JOUViUzdBa2ZIQjQvZXZBMDRhSTBsRVRX?= =?utf-8?B?RTdhOGlNYW4yY3JHZHBOUmJnMkJsYkIwMTZ4OU5hSDNzWEVWejkweUJ1bmV3?= =?utf-8?B?YlFXRmZucmozZ0s3MnZUaEE0WVdGc3U4MkFlaG1BM3dyL2RybXpHZ3ZOY2d5?= =?utf-8?B?T1ZqV25PZkdBTXR2NUFoT2J3ZWd3cjZRVVZ1ZTVQL0lkYWJRaEUvQWRuNlVQ?= =?utf-8?B?a1h2MFNqTHBQbWVWaGRaQU5iY2E0azFqKzA1Zk1QVnJDQktEdWhyajBHUHhs?= =?utf-8?B?OWJGM0h2QkJxdDE4SDRhKzRaWFJYVHJUUDM1SmFPaVFsVzFOcGFiUjROL0ZM?= =?utf-8?B?Y2JJL0I0em9hN3Z1MmJqVjZNc2RucVBpcHVBMmpyZWdKVUVpdm00M0ttUThL?= =?utf-8?B?RkVvQSttYWtIMVZZcURGekdyY1BxamovWTF0dzJ3VkcvNDgwSmo4VWcxZjRv?= =?utf-8?B?MkhTc0J2UVRVSE5aK2I4ZTcvWUwvUzloU3JVSzlGWWdKKzdPTnFyUXZxbmVp?= =?utf-8?Q?7E3CFVGnVDWKgznK0hxC+29n0zqICLpo=3D?= X-Microsoft-Exchange-Diagnostics: 1; CY4PR06MB2774; 6:Yi9viU4jH6vbiZi+ufhaCNh39v4WwyooEPwFD51rF86CR1i0QFEYvr/NhZTm9TJx8GyHknfcWSxyp6xoAx42ADAwhG2c7o2jXvxdDJbonM6Xdcy3CiTcoxsi1A3WXtJIwo228NeDPZp8kvbim8IysU/7Qb17eRYBxxPNri3JUA/3Qu0USAVvFIDA/g98a8uh4MguDs6Q97Y2nyNM3MDNZo7NgJIbOGFdoqEHd8Q/eyrCydIRuDaY7BkJAe656UC27AYoPerDEBeFJeZGJHdkPPNIi3m1PIQDvJfmXNjq0GQNql0Z44WscMuvOhSMCFRa0cXa/eYPrrShom7SeNHTm9wexW2ttIrt2x+iKeLvrAELRxJ+hFi176EjOjNAW+j3XHwNLN1TRgRC6Dnsc+I07dfF0a6cPz0lNJKLcU6ztXUwW2O4YqYbnzRS/bSWyf3cdIyyZ2mrvOM/NJhdJ/2/7A==; 5:CkKJU/aSbq+4uCIE2b8tWsKA5ju4BESS2zAqLw67IPxyKubG3bd/F7JJAtua3B25EOgv/oD/JNBS1ejx7VpS+oIggqvs47Dzbq08ieXMmojSzuMqujXlXZBhbckDZZTLfZuykUBkOWPoTOIrtIvmAg==; 24:ajDSvrfX6RTg3+/o0NTyDn+JzDpB9qHNHvO6fJK04jger52PIWFiRtt+/8x7CHNG01pwdQx2NVUPw8JmKMOjm6S833//psMpwa6kzfuM3JA= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; CY4PR06MB2774; 7:QBOxe8SBpXvkZe6nAweCTX9ZHDYXAQRpUp0SkP0wTTjuFfHo6nXeXvkahyCIoH5gaM1RihUZocOcK1OCQb3iOnphkvyzVF71KuMA+8fphQ4GusRBVlJKonzxWbcAciI2dbEFP12u7NVCf63CoH26wEI8LlQgfB+xtM2my+R8z3ik/AdD8mlGPyPsaUMhbvlRsqRkoISbgNlhh6WepHmvt+talLFWM4Bnnd5dQQXLTKMwy5XNNXjdjOFxIECQ19IvcOICjmVnt0M8WbnzodxnvUvd4lO9pEZlvHJNnZ6CgRLZf+JbposS1eVo45XCzqt/fxAynUk7V2ijAJVPD4shxA== X-OriginatorOrg: cnexlabs.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Apr 2017 18:56:37.9320 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR06MB2774 Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Dan Carpenter These labels are reversed so we could end up dereferencing an error pointer or leaking. Fixes: 7f347ba6bb3a ("lightnvm: physical block device (pblk) target") Signed-off-by: Dan Carpenter Signed-off-by: Matias Bjørling --- drivers/lightnvm/pblk-gc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/lightnvm/pblk-gc.c b/drivers/lightnvm/pblk-gc.c index 9b147cf..f173fd4 100644 --- a/drivers/lightnvm/pblk-gc.c +++ b/drivers/lightnvm/pblk-gc.c @@ -527,10 +527,10 @@ int pblk_gc_init(struct pblk *pblk) return 0; -fail_free_main_kthread: - kthread_stop(gc->gc_ts); fail_free_writer_kthread: kthread_stop(gc->gc_writer_ts); +fail_free_main_kthread: + kthread_stop(gc->gc_ts); return ret; }