From patchwork Sat Apr 15 18:55:41 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Matias_Bj=C3=B8rling?= X-Patchwork-Id: 9682417 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 454A960138 for ; Sat, 15 Apr 2017 19:00:59 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3532425223 for ; Sat, 15 Apr 2017 19:00:59 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 26C312823D; Sat, 15 Apr 2017 19:00:59 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AA78625223 for ; Sat, 15 Apr 2017 19:00:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756020AbdDOTAb (ORCPT ); Sat, 15 Apr 2017 15:00:31 -0400 Received: from mail-dm3nam03on0041.outbound.protection.outlook.com ([104.47.41.41]:38016 "EHLO NAM03-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751616AbdDOS41 (ORCPT ); Sat, 15 Apr 2017 14:56:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cnexlabs.onmicrosoft.com; s=selector1-cnexlabs-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=RvBCqpQsgbd/9H5rPZmRPUK8MEmtty0j+6k0EOaflk4=; b=oY0g0E58cFYWtgcKTwAMpWPSYLy074XwgTuBNRa/qv9nqxkAlmnE84MwaGlrXPKvYxidbuo/+ya2WQAlax8o6ji+VdMdS/z5IGP2zEtinvyDuox3PxgGtUV7XNh1xZzQCfUleap1PNqLLxcJABy9GY2uNQbC9Wv5vwOc/ols150= Authentication-Results: fb.com; dkim=none (message not signed) header.d=none; fb.com; dmarc=none action=none header.from=cnexlabs.com; Received: from skyninja.cnexlabs.com (193.106.164.211) by CY4PR06MB2774.namprd06.prod.outlook.com (10.175.117.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1034.10; Sat, 15 Apr 2017 18:56:21 +0000 From: =?UTF-8?q?Matias=20Bj=C3=B8rling?= To: CC: , , NeilBrown , =?UTF-8?q?Matias=20Bj=C3=B8rling?= Subject: [GIT PULL 07/19] lightnvm: don't check for failure from mempool_alloc() Date: Sat, 15 Apr 2017 20:55:41 +0200 Message-ID: <20170415185553.16098-8-matias@cnexlabs.com> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20170415185553.16098-1-matias@cnexlabs.com> References: <20170415185553.16098-1-matias@cnexlabs.com> MIME-Version: 1.0 X-Originating-IP: [193.106.164.211] X-ClientProxiedBy: AM5PR0701CA0069.eurprd07.prod.outlook.com (10.169.145.159) To CY4PR06MB2774.namprd06.prod.outlook.com (10.175.117.142) X-MS-Office365-Filtering-Correlation-Id: 07c01f40-edd9-45fd-4b3a-08d484311c25 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(201703131423075)(201703031133081); SRVR:CY4PR06MB2774; X-Microsoft-Exchange-Diagnostics: 1; CY4PR06MB2774; 3:Gp5oxKzCTpvTxizGPOWLwG0bFCES8oSsjdbvMT63PhyePakPOnoZbnVUt8IHYjNu8I1KGcEPrztFxZaPLoBCM0STDMOiKkzCDmFHOAMBJp/oya05Wr3ZwKJdpPFEnndcLRhYJljSQ9syqK2on4JCsm76zJQ0KX0nZJVTgSyVOiVpJK+qMRC8aZWrc2ed4yDgm6188iQRmHfUXya7ihgn03F622I7BXwHCHMgSfqE17zzAcpRrQAexofZB7nl8kjXK3NheU9l7ANt+4C2cC62655oxKMVjIPzucx9fRenRakmL8LhTzoA5wvmpmduWuUYl8moeN8HsHaQoY6k+MuChg==; 25:mVs6L0YxF0gQ83vUgeoxE2n6d5GO9I4csmN3rjviYrIxwrk1vVeR9aHMTVaox4oIuQIj1quDWXMeO/VkUZvg70pjNrWIrZarXcDRcxEMzMejALDec23+wx+kmOPsxieKT59DXUWzfEOMHNIfQdjg7iBV4oNrsGQ7AxV0Ee8LaDBCDO+dhKFWs/VBc0tlKuRVplvrvoeaD4A8b2xx78w9KSRoQIUfKMV63N+e5T1gyxWD9uXe/XQMKpuAcXgSxVt6fw/hXs5IuCtVSVI3/xNNDdJIsHj7RX4jGNRHLUsXiy7elNR7rXHnLxpcdopN+djJn+BzakschLAGpKJQd1TBIknC7eieuGm0xv6yhRkcE/Fkm+SrYtRwZ+FrkfoLjX46KvSzQKIwhENfEkjBaZZtJbIHUNVivwdn9ywFdcPDY64n3at4FQ+3P9wB59S43GFw X-Microsoft-Exchange-Diagnostics: 1; CY4PR06MB2774; 31:gCKl+zkc/FI9OKlbOknksdMimL3LQIMgPRPay3TPzz7R64AK2KgCkFHEhH/QWdnONfAyvBxc5XN+wYPZ0Aff9As0wyVGyCqB5xBkAkh3xTMxTOrTLiknwSgoQgmmFI/UElcRutzrIqJETc/VNCRSL6QX5SRTkzOU6QsNzSlZisq65SLTQ+h0DarSeaKXPhPSw7sS8GO2gslRN3mBEfNCXSVyPzKXLm9hCvYZjV7B82TMh7nvsI2boT1XeKkummYz; 20:z7N2ZZNdhCLxvrc5DnGpq5RTQ+c4tTN4AKca0rIO65+v/UwqXrC95i/cAdICMxojPje3U8KD/R8cGVXBQu7lQms13TakwU98i2jJoJgMw2e4v76lY1vWuE6zJU2vG9f8n0AZkptslDqoQFUgjz9LRmexvWnW1Gc8bTNUi2FzEv0= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(601004)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(10201501046)(6041248)(20161123564025)(20161123562025)(20161123560025)(201703131423075)(201703061421075)(20161123555025)(6072148); SRVR:CY4PR06MB2774; BCL:0; PCL:0; RULEID:; SRVR:CY4PR06MB2774; X-Microsoft-Exchange-Diagnostics: 1; CY4PR06MB2774; 4:MoPgQaqUSKr2Y/hdCCZw/0jto9SbfBr0piy59C0bPJBVlUUI8MoQqFQbvt2nphGczXfYnlvJpQghLbqOx13BN6q071PnE30eQiFstK0FTxN+Vv5Dpv9gd2n/5ipKUrl5zO3ayZ00tnQtWMbJ+7GQqgL5CWaibQKJ57NINks2nkyaRR+KJFiA50Oa3/QqWCk56LsFPQG7aiebjZJ5+q9j86CCSTx6EMGocZWDxckEqMK82h6vd7drz/JwB8bYoWMM4sqBeeMDDst5fLwxhEcWLDC1XvkLkW5pW6RleInO1oUQ+l/e3dIeDca9a8xAQSoAW4W7ler9PrlAuFCoXSeZSX8Fw+q0m9alfM8r8vyxR5CH2BSCWFb3CabbREYAeiQj0e4lOKctnUiak4Vqb+UivfGsYKPbqXQwXpIpOAw14Lr5ihCR+glv9hygD4WETKWfWnUE4C1l3BkBvdsdcFe506OAxWZxE6nRMMUd459jxous2iPplKZG1LC7uLpmB1O7hMXMxkvkdMJiYTldvRIcmZcA5IBcxs9xhx9iKngLuM4IMpB+xyArtICF1/5BeUysermk17c/+Si4OmQstWamGbbdJ3kUmApzQTPnJcx7TcyJr1c6Kw4TmLOSLR3lt+KHqGYswgyVGdEIgTkbRJ5JDOkgJW/6IkAXRfTLgycEQXTeFZI4mjmigY+DRzWotsX+ X-Forefront-PRVS: 02788FF38E X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(39400400002)(39450400003)(86362001)(305945005)(1076002)(6916009)(6666003)(25786009)(2950100002)(6486002)(2906002)(3846002)(6116002)(2870700001)(54906002)(189998001)(53936002)(53416004)(107886003)(110136004)(5660300001)(38730400002)(50986999)(76176999)(2351001)(4326008)(66066001)(5820100001)(23676002)(81166006)(47776003)(42186005)(36756003)(33646002)(50226002)(8676002)(217873001); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR06MB2774; H:skyninja.cnexlabs.com; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTRQUjA2TUIyNzc0OzIzOkJmUUNkZ2d6VlJLa0VzODNxRGk4aHpnK0xj?= =?utf-8?B?bGpPNWNPMXhRc0RNdU5Md3dXSUlXWWtkc0g2bUhRV2FFb0JxbHgwei9FYjMw?= =?utf-8?B?U1dDVyt6c1dyMU9lNFVLVkFpS2JRWlVsRGE0OWNXajYxRkh0NnE2SElSN05x?= =?utf-8?B?UFA1MGtYaTFXTGpZeWJqMUZVRmFlc1NlVUo2SGUrN1JBMlZHS05TekRnMUNq?= =?utf-8?B?OHJHc2ZkeEplb3UzNUE0TlRYQ0V6b0Q0ZTUyMzUvQ25FOVFIWUZiZ1RYbFRO?= =?utf-8?B?Zk5xY1hrT0VDR205YWpLa0Y0dXdjL1hKSENQeVFJM3FkOFhDNUltaW9Bbmsr?= =?utf-8?B?STBIUUo1UnUyTzNSV2RCVHl1amxjS2paUzgzYnRRTzhleENBaWs4Rm9LNVk5?= =?utf-8?B?QW1FdkNJdjRlSm5zZGh1clBZSGFHZUZoYk5HMGpLRFgrMi9ZTUFzSVl5YXdR?= =?utf-8?B?RFVqV3ROZTZqbVA5RnZ2T2lGaEJNaGExYklkb2pXeE9UWUMrR0lMNnZoRGVX?= =?utf-8?B?a0JRL2d5SHl1ZU9HNEo2ZEd2eVBhL1lDdFBtZ0l4dlJzN2tCUjI2RE9tM2hG?= =?utf-8?B?dEt3c21oNmJVTnB0Mms0dlhlVXdRSHBzQlFXWWpZSzJzNm1qdFVEb1FzQ2d2?= =?utf-8?B?aS9XU21RVDFuM0VUOGN3TWJWLzN4NXJkZlRtUTJqZlVvck1xbDUyVngyMFJm?= =?utf-8?B?THc2RURldzUvdVlqZHdKTEdMdGZQL1R2dDV4OXoybHY2dmVxRlFBc01vRjZ6?= =?utf-8?B?V3UxMHV2bVRDYlFuazdSN3I1ZEZ2dU5wM2JWMkpUNGNkdi95VVNmVjZYUEN1?= =?utf-8?B?c281SmY2bjVFWU9ac1l1LzRGMmt6WDZpRnJKSHdSaS83SWJvMzBWRTlyYytC?= =?utf-8?B?VlpFVzVsZ0hJYlRvK01JSE1URU4xU3d5OTUzUkowNjhaRE1LVy9UODdHUUFI?= =?utf-8?B?RHordDBYNlZ1L1pDTzhDb2Fib1JleDVnUGZONHFjcE54KzRhdVhKVDRISzdW?= =?utf-8?B?cGZvMFVINldpQVFhSExGeUp1TkNlWkIvRXBlcEw1elhQclo2TW9DOHJ3MDZ5?= =?utf-8?B?ckE0K0dzYVhuSHFndnZtb3V4MGFNeUl1VmpnWm9nQ2tNTGxMSUhhSUhRMm9D?= =?utf-8?B?VzFKMDBWUmFRY3FtR3lxYVQyMTZKcFNTTGdOa2h0ODVoakxZVCtFcEtBOGND?= =?utf-8?B?U0xFZmd1SkpvTk50eHpjNEJxMmZiM21WcmtQVTRBcHlNc0QyNFdOWml4OE94?= =?utf-8?B?ak52OGh2d2RtOHIrZ21WK3JSTWRmTEhiTC9SZ0xLMzU0RUhtZnZoYVhtUmxh?= =?utf-8?Q?xRZqKoaF9VcmqCvqH3POf8p8NDzMviNA=3D?= X-Microsoft-Exchange-Diagnostics: 1; CY4PR06MB2774; 6:ET+P9v4df3d4jSVDTz/AdkIQaSlSGrOw9cs2nQJOubpE6cH9vt1U+vEG6qkQKJIJrm1lkDRaIAliVsrT62Nr3pl79tKe1hpsU1Ds6BdXJU0JQcCa3PztnhLmHGlmmsKMq24L1+E0enr9NXCcAoEVOIkvDvo5Lc0NvPUQsvQWqhiEE/2hf3k/yxVSZuNMV8qwW7x0izF3yUa0acMuVCkVJJiT/bcInSx8YCx6i+VyR2/K6PlZO8LcqQmfoZPYj/KaQL64cMBqSRZr4BEgeUoZmV4GjnaVdPp4He/sNp3LXUw4PeZ9EAkj3oEJAQUQqzddRaxFvYzUw329Ow+6DMPHv8wgSnHcT5iMHqT0YaNaX4LGXCBGJDD+ISsTr/LjnnsjGoiccLKiZY+wmv3IwaKC6+yb2q0FRoBW9nxl5WwZ+AgAX9Ctvb392XXtxrfVQD+nlUhjud6vPS682+QvLs8h/A==; 5:t/voVuyLM69WKmGHzvU9+wtyfSv1RcazW8SAWZdsMQEhq4XkenYI3uttqteXWLZAiDQoUNuk+rQ6aA2qLD+Wn+hpy3CQHJbf0jNhD1WacKUvEBmjXw65m0CM4KU4omNm+3a/6IZeNw5ADJ+LDsZiow==; 24:vEJMWaYwsJ5QGPBQCAti+UNt4PAQwM5oNNfGxF4pWFOUTiL2LffNJ6fRoap+BLOzd/XGW1UKLrqLf9/aMxbmfKaOblX0+T8fIuNOnhuPilo= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; CY4PR06MB2774; 7:SkcGkrcB1Nu3hTGghHL+LVsEyyv69cYVf/FAWHrwld3YCJv/3elxcvUApBlkbGmmrHJUPOL/hd/JIx7neJMZOwL1ECd9MA47G+zhjzIdNgBYVUwR1dzM9EFnsM5sBYmHgrgoaf6m4FdrWVJW9Kq1WZmjAcPTd/Sms6FPTmPj+yXisrECoCLpCOLUGzFtHDw9VPbgAFyCyIhsF02wS6wUzNk/1RqUUFdzZNq4wArezpCrfkawR71/1tlKNQF+1GqZ03D1SJu8Axx1/lSO2XcuQlXsQCtzkiB2qAdU97wHI8frjkWJIncLA70OJQhCN3ENdPUcsVFY4/zm+L/sBKCmFQ== X-OriginatorOrg: cnexlabs.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Apr 2017 18:56:21.6254 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR06MB2774 Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: NeilBrown mempool_alloc() cannot fail if the gfp flags allow it to sleep, and both GFP_KERNEL and GFP_NOIO allows for sleeping. So rrpc_move_valid_pages() and rrpc_make_rq() don't need to test the return value. Signed-off-by: NeilBrown Signed-off-by: Matias Bjørling --- drivers/lightnvm/rrpc.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/drivers/lightnvm/rrpc.c b/drivers/lightnvm/rrpc.c index 4e4c299..a8acf9e 100644 --- a/drivers/lightnvm/rrpc.c +++ b/drivers/lightnvm/rrpc.c @@ -318,10 +318,6 @@ static int rrpc_move_valid_pages(struct rrpc *rrpc, struct rrpc_block *rblk) } page = mempool_alloc(rrpc->page_pool, GFP_NOIO); - if (!page) { - bio_put(bio); - return -ENOMEM; - } while ((slot = find_first_zero_bit(rblk->invalid_pages, nr_sec_per_blk)) < nr_sec_per_blk) { @@ -1006,11 +1002,6 @@ static blk_qc_t rrpc_make_rq(struct request_queue *q, struct bio *bio) } rqd = mempool_alloc(rrpc->rq_pool, GFP_KERNEL); - if (!rqd) { - pr_err_ratelimited("rrpc: not able to queue bio."); - bio_io_error(bio); - return BLK_QC_T_NONE; - } memset(rqd, 0, sizeof(struct nvm_rq)); err = rrpc_submit_io(rrpc, bio, rqd, NVM_IOTYPE_NONE);