| Message ID | 20170427155437.23228-3-bart.vanassche@sandisk.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Apr 27, 2017 at 08:54:33AM -0700, Bart Van Assche wrote: > The first version of blk_mq_quiesce_queue() that was posted on > the linux-block mailing list waited for ongoing .queue_rq() > calls but did not stop the request queue. The current version > however stops the request queue. Hence reflect this behavior in > the comment above that function. Can you just combine this with patch 1? > Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com> > Cc: Hannes Reinecke <hare@suse.com> > Cc: Omar Sandoval <osandov@fb.com> > Cc: Ming Lei <ming.lei@redhat.com> > --- > block/blk-mq.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/block/blk-mq.c b/block/blk-mq.c > index 3b3420f76b5a..113c09d8026c 100644 > --- a/block/blk-mq.c > +++ b/block/blk-mq.c > @@ -157,8 +157,7 @@ EXPORT_SYMBOL_GPL(blk_mq_unfreeze_queue); > * @q: request queue. > * > * Note: this function does not prevent that the struct request end_io() > - * callback function is invoked. Additionally, it is not prevented that > - * new queue_rq() calls occur unless the queue has been stopped first. > + * callback function is invoked. > */ > void blk_mq_quiesce_queue(struct request_queue *q) > { > -- > 2.12.2 >
On Thu, 2017-04-27 at 15:37 -0700, Omar Sandoval wrote: > On Thu, Apr 27, 2017 at 08:54:33AM -0700, Bart Van Assche wrote: > > The first version of blk_mq_quiesce_queue() that was posted on > > the linux-block mailing list waited for ongoing .queue_rq() > > calls but did not stop the request queue. The current version > > however stops the request queue. Hence reflect this behavior in > > the comment above that function. > > Can you just combine this with patch 1? Hello Omar, Patch 1/6 has a "Cc: stable" tag but this patch not. The comment change is a separate patch because I don't think this comment change needs to be integrated in the stable kernel series. Bart.
On Thu, Apr 27, 2017 at 08:54:33AM -0700, Bart Van Assche wrote: > The first version of blk_mq_quiesce_queue() that was posted on > the linux-block mailing list waited for ongoing .queue_rq() > calls but did not stop the request queue. The current version > however stops the request queue. Hence reflect this behavior in > the comment above that function. > > Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com> > Cc: Hannes Reinecke <hare@suse.com> > Cc: Omar Sandoval <osandov@fb.com> > Cc: Ming Lei <ming.lei@redhat.com> > --- > block/blk-mq.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/block/blk-mq.c b/block/blk-mq.c > index 3b3420f76b5a..113c09d8026c 100644 > --- a/block/blk-mq.c > +++ b/block/blk-mq.c > @@ -157,8 +157,7 @@ EXPORT_SYMBOL_GPL(blk_mq_unfreeze_queue); > * @q: request queue. > * > * Note: this function does not prevent that the struct request end_io() > - * callback function is invoked. Additionally, it is not prevented that > - * new queue_rq() calls occur unless the queue has been stopped first. > + * callback function is invoked. > */ > void blk_mq_quiesce_queue(struct request_queue *q) > { Reviewed-by: Ming Lei <ming.lei@redhat.com> Thanks, Ming
diff --git a/block/blk-mq.c b/block/blk-mq.c index 3b3420f76b5a..113c09d8026c 100644 --- a/block/blk-mq.c +++ b/block/blk-mq.c @@ -157,8 +157,7 @@ EXPORT_SYMBOL_GPL(blk_mq_unfreeze_queue); * @q: request queue. * * Note: this function does not prevent that the struct request end_io() - * callback function is invoked. Additionally, it is not prevented that - * new queue_rq() calls occur unless the queue has been stopped first. + * callback function is invoked. */ void blk_mq_quiesce_queue(struct request_queue *q) {
The first version of blk_mq_quiesce_queue() that was posted on the linux-block mailing list waited for ongoing .queue_rq() calls but did not stop the request queue. The current version however stops the request queue. Hence reflect this behavior in the comment above that function. Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com> Cc: Hannes Reinecke <hare@suse.com> Cc: Omar Sandoval <osandov@fb.com> Cc: Ming Lei <ming.lei@redhat.com> --- block/blk-mq.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)